[Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-20 Thread Amos Kong
Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. | (qemu) device_del virti0-0-0 | (qemu) ** |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) It's a regression introduced by commit 57c9fafe The whole PC

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-29 Thread Anthony Liguori
On 05/20/2012 05:57 PM, Amos Kong wrote: Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. | (qemu) device_del virti0-0-0 | (qemu) ** |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) It's a regression

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-29 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 10:13:07AM +0800, Anthony Liguori wrote: > On 05/20/2012 05:57 PM, Amos Kong wrote: > >Start VM with 8 multiple-function block devs, hot-removing > >those block devs by 'device_del ...' would cause qemu abort. > > > >| (qemu) device_del virti0-0-0 > >| (qemu) ** > >|ERROR:qo

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 08:14:03AM +0300, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 10:13:07AM +0800, Anthony Liguori wrote: > > On 05/20/2012 05:57 PM, Amos Kong wrote: > > >Start VM with 8 multiple-function block devs, hot-removing > > >those block devs by 'device_del ...' would cause q

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-06-04 Thread Jason Baron
On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: > Start VM with 8 multiple-function block devs, hot-removing > those block devs by 'device_del ...' would cause qemu abort. > > | (qemu) device_del virti0-0-0 > | (qemu) ** > |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->r

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-06-04 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 04:15:56PM -0400, Jason Baron wrote: > On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: > > Start VM with 8 multiple-function block devs, hot-removing > > those block devs by 'device_del ...' would cause qemu abort. > > > > | (qemu) device_del virti0-0-0 > > | (qe

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-06-07 Thread Jason Baron
On Tue, Jun 05, 2012 at 12:52:02AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 04:15:56PM -0400, Jason Baron wrote: > > On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: > > > Start VM with 8 multiple-function block devs, hot-removing > > > those block devs by 'device_del ..

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-20 Thread Michael S. Tsirkin
On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: > Start VM with 8 multiple-function block devs, hot-removing > those block devs by 'device_del ...' would cause qemu abort. > > | (qemu) device_del virti0-0-0 > | (qemu) ** > |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->r