Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-26 Thread Mark Cave-Ayland
On 26/02/2019 19:03, Mark Cave-Ayland wrote: > On 26/02/2019 09:24, Alex Bennée wrote: > >>> Presumably the issue here is somehow related to the compiler incorrectly >>> extending/reducing the shift when the larger type is involved? Also during >>> my tests >>> the visual corruption was only pre

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-26 Thread Mark Cave-Ayland
On 26/02/2019 09:24, Alex Bennée wrote: >> Presumably the issue here is somehow related to the compiler incorrectly >> extending/reducing the shift when the larger type is involved? Also during >> my tests >> the visual corruption was only present for 32-bit accesses, but presumably >> all the >

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-26 Thread Alex Bennée
Mark Cave-Ayland writes: > On 19/02/2019 18:25, Emilio G. Cota wrote: > >> On Tue, Feb 19, 2019 at 14:22:37 +, Alex Bennée wrote: >>> Emilio, >>> >>> Any chance you could run it through your benchmark suite? >> >> Something isn't quite right. For instance, gcc in SPEC doesn't >> complete; i

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-25 Thread Mark Cave-Ayland
On 19/02/2019 18:25, Emilio G. Cota wrote: > On Tue, Feb 19, 2019 at 14:22:37 +, Alex Bennée wrote: >> Emilio, >> >> Any chance you could run it through your benchmark suite? > > Something isn't quite right. For instance, gcc in SPEC doesn't > complete; it fails after 2s with some errors abou

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-19 Thread Emilio G. Cota
On Tue, Feb 19, 2019 at 14:22:37 +, Alex Bennée wrote: > Emilio, > > Any chance you could run it through your benchmark suite? Something isn't quite right. For instance, gcc in SPEC doesn't complete; it fails after 2s with some errors about the syntax of the source being compiled. Before the

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-19 Thread Alex Bennée
Alex Bennée writes: > Hi, > > This is hopefully the final version of the softmmu demacro series. I > tracked down the remaining failures to: > > - not always using the correct victim tlb > - not masking reads when we unrolled the unaligned helpers > > Other than that I've rolled in the chan

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190215143115.28777-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190215143115.28777-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v3 0/3] softmmu

[Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-15 Thread Alex Bennée
Hi, This is hopefully the final version of the softmmu demacro series. I tracked down the remaining failures to: - not always using the correct victim tlb - not masking reads when we unrolled the unaligned helpers Other than that I've rolled in the changes that were made to support dynamic T