Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize

2015-02-08 Thread Paolo Bonzini
On 08/02/2015 18:22, Alex Williamson wrote: > Ok, I went back to 83761b9244ad, applied 3a4dbe6aa934 to get the > object_unparent() fix, then applied this series. Everything seems to > work ok. Then I manually applied and bisected the commits that came in > via d5fbb4c9ed52. I land on 374f2981d

Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize

2015-02-08 Thread Alex Williamson
On Sat, 2015-02-07 at 21:00 +0100, Paolo Bonzini wrote: > > On 07/02/2015 02:39, Alex Williamson wrote: > > I'm not sure where it's coming from yet, but I did extensive testing for > > my last pull request based on ec6f25e because if I updated to d5fbb4c > > vfio hotplug broke immediately. I'll k

Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize

2015-02-07 Thread Paolo Bonzini
On 07/02/2015 02:39, Alex Williamson wrote: > I'm not sure where it's coming from yet, but I did extensive testing for > my last pull request based on ec6f25e because if I updated to d5fbb4c > vfio hotplug broke immediately. I'll keep looking, but I thought I'd > share in case you have some idea

Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize

2015-02-06 Thread Alex Williamson
On Fri, 2015-02-06 at 22:15 +0100, Paolo Bonzini wrote: > Mostly the same as v2; We've got something screwy going on with MemoryListeners, I did some hotplug testing with this and I hit the following segfault: Program received signal SIGSEGV, Segmentation fault. 0x7ff7bd8f7416 in memory_liste

[Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize

2015-02-06 Thread Paolo Bonzini
Mostly the same as v2; - patch 1 makes the error paths of vfio_get_device a bit simpler - patch 2 introduces instance_finalize - patch 3 makes the freeing of BARs RCU-friendly Changes from v2: 1) not removing anymore the NULL assignment in vfio_put_base_device 2) patch 1 should "goto out_put"