Re: [Qemu-devel] [PATCH v3 2/5] xics: add reset() handler to ICPStateClass

2017-06-07 Thread David Gibson
On Wed, Jun 07, 2017 at 07:47:04PM +0200, Cédric Le Goater wrote: 1;4602;0c> On 06/07/2017 07:17 PM, Greg Kurz wrote: > > Taking into account that qemu_set_irq() returns immediatly if its first > > argument is NULL, icp_kvm_reset() largely duplicates icp_reset(). > > > > This patch introduces a

Re: [Qemu-devel] [PATCH v3 2/5] xics: add reset() handler to ICPStateClass

2017-06-07 Thread Cédric Le Goater
On 06/07/2017 07:17 PM, Greg Kurz wrote: > Taking into account that qemu_set_irq() returns immediatly if its first > argument is NULL, icp_kvm_reset() largely duplicates icp_reset(). > > This patch introduces a reset() handler, so that the common logic can > be implemented in icp_reset() only. >

[Qemu-devel] [PATCH v3 2/5] xics: add reset() handler to ICPStateClass

2017-06-07 Thread Greg Kurz
Taking into account that qemu_set_irq() returns immediatly if its first argument is NULL, icp_kvm_reset() largely duplicates icp_reset(). This patch introduces a reset() handler, so that the common logic can be implemented in icp_reset() only. While there we can also drop icp_kvm_realize() and