To clarify, if MXU is present (a cpu defined to have MXU instructions is
selected) we will never run any of the other special2 commands? That would
actually simplify the implementation.
Also I understand the want for clean code, I appreciate the comments.
-Original Message-
From: Aleksa
> To clarify, if MXU is present (a cpu defined to have MXU instructions is
> selected) we will never run any of the other special2 commands? That would
> actually simplify the implementation.
If presence of "special2_legacy" instructions and presence of MXU instructions
are mutually exclusive (
> From: Janeczek, Craig
> Sent: Tuesday, August 28, 2018 8:54 PM
>
> Subject: RE: [PATCH v3 2/8] target/mips: Add all MXU opcodes
>
> I will re-work each of the mxu_gen_ functions to check for MXUEN and
> jump over the implementation of the instruction if not enabled.
>
> I would like to clarify
I will re-work each of the mxu_gen_ functions to check for MXUEN and jump
over the implementation of the instruction if not enabled.
I would like to clarify the structure of the switch statement before
implementing it.
I was originally planning on checking if there was a MXU hit and MXUEN was s
> I see that I can check the loongson instructions by checking for
> INSN_LOONGSON2F. Using MXU if that is not set
One more thing to check is MXUEN bit of MXU control register. This should be
done before handling any MXU instructions, except S32M2I/S32I2M.
> What should I check for the mult or
I see that I can check the loongson instructions by checking for
INSN_LOONGSON2F. Using MXU if that is not set
What should I check for the mult or misc instructions that were there first?
-Original Message-
From: Aleksandar Markovic
Sent: Tuesday, August 28, 2018 11:07 AM
To: Janeczek,
> From: Craig Janeczek
> Sent: Tuesday, August 28, 2018 3:00 PM
> To: qemu-devel@nongnu.org
> Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek
> Subject: [PATCH v3 2/8] target/mips: Add all MXU opcodes
>
> Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with
> existi
Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with
existing misc and Loongson 2F copcodes. The enums were updated to
reflect the multiple possible meanings where applicable.
Signed-off-by: Craig Janeczek
---
v1
- NA
v2
- NA
v3
- Initial patch, split out from prio
