Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev

2011-06-07 Thread Paolo Bonzini
On 06/07/2011 11:19 AM, Markus Armbruster wrote: > That would be the "reg" value in DEFINE_SPAPR_PROPERTIES (patch 2). I > didn't make it a bus property because the default values varies Hmm. Explain that in a comment where the bus property would go? qdev.txt is probably a better place to

Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev

2011-06-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/07/2011 09:51 AM, Markus Armbruster wrote: >>> > diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c >>> > index 6f34159..a193caa 100644 >>> > --- a/hw/spapr_vio.c >>> > +++ b/hw/spapr_vio.c >>> > @@ -52,6 +52,10 @@ >>> >static struct BusInfo spapr_vio_bus_info = {

Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev

2011-06-07 Thread Paolo Bonzini
On 06/07/2011 09:51 AM, Markus Armbruster wrote: > diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c > index 6f34159..a193caa 100644 > --- a/hw/spapr_vio.c > +++ b/hw/spapr_vio.c > @@ -52,6 +52,10 @@ >static struct BusInfo spapr_vio_bus_info = { >.name = "spapr-vio", >.s

Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev

2011-06-07 Thread Markus Armbruster
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > hw/spapr_vio.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c > index 6f34159..a193caa 100644 > --- a/hw/spapr_vio.c > +++ b/hw/spapr_vio.c > @@ -52,6 +52,10 @@ >

[Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev

2011-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/spapr_vio.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c index 6f34159..a193caa 100644 --- a/hw/spapr_vio.c +++ b/hw/spapr_vio.c @@ -52,6 +52,10 @@ static struct BusInfo spapr_vio_bus_info = {