Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-09-04 Thread Jeff Cody
On Mon, Sep 04, 2017 at 10:51:24AM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 31, 2017 at 11:47:59AM -0400, Jeff Cody wrote: > > On Thu, Aug 31, 2017 at 04:39:49PM +0100, Stefan Hajnoczi wrote: > > > On Wed, Aug 30, 2017 at 06:40:29PM -0400, John Snow wrote: > > > > > > > > > > > > On

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-09-04 Thread Stefan Hajnoczi
On Thu, Aug 31, 2017 at 11:47:59AM -0400, Jeff Cody wrote: > On Thu, Aug 31, 2017 at 04:39:49PM +0100, Stefan Hajnoczi wrote: > > On Wed, Aug 30, 2017 at 06:40:29PM -0400, John Snow wrote: > > > > > > > > > On 08/30/2017 06:35 PM, Eric Blake wrote: > > > > On 08/30/2017 05:28 PM, John Snow

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-31 Thread Jeff Cody
On Thu, Aug 31, 2017 at 04:39:49PM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 30, 2017 at 06:40:29PM -0400, John Snow wrote: > > > > > > On 08/30/2017 06:35 PM, Eric Blake wrote: > > > On 08/30/2017 05:28 PM, John Snow wrote: > > > > > >> I'm a little iffy on this patch; I know that ./check

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-31 Thread Stefan Hajnoczi
On Wed, Aug 30, 2017 at 06:40:29PM -0400, John Snow wrote: > > > On 08/30/2017 06:35 PM, Eric Blake wrote: > > On 08/30/2017 05:28 PM, John Snow wrote: > > > >> I'm a little iffy on this patch; I know that ./check can take care of > >> our temp files for us now, but because each python test is

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread John Snow
On 08/30/2017 06:35 PM, Eric Blake wrote: > On 08/30/2017 05:28 PM, John Snow wrote: > >> I'm a little iffy on this patch; I know that ./check can take care of >> our temp files for us now, but because each python test is itself a >> little mini-harness, I'm a little leery of moving the

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread Eric Blake
On 08/30/2017 05:28 PM, John Snow wrote: > I'm a little iffy on this patch; I know that ./check can take care of > our temp files for us now, but because each python test is itself a > little mini-harness, I'm a little leery of moving the teardown to setup > and trying to pre-clean the confetti

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread John Snow
On 08/30/2017 02:33 PM, Eric Blake wrote: > On 08/30/2017 11:52 AM, Jeff Cody wrote: >> Now that 'check' will clean up after tests, try and make python >> tests leave intermediate files so that they might be inspectable >> on failure. >> >> This isn't perfect; the python unittest framework runs

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread Eric Blake
On 08/30/2017 11:52 AM, Jeff Cody wrote: > Now that 'check' will clean up after tests, try and make python > tests leave intermediate files so that they might be inspectable > on failure. > > This isn't perfect; the python unittest framework runs multiple > tests, even if previous tests failed.

[Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread Jeff Cody
Now that 'check' will clean up after tests, try and make python tests leave intermediate files so that they might be inspectable on failure. This isn't perfect; the python unittest framework runs multiple tests, even if previous tests failed. So we need to make sure that each test still begins