Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-22 Thread Max Reitz
On 22.07.2016 18:40, Paolo Bonzini wrote: > > > On 22/07/2016 18:27, Max Reitz wrote: >> >> So I can't see a strong argument for not modularizing the format block >> drivers, but in turn I don't have a strong argument for doing so either. >> >> Therefore: Why not? :-) > > The usual argument is

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-22 Thread Paolo Bonzini
On 22/07/2016 18:27, Max Reitz wrote: > > So I can't see a strong argument for not modularizing the format block > drivers, but in turn I don't have a strong argument for doing so either. > > Therefore: Why not? :-) The usual argument is that there is an additional cost in maintainability.

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-22 Thread Max Reitz
On 19.07.2016 12:54, Paolo Bonzini wrote: > > > On 14/07/2016 21:02, Colin Lord wrote: >> Here's v4 of the modularization series. Things that have changed since >> v3 include: >> >> - Fix indentation of the generated header file module_block.h >> - Drivers and probe functions are now all located

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-19 Thread Daniel P. Berrange
On Tue, Jul 19, 2016 at 04:42:38PM +0200, Paolo Bonzini wrote: > > > On 19/07/2016 15:47, Colin Lord wrote: > > However, the protocol drivers do tend to see noticeable performance > > benefits. Most of them get modularized in the first three patches of > > this series. This includes the iscsi,

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-19 Thread Paolo Bonzini
On 19/07/2016 15:47, Colin Lord wrote: > However, the protocol drivers do tend to see noticeable performance > benefits. Most of them get modularized in the first three patches of > this series. This includes the iscsi, glusterfs, ssh, curl, and rbd > drivers. Indeed, but... protocol drivers

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-19 Thread Colin Lord
On 07/19/2016 06:54 AM, Paolo Bonzini wrote: > > > On 14/07/2016 21:02, Colin Lord wrote: >> Here's v4 of the modularization series. Things that have changed since >> v3 include: >> >> - Fix indentation of the generated header file module_block.h >> - Drivers and probe functions are now all

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-19 Thread Paolo Bonzini
On 14/07/2016 21:02, Colin Lord wrote: > Here's v4 of the modularization series. Things that have changed since > v3 include: > > - Fix indentation of the generated header file module_block.h > - Drivers and probe functions are now all located in the block/ > directory, rather than being

[Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-14 Thread Colin Lord
Here's v4 of the modularization series. Things that have changed since v3 include: - Fix indentation of the generated header file module_block.h - Drivers and probe functions are now all located in the block/ directory, rather than being split between block/ and block/probe/. In addition the