Re: [Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated

2017-05-19 Thread Eduardo Habkost
On Fri, May 19, 2017 at 04:58:23PM +0200, Kashyap Chamarthy wrote: > On Tue, May 09, 2017 at 02:27:35PM +0100, Daniel P. Berrange wrote: > > Change the nested if statements into a flat format, to make > > it clearer what validation / capping is being performed on > > different CPUID index values.

Re: [Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated

2017-05-19 Thread Kashyap Chamarthy
On Tue, May 09, 2017 at 02:27:35PM +0100, Daniel P. Berrange wrote: > Change the nested if statements into a flat format, to make > it clearer what validation / capping is being performed on > different CPUID index values. > > NB this changes behaviour when "index > env->cpuid_xlevel2". > This

[Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated

2017-05-09 Thread Daniel P. Berrange
Change the nested if statements into a flat format, to make it clearer what validation / capping is being performed on different CPUID index values. NB this changes behaviour when "index > env->cpuid_xlevel2". This won't have any guest-visible effect because no there is no CPUID[0xC001]