Re: [Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA routing

2013-03-04 Thread Michael S. Tsirkin
On Sun, Mar 03, 2013 at 10:21:32AM -0700, Alex Williamson wrote: > Each PCI Bridge has a set of implied VGA regions that are enabled when > the VGA bit is set in the bridge control register. This allows VGA > devices behind bridges. Unfortunately with VGA Enable, which we > formerly allowed but d

Re: [Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA routing

2013-03-03 Thread Alex Williamson
On Mon, 2013-03-04 at 09:39 +0800, Peter Maydell wrote: > On 4 March 2013 01:21, Alex Williamson wrote: > > --- a/hw/pci/pcie_port.c > > +++ b/hw/pci/pcie_port.c > > @@ -28,10 +28,12 @@ void pcie_port_init_reg(PCIDevice *d) > > pci_set_word(d->config + PCI_SEC_STATUS, 0); > > > > /* Unli

Re: [Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA routing

2013-03-03 Thread Peter Maydell
On 4 March 2013 01:21, Alex Williamson wrote: > --- a/hw/pci/pcie_port.c > +++ b/hw/pci/pcie_port.c > @@ -28,10 +28,12 @@ void pcie_port_init_reg(PCIDevice *d) > pci_set_word(d->config + PCI_SEC_STATUS, 0); > > /* Unlike conventional pci bridge, some bits are hardwired to 0. */ > +#defin

[Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA routing

2013-03-03 Thread Alex Williamson
Each PCI Bridge has a set of implied VGA regions that are enabled when the VGA bit is set in the bridge control register. This allows VGA devices behind bridges. Unfortunately with VGA Enable, which we formerly allowed but didn't back, comes along some required VGA baggage. VGA Palette Snooping