On 28/09/2015 11:31, Markus Armbruster wrote:
>> However, while changing the command to
>> >
>> > { 'command': 'netdev_add', 'data': 'Netdev', 'box': true, 'gen': false }
>> >
>> > for better introspection, you should keep 'gen':'false' and the manual
>> > implementation based on qemu_opts_from_q
Paolo Bonzini writes:
> On 23/09/2015 18:37, Eric Blake wrote:
Is this still type-unsafe like the old netdev_add (e.g. accepts
a string for an integer)?
>> I did not address that yet; it still needs further patches to
>> accept an integer as a port number. I can investigate what
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 23/09/2015 18:37, Eric Blake wrote:
>>>
>>> Is this still type-unsafe like the old netdev_add (e.g. accepts
>>> a string for an integer)?
> I did not address that yet; it still needs further patches to
> accept an integer as a port number. I ca
On 09/23/2015 09:40 AM, Paolo Bonzini wrote:
>
>
> On 21/09/2015 23:58, Eric Blake wrote:
>> We finally have all the required pieces for doing a type-safe
>> representation of netdev_add as a flat union, where the
>> discriminator 'type' now selects which additional members may
>> appear in the "
On 21/09/2015 23:58, Eric Blake wrote:
> We finally have all the required pieces for doing a type-safe
> representation of netdev_add as a flat union, where the
> discriminator 'type' now selects which additional members may
> appear in the "arguments" JSON object sent over QMP, while
> making no
We finally have all the required pieces for doing a type-safe
representation of netdev_add as a flat union, where the
discriminator 'type' now selects which additional members may
appear in the "arguments" JSON object sent over QMP, while
making no changes to the set of previously-valid QMP command
