Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-24 Thread Peter Chubb
> "Paolo" == Paolo Bonzini writes: Paolo> Il 23/04/2012 22:54, Peter Chubb ha scritto: Peter> What is this calculation supposed to do? It doesn't convert a Peter> 10-bit signed twos-complement number into an int32_t, unless Peter> I'm confused... Also, it's a rather opaque way to write "mfn &

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 22:54, Peter Chubb ha scritto: > Peter> What is this calculation supposed to do? It doesn't convert a > Peter> 10-bit signed twos-complement number into an int32_t, unless > Peter> I'm confused... Also, it's a rather opaque way to write "mfn &= > Peter> 0x200;". > > I'll use a differ

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-23 Thread Peter Chubb
> "Peter" == Peter Maydell writes: Peter> On 23 April 2012 00:31, Peter Chubb Peter> wrote: Peter> Rather than having the *_clk_freq saved and loaded in the Peter> vmstate, I think it would be nicer to have a post-load-hook Peter> that called update_clocks(). OK. >>    /* mfn is 10-bit s

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-23 Thread Peter Maydell
On 23 April 2012 00:31, Peter Chubb wrote: > +    /* Frequencies precalculated on register changes */ > +    uint32_t pll_refclk_freq; > +    uint32_t mcu_clk_freq; > +    uint32_t hsp_clk_freq; > +    uint32_t ipg_clk_freq; > +} IMXCCMState; > + > +static const VMStateDescription vmstate_imx_ccm

[Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-22 Thread Peter Chubb
For Linux to be able to work out how fast its clocks are going, so that timer ticks come approximately at the right time, it needs to be able to query the clock control module (CCM). This is the start of a CCM implementation. It currently knows only about the MCU, HSP and IPG clocks --- i.e., t