Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-12 Thread Eric Blake
On 05/12/2016 05:25 AM, Paolo Bonzini wrote: > > > On 06/05/2016 18:26, Eric Blake wrote: >> @@ -340,11 +338,12 @@ static void scsi_do_read(SCSIDiskReq *r, int ret) >> r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, r->sector, >> scsi_dma_com

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-12 Thread Paolo Bonzini
On 12/05/2016 13:25, Paolo Bonzini wrote: >> > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, >> > r->sector, >> > scsi_dma_complete, r); > This is broken, it should be changed to an offset in the previous patch. > > Please rename the func

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-12 Thread Paolo Bonzini
On 06/05/2016 18:26, Eric Blake wrote: > @@ -340,11 +338,12 @@ static void scsi_do_read(SCSIDiskReq *r, int ret) > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, r->sector, > scsi_dma_complete, r); This is broken, it should be changed to an

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 14:56 hat Eric Blake geschrieben: > On 05/10/2016 02:55 AM, Kevin Wolf wrote: > > Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: > >> Sector-based blk_aio_readv() and blk_aio_writev() should die; switch > >> to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. > >> > >

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-10 Thread Eric Blake
On 05/10/2016 02:55 AM, Kevin Wolf wrote: > Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: >> Sector-based blk_aio_readv() and blk_aio_writev() should die; switch >> to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. >> >> As part of the cleanup, scsi_init_iovec() no longer needs to

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-10 Thread Kevin Wolf
Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: > Sector-based blk_aio_readv() and blk_aio_writev() should die; switch > to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. > > As part of the cleanup, scsi_init_iovec() no longer needs to return > a value, and reword a comment. > > Si

[Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-06 Thread Eric Blake
Sector-based blk_aio_readv() and blk_aio_writev() should die; switch to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. As part of the cleanup, scsi_init_iovec() no longer needs to return a value, and reword a comment. Signed-off-by: Eric Blake --- v7: remove more unused 'n', fix com