Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Auger Eric
Hi, On 13/11/2017 14:44, Peter Maydell wrote: > On 13 November 2017 at 13:37, Auger Eric wrote: >> On 13/11/2017 14:08, Peter Maydell wrote: >>> Not being able to conveniently wire up a sysbus device on the >>> command line or pass it options are general problems. I don't >>> think the SMMU is a

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 13:37, Auger Eric wrote: > On 13/11/2017 14:08, Peter Maydell wrote: >> Not being able to conveniently wire up a sysbus device on the >> command line or pass it options are general problems. I don't >> think the SMMU is a special case that should work around these >> general

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Auger Eric
Hi Peter, On 13/11/2017 14:08, Peter Maydell wrote: > On 13 November 2017 at 13:00, Auger Eric wrote: >> On 09/10/2017 19:47, Peter Maydell wrote: >>> More generally, why is sysbus-fdt involved in this at all? >>> I expected that instantiating and wiring up the SMMU would >>> be the job of hw/arm

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 13:00, Auger Eric wrote: > On 09/10/2017 19:47, Peter Maydell wrote: >> More generally, why is sysbus-fdt involved in this at all? >> I expected that instantiating and wiring up the SMMU would >> be the job of hw/arm/virt.c, like any other device we >> might have on the boar

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Auger Eric
Hi Peter, On 09/10/2017 19:47, Peter Maydell wrote: > On 1 September 2017 at 18:21, Eric Auger wrote: >> The VirtMachineState contains some dt phandles that will be used >> in some node creation functions. For instance we plan to use the >> PCI host controller phandle in the smmu node creation fu

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-10-09 Thread Peter Maydell
On 1 September 2017 at 18:21, Eric Auger wrote: > The VirtMachineState contains some dt phandles that will be used > in some node creation functions. For instance we plan to use the > PCI host controller phandle in the smmu node creation function. So > let's pass the VirtMachineState handle down t

[Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-09-01 Thread Eric Auger
The VirtMachineState contains some dt phandles that will be used in some node creation functions. For instance we plan to use the PCI host controller phandle in the smmu node creation function. So let's pass the VirtMachineState handle down to the node creation functions by enhancing the involved d