Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-05-04 Thread Michael Clark
On Sat, May 5, 2018 at 11:54 AM, Alistair Francis wrote: > On Fri, May 4, 2018 at 4:44 PM Alistair Francis > wrote: > > > On Thu, May 3, 2018 at 6:45 PM Michael Clark wrote: > > > > > > On Sat, Apr 28, 2018 at 4:17 AM, Alistair Francis < > alistai...@gmail.com> > > wrote: > > > >> On Thu, Apr 2

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-05-04 Thread Alistair Francis
On Fri, May 4, 2018 at 4:44 PM Alistair Francis wrote: > On Thu, May 3, 2018 at 6:45 PM Michael Clark wrote: > > On Sat, Apr 28, 2018 at 4:17 AM, Alistair Francis > wrote: > >> On Thu, Apr 26, 2018 at 10:34 PM Michael Clark wrote: > >> > On Fri, Apr 27, 2018 at 5:22 PM, Michael Clark w

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-05-04 Thread Alistair Francis
On Thu, May 3, 2018 at 6:45 PM Michael Clark wrote: > On Sat, Apr 28, 2018 at 4:17 AM, Alistair Francis wrote: >> On Thu, Apr 26, 2018 at 10:34 PM Michael Clark wrote: >> > On Fri, Apr 27, 2018 at 5:22 PM, Michael Clark wrote: >> >> On Fri, Apr 27, 2018 at 4:48 AM, Alistair Francis <

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-05-03 Thread Michael Clark
On Sat, Apr 28, 2018 at 4:17 AM, Alistair Francis wrote: > On Thu, Apr 26, 2018 at 10:34 PM Michael Clark wrote: > > > > > On Fri, Apr 27, 2018 at 5:22 PM, Michael Clark wrote: > > > > >> On Fri, Apr 27, 2018 at 4:48 AM, Alistair Francis > > wrote: > > >>> On Wed, Apr 25, 2018 at 5:03 PM Micha

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-04-27 Thread Alistair Francis
On Thu, Apr 26, 2018 at 10:34 PM Michael Clark wrote: > On Fri, Apr 27, 2018 at 5:22 PM, Michael Clark wrote: >> On Fri, Apr 27, 2018 at 4:48 AM, Alistair Francis wrote: >>> On Wed, Apr 25, 2018 at 5:03 PM Michael Clark wrote: >>> > The sifive_u machine already marks its ROM readonly. T

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-04-26 Thread Michael Clark
On Fri, Apr 27, 2018 at 5:22 PM, Michael Clark wrote: > > > On Fri, Apr 27, 2018 at 4:48 AM, Alistair Francis > wrote: > >> On Wed, Apr 25, 2018 at 5:03 PM Michael Clark wrote: >> >> > The sifive_u machine already marks its ROM readonly. This fixes >> > the remaining boards. This commit also ma

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-04-26 Thread Michael Clark
On Fri, Apr 27, 2018 at 4:48 AM, Alistair Francis wrote: > On Wed, Apr 25, 2018 at 5:03 PM Michael Clark wrote: > > > The sifive_u machine already marks its ROM readonly. This fixes > > the remaining boards. This commit also makes all boards use > > mask_rom as the variable name for the ROM. Thi

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-04-26 Thread Alistair Francis
On Wed, Apr 25, 2018 at 5:03 PM Michael Clark wrote: > The sifive_u machine already marks its ROM readonly. This fixes > the remaining boards. This commit also makes all boards use > mask_rom as the variable name for the ROM. This change also > makes space for the maximum device tree size size an

[Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

2018-04-25 Thread Michael Clark
The sifive_u machine already marks its ROM readonly. This fixes the remaining boards. This commit also makes all boards use mask_rom as the variable name for the ROM. This change also makes space for the maximum device tree size size and adds an explicit bounds check and error message. Cc: Sagar K