[Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports

2009-10-20 Thread Amit Shah
This patch migrates virtio-console to the qdev infrastructure and creates a new virtio-serial bus on which multiple ports are exposed as devices. The bulk of the code now resides in a new file with virtio-console.c being just a simple qdev device. This interface enables spawning of multiple

Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports

2009-10-20 Thread Gerd Hoffmann
+static VirtIOSerialPortInfo virtcon_info = { +.qdev.name = virtconsole, +.qdev.size = sizeof(VirtConsole), +.init = vcon_initfn, +.have_data = flush_buf, +.qdev.props = (Property[]) { +DEFINE_PROP_CHR(chardev, VirtConsole, chr), +

Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports

2009-10-20 Thread Amit Shah
On (Tue) Oct 20 2009 [12:08:06], Richard W.M. Jones wrote: On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote: DEF(virtioconsole, HAS_ARG, QEMU_OPTION_virtiocon, \ -virtioconsole c\n \ -set virtio console\n) +define virtio console\n)

Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports

2009-10-20 Thread Richard W.M. Jones
On Tue, Oct 20, 2009 at 05:31:23PM +0530, Amit Shah wrote: How about (deprecated)? (We need to have this in some general policy of deprecating command-line options.) No, the important thing is that we can detect somehow that multiport virtio console is possible for some random version of qemu

Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports

2009-10-20 Thread Amit Shah
On (Tue) Oct 20 2009 [13:05:59], Richard W.M. Jones wrote: On Tue, Oct 20, 2009 at 05:31:23PM +0530, Amit Shah wrote: How about (deprecated)? (We need to have this in some general policy of deprecating command-line options.) No, the important thing is that we can detect somehow that