Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Li Zhang
On Mon, Jun 18, 2012 at 3:54 PM, Peter Crosthwaite wrote: >> >> 3. Can't have USB: fail if the user tries to enable it. >> >> Code sketch: >> >>    /* init USB devices */ >>    if (!machine->has_usb) { >>        if (usb_enabled) >>            [report error; should point to the offending options] >

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Li Zhang
On Mon, Jun 18, 2012 at 3:29 PM, Markus Armbruster wrote: > Li Zhang writes: > >> On Fri, Jun 15, 2012 at 10:34 PM, Markus Armbruster >> wrote: >>> Li Zhang writes: >>> On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster wrote: > Li Zhang writes: > >> For pseries machin

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Peter Crosthwaite
> > 3. Can't have USB: fail if the user tries to enable it. > > Code sketch: > >    /* init USB devices */ >    if (!machine->has_usb) { >        if (usb_enabled) >            [report error; should point to the offending options] >            exit(1); >        } >    } else { >        if (machine->

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Markus Armbruster
Li Zhang writes: > On Fri, Jun 15, 2012 at 10:34 PM, Markus Armbruster wrote: >> Li Zhang writes: >> >>> On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster >>> wrote: Li Zhang writes: > For pseries machine, it needs to enable usb to add > keyboard or usb mouse. -usb option

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-17 Thread Li Zhang
On Fri, Jun 15, 2012 at 10:34 PM, Markus Armbruster wrote: > Li Zhang writes: > >> On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster wrote: >>> Li Zhang writes: >>> For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in the future,

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Markus Armbruster
Li Zhang writes: > On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster wrote: >> Li Zhang writes: >> >>> For pseries machine, it needs to enable usb to add >>> keyboard or usb mouse. -usb option won't be used in >>> the future, and machine options is a better way to >>> enable usb. >>> >>> So th

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Li Zhang
On Fri, Jun 15, 2012 at 8:30 PM, Andreas Färber wrote: > Am 15.06.2012 12:06, schrieb Li Zhang: >> For pseries machine, it needs to enable usb to add >> keyboard or usb mouse. -usb option won't be used in >> the future, and machine options is a better way to >> enable usb. >> >> So this patch is t

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Li Zhang
On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster wrote: > Li Zhang writes: > >> For pseries machine, it needs to enable usb to add >> keyboard or usb mouse. -usb option won't be used in >> the future, and machine options is a better way to >> enable usb. >> >> So this patch is to add usb option

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Andreas Färber
Am 15.06.2012 12:06, schrieb Li Zhang: > For pseries machine, it needs to enable usb to add > keyboard or usb mouse. -usb option won't be used in > the future, and machine options is a better way to > enable usb. > > So this patch is to add usb option to machine options > (-machine type=psereis,us

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Markus Armbruster
Li Zhang writes: > For pseries machine, it needs to enable usb to add > keyboard or usb mouse. -usb option won't be used in > the future, and machine options is a better way to > enable usb. > > So this patch is to add usb option to machine options > (-machine type=psereis,usb=on/off)to enable/di

[Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Li Zhang
For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in the future, and machine options is a better way to enable usb. So this patch is to add usb option to machine options (-machine type=psereis,usb=on/off)to enable/disable usb controller. In this p