Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 12:04:36AM +0400, Michael Tokarev wrote: > > I don't have bandwidth for non-trivial cosmetic stuff at the > > moment, sorry. > > What's "bandwidth" in this context? Time. My review queue is 120 patches at the moment. I'm tackling those which are blocked on me and which

Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-19 Thread Anthony Liguori
On 03/19/2012 03:04 PM, Michael Tokarev wrote: On 19.03.2012 18:36, Stefan Hajnoczi wrote: On Fri, Mar 16, 2012 at 11:19:03AM -0500, Anthony Liguori wrote: On 03/15/2012 04:00 PM, Michael Tokarev wrote: This patch combines two functions into one, and replaces the implementation with already ex

Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-19 Thread Michael Tokarev
On 19.03.2012 18:36, Stefan Hajnoczi wrote: > On Fri, Mar 16, 2012 at 11:19:03AM -0500, Anthony Liguori wrote: >> On 03/15/2012 04:00 PM, Michael Tokarev wrote: >>> This patch combines two functions into one, and replaces >>> the implementation with already existing iov_memset() from >>> iov.c. >>>

Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-19 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 11:19:03AM -0500, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: > >This patch combines two functions into one, and replaces > >the implementation with already existing iov_memset() from > >iov.c. > > > >The new prototype of qemu_iovec_memset(): > >

Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: This patch combines two functions into one, and replaces the implementation with already existing iov_memset() from iov.c. The new prototype of qemu_iovec_memset(): size_t qemu_iovec_memset(qiov, size_t offset, int fillc, size_t bytes) It is diff

[Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-15 Thread Michael Tokarev
This patch combines two functions into one, and replaces the implementation with already existing iov_memset() from iov.c. The new prototype of qemu_iovec_memset(): size_t qemu_iovec_memset(qiov, size_t offset, int fillc, size_t bytes) It is different from former qemu_iovec_memset_skip(), and I