Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 01:21:34PM +0100, Markus Armbruster wrote: > David Gibson writes: > > > On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > >> David Gibson writes: > >> > >> > The functions for migrating the hash page table on pseries machine type > >> > (htab_save_setu

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread Markus Armbruster
David Gibson writes: > On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: >> David Gibson writes: >> >> > The functions for migrating the hash page table on pseries machine type >> > (htab_save_setup() and htab_load()) can report some errors with an >> > explicit fprintf() befor

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > The functions for migrating the hash page table on pseries machine type > > (htab_save_setup() and htab_load()) can report some errors with an > > explicit fprintf() before returning an appropriate err

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-18 Thread Markus Armbruster
David Gibson writes: > The functions for migrating the hash page table on pseries machine type > (htab_save_setup() and htab_load()) can report some errors with an > explicit fprintf() before returning an appropriate error code. Change these > to use error_report() instead. > > Signed-off-by: Da

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-18 Thread Alexey Kardashevskiy
On 01/19/2016 02:39 PM, David Gibson wrote: The functions for migrating the hash page table on pseries machine type (htab_save_setup() and htab_load()) can report some errors with an explicit fprintf() before returning an appropriate error code. Change these to use error_report() instead. Signe

[Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-18 Thread David Gibson
The functions for migrating the hash page table on pseries machine type (htab_save_setup() and htab_load()) can report some errors with an explicit fprintf() before returning an appropriate error code. Change these to use error_report() instead. Signed-off-by: David Gibson Reviewed-by: Thomas Hu