Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-24 Thread Michael Clark
On Fri, Mar 23, 2018 at 3:20 AM, Peter Maydell wrote: > On 20 March 2018 at 22:25, Michael Clark wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef > 9749a4f135: > > > > Update version for v2.12.0-rc0 release (

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-23 Thread Peter Maydell
On 20 March 2018 at 22:25, Michael Clark wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-22 Thread Eric Blake
On 03/22/2018 02:10 PM, Peter Maydell wrote: [snip lots of good advice] Code review isn't only about "does this behave as the secification requires". It can also catch: * simple logic bugs * places where the code is more complicated than it needs to be * style issues * places where a QE

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 18:26, Michael Clark wrote: > Besides some trivial cleanups (erroneous comments, dead-code), and the cpu > init work we were asked to work on by Peter Maydell, the focus of the > changes are specification conformance. e.g. cases where we were trapping on > CSR accesses when we

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-22 Thread Michael Clark
On Thu, Mar 22, 2018 at 2:56 AM, Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 03/20/2018 07:25 PM, Michael Clark wrote: > > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef > 9749a4f135: > > > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > > > ar

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Michael, On 03/20/2018 07:25 PM, Michael Clark wrote: > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > are available in the git repository at: > > https://github.com/riscv/riscv-qemu.

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-21 Thread Eric Blake
On 03/21/2018 01:27 PM, Michael Clark wrote: for future PULL request, could you please send out all patches again that should be pulled, and not send the cover letter alone? I.e. do a "git format-patch --subject-prefix PULL ..." and then replace the contents of the cover letter with the output o

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-21 Thread Michael Clark
On Wed, Mar 21, 2018 at 12:05 AM, Thomas Huth wrote: > On 20.03.2018 23:25, Michael Clark wrote: > > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef > 9749a4f135: > > > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > > > are available in the git reposi

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-21 Thread Michael Clark
On Wed, Mar 21, 2018 at 4:09 AM, Paolo Bonzini wrote: > On 21/03/2018 08:05, Thomas Huth wrote: > > On 20.03.2018 23:25, Michael Clark wrote: > >> The following changes since commit f1a63fcfcd92c88be8942b5ae71aef > 9749a4f135: > >> > >> Update version for v2.12.0-rc0 release (2018-03-20 19:04:2

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-21 Thread Paolo Bonzini
On 21/03/2018 08:05, Thomas Huth wrote: > On 20.03.2018 23:25, Michael Clark wrote: >> The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: >> >> Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) >> >> are available in the git repository at: >> >> https:

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-21 Thread Laurent Vivier
Le 21/03/2018 à 08:05, Thomas Huth a écrit : > On 20.03.2018 23:25, Michael Clark wrote: >> The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: >> >> Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) >> >> are available in the git repository at: >> >> h

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-21 Thread Thomas Huth
On 20.03.2018 23:25, Michael Clark wrote: > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > are available in the git repository at: > > https://github.com/riscv/riscv-qemu.git tags/riscv-q

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-20 Thread Michael Clark
I had the branch all set up and ready for a PR, including the tag message, but after dropping the riscv_isa_string fix I noticed it was still in the tag blurb for the series. I don't think it is worth re-tagging the PR to add a note that we dropped the change from the series. These are pretty much

[Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-20 Thread Michael Clark
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) are available in the git repository at: https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.12-