Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Eric Blake
On 05/30/2017 01:10 PM, Eduardo Habkost wrote: > On Tue, May 30, 2017 at 10:28:21AM -0500, Eric Blake wrote: >> On 05/30/2017 09:01 AM, Eduardo Habkost wrote: >> The OSX compiler is pickier about format strings than gcc, and neither "MAX_NODES" nor "MAX(anything)" are uint16_t type. >>> >

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 10:28:21AM -0500, Eric Blake wrote: > On 05/30/2017 09:01 AM, Eduardo Habkost wrote: > > >> The OSX compiler is pickier about format strings than gcc, > >> and neither "MAX_NODES" nor "MAX(anything)" are uint16_t type. > > > > src and dst are both uint16_t, so MAX(src, dst

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Daniel P. Berrange
On Tue, May 30, 2017 at 06:08:04PM +0100, Peter Maydell wrote: > On 30 May 2017 at 15:01, Eduardo Habkost wrote: > > On Tue, May 30, 2017 at 11:45:55AM +0100, Peter Maydell wrote: > >> Hi all; I'm afraid this patch breaks compilation on OSX: > > > > It looks like this wasn't detected by travis-ci

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Peter Maydell
On 30 May 2017 at 15:01, Eduardo Habkost wrote: > On Tue, May 30, 2017 at 11:45:55AM +0100, Peter Maydell wrote: >> Hi all; I'm afraid this patch breaks compilation on OSX: > > It looks like this wasn't detected by travis-ci because the build > is not using -Werror: > https://travis-ci.org/ehabkos

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Eric Blake
On 05/30/2017 09:01 AM, Eduardo Habkost wrote: >> The OSX compiler is pickier about format strings than gcc, >> and neither "MAX_NODES" nor "MAX(anything)" are uint16_t type. > > src and dst are both uint16_t, so MAX(src, dst) is also uint16_t, > isn't it? It looks like MAX_NODES is the problem.

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 11:45:55AM +0100, Peter Maydell wrote: > On 11 May 2017 at 20:18, Eduardo Habkost wrote: > > From: He Chen > > > > This patch is going to add SLIT table support in QEMU, and provides > > additional option `dist` for command `-numa` to allow user set vNUMA > > distance by Q

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Peter Maydell
On 11 May 2017 at 20:18, Eduardo Habkost wrote: > From: He Chen > > This patch is going to add SLIT table support in QEMU, and provides > additional option `dist` for command `-numa` to allow user set vNUMA > distance by QEMU command. > Signed-off-by: He Chen > Message-Id: <1493260558-20728-1-g

[Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-11 Thread Eduardo Habkost
From: He Chen This patch is going to add SLIT table support in QEMU, and provides additional option `dist` for command `-numa` to allow user set vNUMA distance by QEMU command. With this patch, when a user wants to create a guest that contains several vNUMA nodes and also wants to set distance a