Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Alexander Graf
On 04.09.2013, at 23:05, Richard Henderson wrote: This lets us change le_mode to end_mode and fold away nearly all of the tests for the current cpu endianness, and removing all of the explicitly generated bswap opcodes. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Benjamin Herrenschmidt
On Thu, 2013-09-05 at 11:08 +0200, Alexander Graf wrote: On 04.09.2013, at 23:05, Richard Henderson wrote: This lets us change le_mode to end_mode and fold away nearly all of the tests for the current cpu endianness, and removing all of the explicitly generated bswap opcodes. Only nit: I

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 13:40, Benjamin Herrenschmidt wrote: On Thu, 2013-09-05 at 11:08 +0200, Alexander Graf wrote: On 04.09.2013, at 23:05, Richard Henderson wrote: This lets us change le_mode to end_mode and fold away nearly all of the tests for the current cpu endianness, and removing all

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Benjamin Herrenschmidt
On Thu, 2013-09-05 at 14:59 +0200, Alexander Graf wrote: The embedded PPCs have simply a per-page E bit in the TLB controlling the endianness of accesses through the translation, the endianness is clean in that case, and the bus doesn't flip around so it's akin to what P7 does but with

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Richard Henderson
On 09/05/2013 04:40 AM, Benjamin Herrenschmidt wrote: Only nit: I find end_mode a very confusing identifier :-) end usually means something else ! Why not endian_mode ? 80 column wrapping. A poor excuse, I know... I haven't seen the patch itself for some reason (and I'm about to go off for