Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-29 Thread Roman Bolshakov
On Thu, Nov 29, 2018 at 12:49:27PM -0500, Emilio G. Cota wrote: > On Thu, Nov 29, 2018 at 12:00:55 -0500, Emilio G. Cota wrote: > > On Thu, Nov 29, 2018 at 12:57:16 +0300, Roman Bolshakov wrote: > > > Hi Emilio, > > > > > > I think there's an issue with "\s" character class, it's not recognized >

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-29 Thread Emilio G. Cota
On Thu, Nov 29, 2018 at 12:00:55 -0500, Emilio G. Cota wrote: > On Thu, Nov 29, 2018 at 12:57:16 +0300, Roman Bolshakov wrote: > > Hi Emilio, > > > > I think there's an issue with "\s" character class, it's not recognized > > by macOS sed and I'm getting incorrect lines in > >

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-29 Thread Emilio G. Cota
On Thu, Nov 29, 2018 at 12:57:16 +0300, Roman Bolshakov wrote: > Hi Emilio, > > I think there's an issue with "\s" character class, it's not recognized > by macOS sed and I'm getting incorrect lines in > qemu-plugins-ld64.symbols: > _ qemu_xxx > _ qemu_xyz > > After I replaced "\s" with

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-29 Thread Roman Bolshakov
On Wed, Nov 28, 2018 at 12:23:32PM -0500, Emilio G. Cota wrote: > On Wed, Nov 28, 2018 at 13:43:30 +0300, Roman Bolshakov wrote: > > qemu-ga fails to link because it doesn't have symbols declared in > > qemu-plugins-ld64.symbols. Perhaps "-Wl,-exported_symbols_list" should > > be applied only to

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-28 Thread Emilio G. Cota
On Wed, Nov 28, 2018 at 13:43:30 +0300, Roman Bolshakov wrote: > The test of -exported_symbols_list fails: > Undefined symbols for architecture x86_64: > "foo", referenced from: >-exported_symbol[s_list] command line option > (maybe you meant: _foo) > > All functions on

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-28 Thread Roman Bolshakov
On Tue, Nov 27, 2018 at 06:13:57PM -0500, Emilio G. Cota wrote: > On Tue, Nov 27, 2018 at 15:43:52 +0300, Roman Bolshakov wrote: > > ld64 on macOS has similar -exported_symbols_list option. Here's the > > reference: > > > > -exported_symbols_list filename > > The specified filename

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-27 Thread Emilio G. Cota
On Tue, Nov 27, 2018 at 15:43:52 +0300, Roman Bolshakov wrote: > ld64 on macOS has similar -exported_symbols_list option. Here's the reference: > > -exported_symbols_list filename > The specified filename contains a list of global symbol names > that will remain as global symbols

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-27 Thread Emilio G. Cota
On Tue, Nov 27, 2018 at 12:11:32 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > For now only add it for ELF platforms, since we rely on the linker's > > --dynamic-list flag to pass a list of symbols to be exported to the > > executable. An alternative would be to use -rdynamic, but

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-27 Thread Roman Bolshakov
On Thu, Oct 25, 2018 at 01:20:50PM -0400, Emilio G. Cota wrote: > For now only add it for ELF platforms, since we rely on the linker's > --dynamic-list flag to pass a list of symbols to be exported to the > executable. An alternative would be to use -rdynamic, but that would > expose all of QEMU's

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-27 Thread Alex Bennée
Emilio G. Cota writes: > For now only add it for ELF platforms, since we rely on the linker's > --dynamic-list flag to pass a list of symbols to be exported to the > executable. An alternative would be to use -rdynamic, but that would > expose all of QEMU's objects to plugins. > > I have no

[Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-10-25 Thread Emilio G. Cota
For now only add it for ELF platforms, since we rely on the linker's --dynamic-list flag to pass a list of symbols to be exported to the executable. An alternative would be to use -rdynamic, but that would expose all of QEMU's objects to plugins. I have no experience with non-ELF systems but I