Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-23 Thread Liviu Ionescu
> On 23 Apr 2015, at 14:55, Leon Alrae wrote: > > have been broken into 3 separate patches: please feel free to reorganise the patches as you think it is more appropriate. to avoid conflicts in my branch I would obviously appreciate keeping the structure as is, and also keeping the cmdline as

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-23 Thread Leon Alrae
On 21/04/2015 19:08, Liviu Ionescu wrote: > >> On 21 Apr 2015, at 16:34, Leon Alrae wrote: >> >> I'll resend the patch with dropped "RFC" as I would really like to go >> forward and finally close this issue. > > perhaps you should first take a closer look at the patch I submitted, since > it co

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Liviu Ionescu
> On 21 Apr 2015, at 16:34, Leon Alrae wrote: > > I'll resend the patch with dropped "RFC" as I would really like to go > forward and finally close this issue. perhaps you should first take a closer look at the patch I submitted, since it covers not only parsing the arguments, but also groupin

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 17:51, Liviu Ionescu wrote: > could you also suggest a solution for a .BAT script when running on windows? I don't do windows, so you're on your own there, I'm afraid, though a little googling suggests windows bat syntax does have sufficient power (eg string-replacement functi

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Liviu Ionescu
> On 21 Apr 2015, at 19:54, Peter Maydell wrote: > > Incidentally if you have a better idea for achieving the > desired goal than this messing around with comma-escaping > I would really like to know. I don't like either of the > current two proposals very much :-( please keep in mind that the

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Eric Blake
On 04/21/2015 10:54 AM, Peter Maydell wrote: > On 21 April 2015 at 17:48, Eric Blake wrote: >> On 04/21/2015 09:55 AM, Peter Maydell wrote: >>> If you want pure POSIX shell then it is slightly >>> uglier as we have to invoke sed: >>> >>> argstr="" >>> for arg in "$@"; do >>> o=$(printf '%s.\n

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 17:48, Eric Blake wrote: > On 04/21/2015 09:55 AM, Peter Maydell wrote: >> If you want pure POSIX shell then it is slightly >> uglier as we have to invoke sed: >> >> argstr="" >> for arg in "$@"; do >> o=$(printf '%s.\n' "$arg" | sed s/,/,,/g) >> argstr=${argstr:+$arg

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Liviu Ionescu
> On 21 Apr 2015, at 19:23, Peter Maydell wrote: > >> do these scripts properly handle args containing spaces or embedded >> apostrophes/quotes? > > Yes. Also arguments containing newlines. super! could you also suggest a solution for a .BAT script when running on windows? in my opinion bot

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Eric Blake
On 04/21/2015 09:55 AM, Peter Maydell wrote: > If you want pure POSIX shell then it is slightly > uglier as we have to invoke sed: > > argstr="" > for arg in "$@"; do > o=$(printf '%s.\n' "$arg" | sed s/,/,,/g) > argstr=${argstr:+$argstr,}arg=${o%.} > done It's possible to use IFS= and

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 17:21, Liviu Ionescu wrote: > >> On 21 Apr 2015, at 18:55, Peter Maydell wrote: >> >> On 21 April 2015 at 16:14, Liviu Ionescu wrote: >>> if you insist on the arg= solution, could you be so kind and >>> provide a bash script wrapper that passes all arguments ($@) >>> using yo

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Liviu Ionescu
> On 21 Apr 2015, at 18:55, Peter Maydell wrote: > > On 21 April 2015 at 16:14, Liviu Ionescu wrote: >> if you insist on the arg= solution, could you be so kind and >> provide a bash script wrapper that passes all arguments ($@) >> using your syntax? > > > ... bashisms ... pure POSIX shell d

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 16:14, Liviu Ionescu wrote: > if you insist on the arg= solution, could you be so kind and > provide a bash script wrapper that passes all arguments ($@) > using your syntax? If you're willing to accept bashisms, then: argstr="" for arg in "$@"; do argstr=${argstr:+$args

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Liviu Ionescu
> On 21 Apr 2015, at 16:34, Leon Alrae wrote: > > (PS: --semihosting-cmdline $@ is probably the most convenient from GUI / > wrapper point of view, but I don't have an opinion whether this is > enough to justify adding a top level QEMU command line option with such > a unique syntax) nope, the

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Leon Alrae
On 16/04/2015 15:22, Peter Maydell wrote: > On 15 April 2015 at 10:09, Liviu Ionescu wrote: >> we currently have two solutions: >> >> - multiple: --semihosting-config arg="..." >> - a single option, placed at the end, and followed by any number >> of arguments: --semihosting-cmdline $@ \n >> >>

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-17 Thread Liviu Ionescu
> On 16 Apr 2015, at 12:27, Leon Alrae wrote: > > ... I believe it would be much easier if you sent the patches first I just did this. > On 16 Apr 2015, at 17:22, Peter Maydell wrote: > it is nothing like > the way QEMU's system-emulator mode handles other command line > arguments. generall

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-16 Thread Peter Maydell
On 15 April 2015 at 10:09, Liviu Ionescu wrote: > we currently have two solutions: > > - multiple: --semihosting-config arg="..." > - a single option, placed at the end, and followed by any number > of arguments: --semihosting-cmdline $@ \n > > both can generate the array of args required by UHI

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-16 Thread Leon Alrae
On 15/04/2015 17:08, Liviu Ionescu wrote: > >> On 15 Apr 2015, at 15:49, Leon Alrae wrote: >> >> ... If there aren't any objections for the proposed solution, then let's >> just cook up the patch. > > the changes related to moving --semihosting-cmdline to the end of the line > are in: > > gi

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-15 Thread Liviu Ionescu
> On 15 Apr 2015, at 15:49, Leon Alrae wrote: > > ... If there aren't any objections for the proposed solution, then let's > just cook up the patch. the changes related to moving --semihosting-cmdline to the end of the line are in: git://git.code.sf.net/p/gnuarmeclipse/qemu gnuarmeclipse-qe

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-15 Thread Leon Alrae
On 15/04/2015 13:06, Liviu Ionescu wrote: > >> On 15 Apr 2015, at 14:53, Leon Alrae wrote: >> >> On 15/04/2015 10:09, Liviu Ionescu wrote: >>> Peter/Leon, >>> >>> I'm planning for my future releases, and, to avoid incompatible versions, I >>> would like to help with the semihosting configuration

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-15 Thread Liviu Ionescu
> On 15 Apr 2015, at 14:53, Leon Alrae wrote: > > On 15/04/2015 10:09, Liviu Ionescu wrote: >> Peter/Leon, >> >> I'm planning for my future releases, and, to avoid incompatible versions, I >> would like to help with the semihosting configuration issue, to speed up >> things. is there any chan

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-15 Thread Matthew Fortune
Leon Alrae writes: > On 15/04/2015 10:09, Liviu Ionescu wrote: > > Peter/Leon, > > > > I'm planning for my future releases, and, to avoid incompatible > versions, I would like to help with the semihosting configuration issue, > to speed up things. is there any chance to close this issue in the nea

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-15 Thread Leon Alrae
On 15/04/2015 10:09, Liviu Ionescu wrote: > Peter/Leon, > > I'm planning for my future releases, and, to avoid incompatible versions, I > would like to help with the semihosting configuration issue, to speed up > things. is there any chance to close this issue in the near future? I'm hoping so

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-15 Thread Liviu Ionescu
Peter/Leon, I'm planning for my future releases, and, to avoid incompatible versions, I would like to help with the semihosting configuration issue, to speed up things. is there any chance to close this issue in the near future? we currently have two solutions: - multiple: --semihosting-config

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-14 Thread Liviu Ionescu
> On 08 Apr 2015, at 19:20, Leon Alrae wrote: > > ... I do understand > however that in your particular case cmdline is more convenient, thus I > personally don’t mind having both options: the user-friendly cmdline and > more flexible arg. I was a bit optimistic with the first implementation of

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-08 Thread Leon Alrae
On 02/04/2015 17:47, Liviu Ionescu wrote: > >> On 02 Apr 2015, at 17:27, Matthew Fortune wrote: >> >> Liviu Ionescu writes: >>> for completeness: >>> >>> ilg-mbp:gnuarmeclipse-qemu.git ilg$ "/Applications/GNU ARM >>> Eclipse/QEMU/2.2.91-20150402-dev/bin/qemu-system-gnuarmeclipse" - >>> verbo

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-04 Thread Liviu Ionescu
> On 01 Apr 2015, at 16:18, Leon Alrae wrote: > > ... I would like to follow up with a clean up > where we've got a semi-hosting specific structure rather than keep generating > more semihosting_* variables. I checked the differences between my fork and the master branch (SourceTree for Mac is

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Liviu Ionescu
> On 02 Apr 2015, at 17:27, Matthew Fortune wrote: > > Liviu Ionescu writes: >> for completeness: >> >> ilg-mbp:gnuarmeclipse-qemu.git ilg$ "/Applications/GNU ARM >> Eclipse/QEMU/2.2.91-20150402-dev/bin/qemu-system-gnuarmeclipse" - >> verbose -machine STM32-H103 -gdb tcp::1234 -semihosting

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Matthew Fortune
Liviu Ionescu writes: > > On 02 Apr 2015, at 13:36, Leon Alrae wrote: > > > >> How would you pass arguments containing whitespaces via > >> -semihosting-config cmdline without having to reinvent shell within > QEMU? > > > > I missed the fact that you already provided the implementation for > > th

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Liviu Ionescu
> On 02 Apr 2015, at 13:36, Leon Alrae wrote: > >> How would you pass arguments containing whitespaces via >> -semihosting-config cmdline without having to reinvent shell within QEMU? > > I missed the fact that you already provided the implementation for this > below... for completeness: ilg

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Leon Alrae
On 02/04/2015 10:14, Leon Alrae wrote: > On 02/04/2015 09:29, Liviu Ionescu wrote: >> >>> On 02 Apr 2015, at 10:56, Leon Alrae wrote: >>> >>> ... The UHI semihosting supports Argn syscall which returns single argument, >>> and Argn is called multiple times to build argv (each argument can >>> cont

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Leon Alrae
On 02/04/2015 09:29, Liviu Ionescu wrote: > >> On 02 Apr 2015, at 10:56, Leon Alrae wrote: >> >> ... The UHI semihosting supports Argn syscall which returns single argument, >> and Argn is called multiple times to build argv (each argument can >> contain whitespaces). > > ok, I don't want to com

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Liviu Ionescu
> On 02 Apr 2015, at 10:56, Leon Alrae wrote: > > ... The UHI semihosting supports Argn syscall which returns single argument, > and Argn is called multiple times to build argv (each argument can > contain whitespaces). ok, I don't want to comment too much on UHI design, since I'm not familiar

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-02 Thread Leon Alrae
On 01/04/2015 16:21, Liviu Ionescu wrote: > >> On 01 Apr 2015, at 16:18, Leon Alrae wrote: >> >> ... This simple patch adds "arg" sub-argument which in my opinion is flexible >> enough to satisfy semi-hosting interfaces which allocate buffers at runtime >> (so it is possible to pass any number of

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Liviu Ionescu
> On 01 Apr 2015, at 18:45, Christopher Covington wrote: > > I think the commit message and help text should include some information on > how this is different from -append and what the result is of specifying both > -append foo=a and -semihosting-config arg=foo=b. if I remember right (did not

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Matthew Fortune
Liviu Ionescu writes: > > On 01 Apr 2015, at 16:18, Leon Alrae wrote: > > > > ... This simple patch adds "arg" sub-argument which in my opinion is > > flexible enough to satisfy semi-hosting interfaces which allocate > > buffers at runtime (so it is possible to pass any number of strings of > > a

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Christopher Covington
Hi Leon, On 04/01/2015 09:18 AM, Leon Alrae wrote: > Signed-off-by: Leon Alrae > --- > Hi, > > Continuing the discussion related to extending QEMU's command line with new > argument allowing to pass semi-hosting input arguments to the guest program: > https://lists.gnu.org/archive/html/qemu-deve

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Liviu Ionescu
> On 01 Apr 2015, at 16:18, Leon Alrae wrote: > > ... This simple patch adds "arg" sub-argument which in my opinion is flexible > enough to satisfy semi-hosting interfaces which allocate buffers at runtime > (so it is possible to pass any number of strings of any length) as well as the > ones wh

[Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Leon Alrae
Signed-off-by: Leon Alrae --- Hi, Continuing the discussion related to extending QEMU's command line with new argument allowing to pass semi-hosting input arguments to the guest program: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05960.html This simple patch adds "arg" sub-argument