Re: [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation

2016-01-19 Thread Shmulik Ladkani
Hi Marcel, On Tue, 19 Jan 2016 16:26:31 +0200, marcel.apfelb...@gmail.com wrote: > > > > +/* DSN */ > > +#define PCI_DSN_VER 1 > > +#define PCI_DSN_SIZEOF 8 > > Are you sure the size of DSN is 8? > Looking at PCIe spec 3, chapter 7.12 I see 12, but I might be

Re: [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation

2016-01-19 Thread Dmitry Fleytman
> On 19 Jan 2016, at 16:26 PM, Marcel Apfelbaum > wrote: > > On 01/18/2016 07:35 PM, Leonid Bloch wrote: >> From: Dmitry Fleytman >> >> Signed-off-by: Dmitry Fleytman >> Signed-off-by: Leonid Bloch >> --- >> hw/pci/pcie.c | 7 +++ >> include/hw/pci/pci_regs.h | 3 +++ >>

Re: [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation

2016-01-19 Thread Marcel Apfelbaum
On 01/18/2016 07:35 PM, Leonid Bloch wrote: From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 7 +++ include/hw/pci/pci_regs.h | 3 +++ include/hw/pci/pcie.h | 1 + include/hw/pci/pcie_regs.h | 4 4 files cha

[Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation

2016-01-18 Thread Leonid Bloch
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 7 +++ include/hw/pci/pci_regs.h | 3 +++ include/hw/pci/pcie.h | 1 + include/hw/pci/pcie_regs.h | 4 4 files changed, 15 insertions(+) diff --git a/hw/pci/pcie.c