Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-07-22 Thread Alex Bennée
I've taken all the suggestions apart from the bellow (comment inline): Sergey Fedorov writes: >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -99,6 +99,26 @@ STEXI >> Select CPU model (@code{-cpu help} for list and additional feature >> selection) >> ETEXI >>

Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-07-04 Thread Paolo Bonzini
On 02/07/2016 09:38, Sergey Fedorov wrote: >>> +bool qemu_tcg_mttcg_enabled(void) >>> +{ >>> +return mttcg_enabled; >>> +} >>> >> Is there a good reason to expose this via function call, rather than >>> >> just test >>> >> the variable? >> > It was in Fred's original

Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-07-02 Thread Sergey Fedorov
On 02/07/16 10:11, Alex Bennée wrote: > Richard Henderson writes: > >> On 06/03/2016 01:40 PM, Alex Bennée wrote: >>> +bool qemu_tcg_mttcg_enabled(void) >>> +{ >>> +return mttcg_enabled; >>> +} >> Is there a good reason to expose this via function call, rather than just >>

Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-07-02 Thread Alex Bennée
Richard Henderson writes: > On 06/03/2016 01:40 PM, Alex Bennée wrote: >> +bool qemu_tcg_mttcg_enabled(void) >> +{ >> +return mttcg_enabled; >> +} > > Is there a good reason to expose this via function call, rather than just test > the variable? It was in Fred's original

Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-07-01 Thread Richard Henderson
On 06/03/2016 01:40 PM, Alex Bennée wrote: +bool qemu_tcg_mttcg_enabled(void) +{ +return mttcg_enabled; +} Is there a good reason to expose this via function call, rather than just test the variable? r~

Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-06-27 Thread Sergey Fedorov
On 03/06/16 23:40, Alex Bennée wrote: > diff --git a/cpus.c b/cpus.c > index 4cc2ce6..1694ce9 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -25,6 +25,7 @@ > /* Needed early for CONFIG_BSD etc. */ > #include "qemu/osdep.h" > #include "qemu-common.h" > +#include "qemu/config-file.h" > #include

[Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-06-03 Thread Alex Bennée
From: KONRAD Frederic We know there will be cases where MTTCG won't work until additional work is done in the front/back ends to support. It will however be useful to be able to turn it on. As a result MTTCG will default to off unless the combination is supported.