Re: [Qemu-devel] [RISC-V] Coverity 1390849, Logically dead code

2018-05-25 Thread Peter Maydell
On 25 May 2018 at 07:18, Michael Clark wrote: > On Fri, May 25, 2018 at 9:54 AM, Richard Henderson wrote: > >> In the latest Coverity scan, it reports >> I believe the condition at op_helper.c:409 should be testing >> CSR_MHPMCOUNTER3H >> and CSR_MHPMCOUNTER31H. Must run now, otherwise I'd also

Re: [Qemu-devel] [RISC-V] Coverity 1390849, Logically dead code

2018-05-24 Thread Michael Clark
On Fri, May 25, 2018 at 9:54 AM, Richard Henderson wrote: > In the latest Coverity scan, it reports > > 405if (csrno >= CSR_MHPMCOUNTER3 && csrno <= CSR_MHPMCOUNTER31) { > 406return 0; > 407} > 408#if defined(TARGET_RISCV32) > 409if (csrno >= CSR_MHPMCOUNTER3 && csrno <= CSR_M

[Qemu-devel] [RISC-V] Coverity 1390849, Logically dead code

2018-05-24 Thread Richard Henderson
In the latest Coverity scan, it reports 405if (csrno >= CSR_MHPMCOUNTER3 && csrno <= CSR_MHPMCOUNTER31) { 406return 0; 407} 408#if defined(TARGET_RISCV32) 409if (csrno >= CSR_MHPMCOUNTER3 && csrno <= CSR_MHPMCOUNTER31) { CID 1390849 (#1 of 1): Logically dead code (DEAD