Re: [Qemu-devel] [RISU v2] i386: Add avx512 state to reginfo_t

2019-04-12 Thread Richard Henderson
On 4/11/19 4:05 PM, Jan Bobek wrote: > Looks fine to me. I suppose if I had written it, I would have included > more comments and/or #define's to make some bits more obvious (all the > magic constants look a bit scary until you read the Intel manual), but > nevermind that. You're right that it

Re: [Qemu-devel] [RISU v2] i386: Add avx512 state to reginfo_t

2019-04-11 Thread Jan Bobek
Looks fine to me. I suppose if I had written it, I would have included more comments and/or #define's to make some bits more obvious (all the magic constants look a bit scary until you read the Intel manual), but nevermind that. I guess the other remaining part now is extending risugen to

[Qemu-devel] [RISU v2] i386: Add avx512 state to reginfo_t

2019-04-09 Thread Richard Henderson
The state expected for a given test must be specifically requested with the --xfeatures=mask command-line argument. This is recorded with the saved state so that it is obvious if the apprentice is given a different argument. Any features beyond what are present on the running cpu will read as