Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-05 Thread Paolo Bonzini
Il 06/06/2014 05:06, Zhang, Yang Z ha scritto: Paolo Bonzini wrote on 2014-06-03: Il 30/05/2014 10:59, Tiejun Chen ha scritto: +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) +{ +struct PCIDevice *dev; + +char rid; + +dev = pci_create(bus, PCI_DEVFN(0x1f, 0),

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-05 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2014-06-03: > Il 30/05/2014 10:59, Tiejun Chen ha scritto: >> +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) >> +{ >> +struct PCIDevice *dev; >> + >> +char rid; >> + >> +dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "intel-pch-isa-bridge"); >

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Tian, Kevin
> From: Paolo Bonzini > Sent: Tuesday, June 03, 2014 4:40 AM > > Il 03/06/2014 13:29, Stefano Stabellini ha scritto: > >> It's really not your fault, there's not much you can do given the hardware > >> architecture. But I don't think this code can be accepted upstream, sorry. > > > > Yeah, the co

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2014, Paolo Bonzini wrote: > Il 03/06/2014 13:29, Stefano Stabellini ha scritto: > > > It's really not your fault, there's not much you can do given the hardware > > > architecture. But I don't think this code can be accepted upstream, > > > sorry. > > > > Yeah, the code is not nice

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread George Dunlap
On 06/03/2014 12:29 PM, Stefano Stabellini wrote: On Tue, 3 Jun 2014, Paolo Bonzini wrote: Il 30/05/2014 10:59, Tiejun Chen ha scritto: +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) +{ +struct PCIDevice *dev; + +char rid; + +dev = pci_create(bus, PCI_DEVFN(0

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Paolo Bonzini
Il 03/06/2014 13:29, Stefano Stabellini ha scritto: It's really not your fault, there's not much you can do given the hardware architecture. But I don't think this code can be accepted upstream, sorry. Yeah, the code is not nice and it is not Tiejun's fault. Is there any way at all he could c

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2014, Paolo Bonzini wrote: > Il 30/05/2014 10:59, Tiejun Chen ha scritto: > > +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) > > +{ > > +struct PCIDevice *dev; > > + > > +char rid; > > + > > +dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "intel-pch-isa-

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Paolo Bonzini
Il 30/05/2014 10:59, Tiejun Chen ha scritto: +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) +{ +struct PCIDevice *dev; + +char rid; + +dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "intel-pch-isa-bridge"); This is really a huge hack. You're going to have two ISA

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-02 Thread Stefano Stabellini
On Fri, 30 May 2014, Tiejun Chen wrote: > ISA bridge is needed since Intel gfx drive will probe it instead > of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that > only need to expose ISA bridge to let driver know the real hardware > underneath. > > The original patch is from

[Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-05-30 Thread Tiejun Chen
ISA bridge is needed since Intel gfx drive will probe it instead of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that only need to expose ISA bridge to let driver know the real hardware underneath. The original patch is from Allen Kay [allen.m@intel.com] Signed-off-by: Ya