Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-10 Thread Alberto Garcia
On Wed, Oct 10, 2012 at 01:35:06PM +0200, Avi Kivity wrote: > > Hey, I finally found some time to look into this, the problem that > > I see is that the PCI carrier doesn't just map each space into its > > local address spaces, in addition to that: > > > > 1) it changes the data and addresses a

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-10 Thread Avi Kivity
On 10/10/2012 12:24 PM, Alberto Garcia wrote: > On Sun, Oct 07, 2012 at 12:13:53PM +0200, Avi Kivity wrote: > >> Luckily the low-order bits are used for offsets, and the high-order >> bits are used for selecting the sub-device. >> >> So you could easily have >> >> struct IPackDevice { >> D

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-10 Thread Alberto Garcia
On Sun, Oct 07, 2012 at 12:13:53PM +0200, Avi Kivity wrote: > Luckily the low-order bits are used for offsets, and the high-order > bits are used for selecting the sub-device. > > So you could easily have > > struct IPackDevice { > DeviceState qdev; > int32_t slot; > /* IRQ objec

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-08 Thread Alberto Garcia
On Sun, Oct 07, 2012 at 12:19:07PM +0200, Avi Kivity wrote: > > So you could easily have > > > > struct IPackDevice { > > DeviceState qdev; > > int32_t slot; > > /* IRQ objects for the IndustryPack INT0# and INT1# */ > > qemu_irq *irq; > > MemoryRegion io_space; > >

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-07 Thread Avi Kivity
On 10/07/2012 12:13 PM, Avi Kivity wrote: > On 10/05/2012 06:24 PM, Blue Swirl wrote: >> >> I'd suppose addressing devices in the bus could be implemented more >> efficiently with better use of memory API, now some of it is >> reimplemented. Maybe Avi can propose something? > > Luckily the low-or

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-07 Thread Avi Kivity
On 10/05/2012 06:24 PM, Blue Swirl wrote: > > I'd suppose addressing devices in the bus could be implemented more > efficiently with better use of memory API, now some of it is > reimplemented. Maybe Avi can propose something? Luckily the low-order bits are used for offsets, and the high-order bi

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-06 Thread Alberto Garcia
On Fri, Oct 05, 2012 at 04:24:08PM +, Blue Swirl wrote: > Endianness looks buggy, there's no way to turn off big endian mode I double checked the documentation and I think you're right, I can update the patch. Thanks for pointing it out. > DEVICE_NATIVE_ENDIAN should probably be DEVICE_LITTL

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 2:28 PM, Paolo Bonzini wrote: > Il 05/10/2012 15:20, Alberto Garcia ha scritto: >> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: >> Ping >>> >>> We are currently in Hard Freeze, new devices will not get accepted >>> before the release, and our review m

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Andreas Färber
Am 05.10.2012 15:20, schrieb Alberto Garcia: > On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > >>> Ping >> >> We are currently in Hard Freeze, new devices will not get accepted >> before the release, and our review may focus on bug fixes. >> >> http://wiki.qemu.org/Planning/1.2 >

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/10/2012 15:20, Alberto Garcia ha scritto: >> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: >> Ping >>> >>> We are currently in Hard Freeze, new devices will not get accepted >>> before the release, and our review may focus on bug fixes. >>> >>

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 15:20, Alberto Garcia ha scritto: > On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > >>> Ping >> >> We are currently in Hard Freeze, new devices will not get accepted >> before the release, and our review may focus on bug fixes. >> >> http://wiki.qemu.org/Planning/1.

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Alberto Garcia
On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > > Ping > > We are currently in Hard Freeze, new devices will not get accepted > before the release, and our review may focus on bug fixes. > > http://wiki.qemu.org/Planning/1.2 > > I remember having had a brief look through your

[Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-09-10 Thread Alberto Garcia
On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > We are currently in Hard Freeze, new devices will not get accepted > before the release, and our review may focus on bug fixes. QEMU 1.2 has been released, so here's the new ping. Patches here: http://patchwork.ozlabs.org/patch/1

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-08-31 Thread Andreas Färber
Hi, Am 31.08.2012 16:12, schrieb Alberto Garcia: > Ping We are currently in Hard Freeze, new devices will not get accepted before the release, and our review may focus on bug fixes. http://wiki.qemu.org/Planning/1.2 I remember having had a brief look through your patches and they looked pretty

[Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-08-31 Thread Alberto Garcia
Ping Patches here: http://patchwork.ozlabs.org/patch/179657/ http://patchwork.ozlabs.org/patch/179658/ Description: https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04173.html Berto