[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-16 Thread Paolo Bonzini
On 12/15/2010 08:04 PM, Michael S. Tsirkin wrote: This assuming upstream developers do not care about downstreams. To give a chance for downstream to cherry-pick changes, upstream should use subsections instead of version ids too. Then version ids should be deprecated altogether. Nothing again

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-15 Thread Michael S. Tsirkin
On Wed, Dec 15, 2010 at 06:12:25PM +0100, Paolo Bonzini wrote: > On 12/15/2010 11:00 AM, Michael S. Tsirkin wrote: > >>Indeed, subsections are for data that is rarely needed so that > >>there's some chance (sometimes ~100%) of migration working > >>seemlessly. > > > >If a subsection arrives that qe

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-15 Thread Paolo Bonzini
On 12/15/2010 11:00 AM, Michael S. Tsirkin wrote: Indeed, subsections are for data that is rarely needed so that there's some chance (sometimes ~100%) of migration working seemlessly. If a subsection arrives that qemu does not know about, won't migratin fail? Yes, that's why rarely needed =>

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-15 Thread Alex Williamson
On Wed, 2010-12-15 at 12:07 +0200, Michael S. Tsirkin wrote: > On Tue, Dec 14, 2010 at 08:41:55AM -0700, Alex Williamson wrote: > > On Tue, 2010-12-14 at 14:32 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 10:00:48PM -0700, Alex Williamson wrote: > > > > On Tue, 2010-12-14 at 06:43

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-15 Thread Michael S. Tsirkin
On Tue, Dec 14, 2010 at 04:59:55PM +0100, Paolo Bonzini wrote: > On 12/14/2010 04:41 PM, Alex Williamson wrote: > >> Maybe in this particular case the advantage is minimal. > >> But it seems easier to stick to a rule of no more version > >> bumps than argue about each case. > > > >Do we have suc

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-15 Thread Michael S. Tsirkin
On Tue, Dec 14, 2010 at 08:41:55AM -0700, Alex Williamson wrote: > On Tue, 2010-12-14 at 14:32 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 10:00:48PM -0700, Alex Williamson wrote: > > > On Tue, 2010-12-14 at 06:43 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2010 at 12:

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-14 Thread Paolo Bonzini
On 12/14/2010 04:41 PM, Alex Williamson wrote: > Maybe in this particular case the advantage is minimal. > But it seems easier to stick to a rule of no more version > bumps than argue about each case. Do we have such a rule? If we have a subsection who's needed function is return 1, I think

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-14 Thread Alex Williamson
On Tue, 2010-12-14 at 14:32 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 10:00:48PM -0700, Alex Williamson wrote: > > On Tue, 2010-12-14 at 06:43 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 12:15:08PM -0700, Alex Williamson wrote: > > > > On Mon, 2010-12-13 at 21:06

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-14 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 10:00:48PM -0700, Alex Williamson wrote: > On Tue, 2010-12-14 at 06:43 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 12:15:08PM -0700, Alex Williamson wrote: > > > On Mon, 2010-12-13 at 21:06 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2010 at 11:

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Alex Williamson
On Tue, 2010-12-14 at 06:43 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 12:15:08PM -0700, Alex Williamson wrote: > > On Mon, 2010-12-13 at 21:06 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 11:59:16AM -0700, Alex Williamson wrote: > > > > On Mon, 2010-12-13 at 20:54

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 12:15:08PM -0700, Alex Williamson wrote: > On Mon, 2010-12-13 at 21:06 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 11:59:16AM -0700, Alex Williamson wrote: > > > On Mon, 2010-12-13 at 20:54 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2010 at 11:

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Alex Williamson
On Mon, 2010-12-13 at 21:06 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 11:59:16AM -0700, Alex Williamson wrote: > > On Mon, 2010-12-13 at 20:54 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 11:00:44AM -0700, Alex Williamson wrote: > > > > On Mon, 2010-12-13 at 19:50

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 11:59:16AM -0700, Alex Williamson wrote: > On Mon, 2010-12-13 at 20:54 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 11:00:44AM -0700, Alex Williamson wrote: > > > On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2010 at 10:

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Alex Williamson
On Mon, 2010-12-13 at 20:54 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 11:00:44AM -0700, Alex Williamson wrote: > > On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote: > > > > So, unfortunately, I stand

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 11:00:44AM -0700, Alex Williamson wrote: > On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote: > > > So, unfortunately, I stand by my original patch. > > > > What about the one that put -1 in save

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Alex Williamson
On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote: > > So, unfortunately, I stand by my original patch. > > What about the one that put -1 in saved index for a hotplugged device? There are still examples that don't work

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote: > So, unfortunately, I stand by my original patch. What about the one that put -1 in saved index for a hotplugged device? -- MST

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-13 Thread Alex Williamson
On Mon, 2010-12-13 at 02:55 +0530, Juan Quintela wrote: > Alex Williamson wrote: > > On Sun, 2010-12-12 at 20:07 +0530, Juan Quintela wrote: > >> "Michael S. Tsirkin" wrote: > >> > On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote: > >> >> "Michael S. Tsirkin" wrote: > >> >> > On Thu

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Juan Quintela
Alex Williamson wrote: > On Sun, 2010-12-12 at 20:07 +0530, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote: >> >> "Michael S. Tsirkin" wrote: >> >> > On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote: >> >> >>

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Michael S. Tsirkin
On Sun, Dec 12, 2010 at 09:29:05AM -0700, Alex Williamson wrote: > On Sun, 2010-12-12 at 20:07 +0530, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote: > > >> "Michael S. Tsirkin" wrote: > > >> > On Thu, Dec 09, 2010 at 03:14

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Alex Williamson
On Sun, 2010-12-12 at 20:07 +0530, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote: > >> "Michael S. Tsirkin" wrote: > >> > On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote: > > >> > How about we keep migrating t

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote: >> > How about we keep migrating the index for the benefit of >> > old versions, but ignore the value

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Michael S. Tsirkin
On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote: > >> On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote: > >> > Alex Williamson wrote: > >> > > The cpu_register_io_memory() value

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote: >> On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote: >> > Alex Williamson wrote: >> > > The cpu_register_io_memory() value is unique to the VM instance and >> > > should not be restored after migr

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-12 Thread Michael S. Tsirkin
On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote: > On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote: > > Alex Williamson wrote: > > > The cpu_register_io_memory() value is unique to the VM instance and > > > should not be restored after migration/save. Doing so means we > >

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Juan Quintela
Alex Williamson wrote: > The cpu_register_io_memory() value is unique to the VM instance and > should not be restored after migration/save. Doing so means we > could be pointing at arbitrary device's io regions after migration/restore. > > In this case, if we start a VM with a single rtl8139, hot

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Alex Williamson
On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote: > Alex Williamson wrote: > > The cpu_register_io_memory() value is unique to the VM instance and > > should not be restored after migration/save. Doing so means we > > could be pointing at arbitrary device's io regions after migration/restor