[Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-20 Thread Blue Swirl
Thanks, applied. On Fri, Oct 8, 2010 at 8:32 AM, Stefan Weil wrote: > When qemu is configured with --enable-debug-tcg, > gcc throws this warning (or error with -Werror): > > tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true > > Fix it by removing the >= 0 part. > The ty

Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 7:22 PM, Hollis Blanchard wrote: > On Wed, Oct 13, 2010 at 11:58 AM, Stefan Weil wrote: >> >> Hollis, do you still see problems with my patch? >> Or can it be committed? > > I have no objection; I was just anticipating Blue's objection when I > commented previously. It's j

Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-13 Thread Hollis Blanchard
On Wed, Oct 13, 2010 at 11:58 AM, Stefan Weil wrote: > > Hollis, do you still see problems with my patch? > Or can it be committed? I have no objection; I was just anticipating Blue's objection when I commented previously. It's just a style question really... -Hollis

Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-13 Thread Stefan Weil
Am 08.10.2010 23:43, schrieb Stefan Weil: Am 08.10.2010 18:57, schrieb Hollis Blanchard: On Fri, Oct 8, 2010 at 1:32 AM, Stefan Weil wrote: When qemu is configured with --enable-debug-tcg, gcc throws this warning (or error with -Werror): tcg/tcg.c:1030: error: comparison of unsigned expressio

[Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-08 Thread Stefan Weil
Am 08.10.2010 18:57, schrieb Hollis Blanchard: On Fri, Oct 8, 2010 at 1:32 AM, Stefan Weil wrote: When qemu is configured with --enable-debug-tcg, gcc throws this warning (or error with -Werror): tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true Fix it by removing

[Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-08 Thread Hollis Blanchard
On Fri, Oct 8, 2010 at 1:32 AM, Stefan Weil wrote: > When qemu is configured with --enable-debug-tcg, > gcc throws this warning (or error with -Werror): > > tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true > > Fix it by removing the >= 0 part. > The type cast to 'unsign