[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-23 Thread Stefano Stabellini
On Mon, 23 Aug 2010, Juan Quintela wrote: > > +register_savevm(NULL, "gpe", 0, 1, gpe_save, gpe_load, s); > > Please port this to VMSTATE. > > If possible (i.e. not problems with backwards compatibility), something like: > > > +for ( i = 0; i < ACPI_GPE0_BLK_LEN / 2; i++ ) { > > +

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-23 Thread Juan Quintela
stefano.stabell...@eu.citrix.com wrote: > From: Anthony PERARD > > Xen currently uses a different BIOS (hvmloader + rombios) therefore the > Qemu acpi_piix4 implementation wouldn't work correctly with Xen. > We plan on fixing this properly but at the moment we are just adding a > new Xen specific

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-16 Thread Stefano Stabellini
On Fri, 13 Aug 2010, Anthony Liguori wrote: > On 08/13/2010 02:37 PM, Stefano Stabellini wrote: > > On Fri, 13 Aug 2010, Anthony Liguori wrote: > > > >> On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: > >> > >>> From: Anthony PERARD > >>> > >>> Xen currently uses a differe

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Anthony Liguori
On 08/13/2010 02:37 PM, Stefano Stabellini wrote: On Fri, 13 Aug 2010, Anthony Liguori wrote: On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Xen currently uses a different BIOS (hvmloader + rombios) therefore the Qemu acpi_piix4 implementation wo

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Stefano Stabellini
On Fri, 13 Aug 2010, Anthony Liguori wrote: > On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: > > From: Anthony PERARD > > > > Xen currently uses a different BIOS (hvmloader + rombios) therefore the > > Qemu acpi_piix4 implementation wouldn't work correctly with Xen. > > We plan on

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Xen currently uses a different BIOS (hvmloader + rombios) therefore the Qemu acpi_piix4 implementation wouldn't work correctly with Xen. We plan on fixing this properly but at the moment we are just adding a new