Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-19 Thread Michael S. Tsirkin
On Sun, Sep 19, 2010 at 01:11:21PM +0900, Isaku Yamahata wrote: > On Wed, Sep 15, 2010 at 03:05:13PM +0200, Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2010 at 02:50:01PM +0900, Isaku Yamahata wrote: > > > On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > > > > + > > > > > +

Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-18 Thread Isaku Yamahata
On Wed, Sep 15, 2010 at 03:05:13PM +0200, Michael S. Tsirkin wrote: > On Wed, Sep 15, 2010 at 02:50:01PM +0900, Isaku Yamahata wrote: > > On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > > > + > > > > +static void pcie_notify(PCIDevice *dev, uint16_t vector, > > > > +

Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2010 at 02:50:01PM +0900, Isaku Yamahata wrote: > On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > > + > > > +static void pcie_notify(PCIDevice *dev, uint16_t vector, > > > +bool trigger, int level) > > > +{ > > > +/* masking/maskin

Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-14 Thread Isaku Yamahata
On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > + > > +static void pcie_notify(PCIDevice *dev, uint16_t vector, > > +bool trigger, int level) > > +{ > > +/* masking/masking interrupt is handled by upper layer. > > + * i.e. msix_notify() for MS

[Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-14 Thread Michael S. Tsirkin
On Tue, Sep 14, 2010 at 07:29:15PM +0900, Isaku Yamahata wrote: > On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > > +/* > > > + * RW1C: Write-1-to-clear > > > + * regiger written valresult > > > + * 00 => 0 > > > + * 10

[Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-14 Thread Isaku Yamahata
On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > +/* > > + * RW1C: Write-1-to-clear > > + * regiger written valresult > > + * 00 => 0 > > + * 10 => 1 > > + * 01 => 0 > > + * 1

[Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-12 Thread Michael S. Tsirkin
On Wed, Sep 08, 2010 at 04:39:35PM +0900, Isaku Yamahata wrote: > +#define PCI_EXP_SLTCTL_AIC_SHIFT6 > +#define PCI_EXP_SLTCTL_AIC_ON (PCI_EXP_HP_IND_ON << > PCI_EXP_SLTCTL_AIC_SHIFT) > +#define PCI_EXP_SLTCTL_AIC_BLINK(PCI_EXP_HP_IND_BLINK << > PCI_EXP_SLTCTL_AIC_SHIFT)

Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie extended capability.

2010-09-12 Thread Blue Swirl
On Wed, Sep 8, 2010 at 5:38 PM, Wei Xu wrote: > Isaku: > > For binary constants below, to achieve max compatibility with gcc versions, > I recommend to change to hex (0x...): Yes, binary constants were only added to GCC 4.3.x. Since they are also GCC extensions with no obvious way to circumvent t