Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-27 Thread Kevin Wolf
Am 27.10.2009 15:04, schrieb Anthony Liguori: > Amit Shah wrote: >> On (Tue) Oct 27 2009 [09:40:27], Kevin Wolf wrote: >> All that said, I'm ok with reverting that patch now till I find some kind of a solution to this. >>> Which patch do you want to revert? You're aware tha

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-27 Thread Amit Shah
On (Tue) Oct 27 2009 [09:04:50], Anthony Liguori wrote: > Amit Shah wrote: >> On (Tue) Oct 27 2009 [09:40:27], Kevin Wolf wrote: >> All that said, I'm ok with reverting that patch now till I find some kind of a solution to this. >>> Which patch do you want to revert? You're

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-27 Thread Anthony Liguori
Amit Shah wrote: On (Tue) Oct 27 2009 [09:40:27], Kevin Wolf wrote: All that said, I'm ok with reverting that patch now till I find some kind of a solution to this. Which patch do you want to revert? You're aware that the qcow2 patch is a data corruption fix? Ah, no. Reverting

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-27 Thread Amit Shah
On (Tue) Oct 27 2009 [09:40:27], Kevin Wolf wrote: > > > > All that said, I'm ok with reverting that patch now till I find some > > kind of a solution to this. > > Which patch do you want to revert? You're aware that the qcow2 patch is > a data corruption fix? Ah, no. Reverting my patch that cau

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-27 Thread Kevin Wolf
Am 27.10.2009 08:46, schrieb Amit Shah: > On (Mon) Oct 26 2009 [21:15:57], Jan Kiszka wrote: > However, with the qcow2 synchronous patch, the monitor prompt doesn't > come up again -- which shows there is a problem with the way the bhs > work and also the initial resets. Then the q

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-27 Thread Amit Shah
On (Mon) Oct 26 2009 [21:15:57], Jan Kiszka wrote: > >>> However, with the qcow2 synchronous patch, the monitor prompt doesn't > >>> come up again -- which shows there is a problem with the way the bhs > >>> work and also the initial resets. > >> Then the qcow2 patch is already in? At least applyin

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-26 Thread Jan Kiszka
Amit Shah wrote: > On (Mon) Oct 26 2009 [08:40:12], Jan Kiszka wrote: >> Amit Shah wrote: >>> On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote: Amit Shah wrote: > The OPENED event gets sent also when qemu resets its state initially. > The consumers of the event aren't interested in re

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-26 Thread Amit Shah
On (Mon) Oct 26 2009 [08:40:12], Jan Kiszka wrote: > Amit Shah wrote: > > On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote: > >> Amit Shah wrote: > >>> The OPENED event gets sent also when qemu resets its state initially. > >>> The consumers of the event aren't interested in receiving this event >

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-26 Thread Jan Kiszka
Amit Shah wrote: > On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote: >> Amit Shah wrote: >>> The OPENED event gets sent also when qemu resets its state initially. >>> The consumers of the event aren't interested in receiving this event >>> on reset. >> The monitor was. Now its initial prompt on ac

Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-25 Thread Amit Shah
On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote: > Amit Shah wrote: > > The OPENED event gets sent also when qemu resets its state initially. > > The consumers of the event aren't interested in receiving this event > > on reset. > > The monitor was. Now its initial prompt on activation is broken

[Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

2009-10-24 Thread Jan Kiszka
Amit Shah wrote: > The OPENED event gets sent also when qemu resets its state initially. > The consumers of the event aren't interested in receiving this event > on reset. The monitor was. Now its initial prompt on activation is broken. Does this patch fix/improve something for a different user?