Frank Mehnert wrote:
Hi,
the xmit fifo of the serial device is never used. If qemu_chr_write()
fails (interface currently not able to send characters) then the
transmit_timer should be engaged to try to send the current character
from the fifo again after some time. The code is
}
On Wednesday 26 May 2010, Jan Kiszka wrote:
Frank Mehnert wrote:
I assume the correct condition would be '= 0', that is
...
if ((s-tsr_retry = 0) (s-tsr_retry = MAX_XMIT_RETRY)) {
s-tsr_retry++;
...
Makes sense, patch welcome.
Attached.
Kind
Frank Mehnert wrote:
On Wednesday 26 May 2010, Jan Kiszka wrote:
Frank Mehnert wrote:
I assume the correct condition would be '= 0', that is
...
if ((s-tsr_retry = 0) (s-tsr_retry = MAX_XMIT_RETRY)) {
s-tsr_retry++;
...
Makes sense, patch welcome.
On Wed, 26 May 2010, Jan Kiszka wrote:
Frank Mehnert wrote:
On Wednesday 26 May 2010, Jan Kiszka wrote:
Frank Mehnert wrote:
I assume the correct condition would be '= 0', that is
...
if ((s-tsr_retry = 0) (s-tsr_retry = MAX_XMIT_RETRY)) {
s-tsr_retry++;
On Wednesday 26 May 2010, Stefano Stabellini wrote:
I think the patch is correct.
serial: fixed bug which prevented the use of the xmit fifo
Signed-off-by: Frank Mehnert frank.mehn...@sun.com
---
hw/serial.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/serial.c
