Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-12-02 Thread Stefan Hajnoczi
On Wed, Nov 30, 2016 at 03:48:01PM -0500, John Snow wrote: > On 11/30/2016 07:03 AM, Laszlo Ersek wrote: > > On 11/30/16 11:55, Gerd Hoffmann wrote: > >> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: > >>> Recent git releases support the diff.orderFile permanent setting. > >> > >> Cool. >

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-12-02 Thread Laszlo Ersek
On 11/30/16 13:27, Fam Zheng wrote: > On Wed, 11/30 13:03, Laszlo Ersek wrote: >> On 11/30/16 11:55, Gerd Hoffmann wrote: >>> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: Recent git releases support the diff.orderFile permanent setting. >>> >>> Cool. >>> configure

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Laszlo Ersek
On 11/30/16 21:48, John Snow wrote: > > > On 11/30/2016 07:03 AM, Laszlo Ersek wrote: >> On 11/30/16 11:55, Gerd Hoffmann wrote: >>> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: Recent git releases support the diff.orderFile permanent setting. >>> >>> Cool. >>> configure

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread John Snow
On 11/30/2016 07:03 AM, Laszlo Ersek wrote: > On 11/30/16 11:55, Gerd Hoffmann wrote: >> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: >>> Recent git releases support the diff.orderFile permanent setting. >> >> Cool. >> >>> configure >>> *Makefile* >>> *.json >>> *.txt >>> *.h >>> *.c >>

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Laszlo Ersek
On 11/30/16 16:41, Eric Blake wrote: > On 11/30/2016 04:08 AM, Laszlo Ersek wrote: >> Recent git releases support the diff.orderFile permanent setting. (In >> older releases, the -O option had to be specified on the command line, >> or in aliases, for the same effect, which was quite

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2016 at 04:26:14PM +0100, Laszlo Ersek wrote: > On 11/30/16 16:08, Michael S. Tsirkin wrote: > > On Wed, Nov 30, 2016 at 11:08:27AM +0100, Laszlo Ersek wrote: > >> Recent git releases support the diff.orderFile permanent setting. (In > >> older releases, the -O option had to be

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Eric Blake
On 11/30/2016 04:08 AM, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From > git-diff(1): > >-O >

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Stefan Hajnoczi
On Wed, Nov 30, 2016 at 10:08 AM, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From >

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Laszlo Ersek
On 11/30/16 13:29, Gerd Hoffmann wrote: > Hi, > >>> Want sent a patch? >> >> What file for? :) > > create something like scripts/git.orderfile, so people have just to run > "git config diff.orderfile scripts/git.orderfile" to enable it, and we > can refine the config without having everybody

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Laszlo Ersek
On 11/30/16 16:08, Michael S. Tsirkin wrote: > On Wed, Nov 30, 2016 at 11:08:27AM +0100, Laszlo Ersek wrote: >> Recent git releases support the diff.orderFile permanent setting. (In >> older releases, the -O option had to be specified on the command line, >> or in aliases, for the same effect,

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2016 at 11:08:27AM +0100, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From > git-diff(1): >

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Gerd Hoffmann
Hi, > > Want sent a patch? > > What file for? :) create something like scripts/git.orderfile, so people have just to run "git config diff.orderfile scripts/git.orderfile" to enable it, and we can refine the config without having everybody update the orderfile manually? > I've considered

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Fam Zheng
On Wed, 11/30 13:03, Laszlo Ersek wrote: > On 11/30/16 11:55, Gerd Hoffmann wrote: > > On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: > >> Recent git releases support the diff.orderFile permanent setting. > > > > Cool. > > > >> configure > >> *Makefile* > >> *.json > >> *.txt > >> *.h >

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Laszlo Ersek
On 11/30/16 11:55, Gerd Hoffmann wrote: > On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: >> Recent git releases support the diff.orderFile permanent setting. > > Cool. > >> configure >> *Makefile* >> *.json >> *.txt >> *.h >> *.c > > I'd put *.txt to the head so doc updates come first.

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Gerd Hoffmann
On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. Cool. > configure > *Makefile* > *.json > *.txt > *.h > *.c I'd put *.txt to the head so doc updates come first. Otherwise the order looks good to me. Want sent a patch?

[Qemu-devel] a suggestion to place *.c hunks last in patches

2016-11-30 Thread Laszlo Ersek
Recent git releases support the diff.orderFile permanent setting. (In older releases, the -O option had to be specified on the command line, or in aliases, for the same effect, which was quite inconvenient.) From git-diff(1): -O Output the patch in the order specified in the ,