Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-10 Thread Yuri Benditovich
On Tue, Nov 10, 2020 at 4:23 AM Jason Wang wrote: > > On 2020/11/9 下午9:33, Yuri Benditovich wrote: > > > > > > On Mon, Nov 9, 2020 at 4:14 AM Jason Wang > > wrote: > > > > > > On 2020/11/5 下午11:13, Yuri Benditovich wrote: > > > First of all, thank you for all

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-09 Thread Jason Wang
On 2020/11/9 下午9:33, Yuri Benditovich wrote: On Mon, Nov 9, 2020 at 4:14 AM Jason Wang > wrote: On 2020/11/5 下午11:13, Yuri Benditovich wrote: > First of all, thank you for all your feedbacks > > Please help me to summarize and let us understand

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-09 Thread Yuri Benditovich
On Mon, Nov 9, 2020 at 4:14 AM Jason Wang wrote: > > On 2020/11/5 下午11:13, Yuri Benditovich wrote: > > First of all, thank you for all your feedbacks > > > > Please help me to summarize and let us understand better what we do in > v2: > > Major questions are: > > 1. Building eBPF from source

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-08 Thread Jason Wang
On 2020/11/5 下午11:13, Yuri Benditovich wrote: First of all, thank you for all your feedbacks Please help me to summarize and let us understand better what we do in v2: Major questions are: 1. Building eBPF from source during qemu build vs. regenerating it on demand and keeping in the

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-05 Thread Yuri Benditovich
First of all, thank you for all your feedbacks Please help me to summarize and let us understand better what we do in v2: Major questions are: 1. Building eBPF from source during qemu build vs. regenerating it on demand and keeping in the repository Solution 1a (~ as in v1): keep instructions or

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-05 Thread Daniel P . Berrangé
On Thu, Nov 05, 2020 at 10:01:09AM +, Daniel P. Berrangé wrote: > On Thu, Nov 05, 2020 at 11:46:18AM +0800, Jason Wang wrote: > > > > On 2020/11/4 下午5:31, Daniel P. Berrangé wrote: > > > On Wed, Nov 04, 2020 at 10:07:52AM +0800, Jason Wang wrote: > > > > On 2020/11/3 下午6:32, Yuri Benditovich

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-05 Thread Daniel P . Berrangé
On Thu, Nov 05, 2020 at 11:46:18AM +0800, Jason Wang wrote: > > On 2020/11/4 下午5:31, Daniel P. Berrangé wrote: > > On Wed, Nov 04, 2020 at 10:07:52AM +0800, Jason Wang wrote: > > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > >

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-05 Thread Yuri Benditovich
On Thu, Nov 5, 2020 at 5:52 AM Jason Wang wrote: > > On 2020/11/5 上午11:46, Jason Wang wrote: > >> > >> It's probably ok if we treat the bytecode as a kind of firmware. > > That is explicitly *not* OK for inclusion in Fedora. They require that > > BPF is compiled from source, and rejected my

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Jason Wang
On 2020/11/5 上午11:46, Jason Wang wrote: It's probably ok if we treat the bytecode as a kind of firmware. That is explicitly *not* OK for inclusion in Fedora. They require that BPF is compiled from source, and rejected my suggestion that it could be considered a kind of firmware and thus have

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Jason Wang
On 2020/11/4 下午5:31, Daniel P. Berrangé wrote: On Wed, Nov 04, 2020 at 10:07:52AM +0800, Jason Wang wrote: On 2020/11/3 下午6:32, Yuri Benditovich wrote: On Tue, Nov 3, 2020 at 11:02 AM Jason Wang mailto:jasow...@redhat.com>> wrote: On 2020/11/3 上午2:51, Andrew Melnychenko wrote: >

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Daniel P . Berrangé
On Wed, Nov 04, 2020 at 01:49:05PM +0200, Yuri Benditovich wrote: > On Wed, Nov 4, 2020 at 4:08 AM Jason Wang wrote: > > > > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > > wrote: > > > > > > > > >

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Yuri Benditovich
On Wed, Nov 4, 2020 at 4:08 AM Jason Wang wrote: > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > wrote: > > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > Basic idea is to use eBPF to

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Daniel P . Berrangé
On Wed, Nov 04, 2020 at 10:07:52AM +0800, Jason Wang wrote: > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > wrote: > > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > Basic idea is to

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Jason Wang
On 2020/11/3 下午7:56, Daniel P. Berrangé wrote: On Tue, Nov 03, 2020 at 12:32:43PM +0200, Yuri Benditovich wrote: On Tue, Nov 3, 2020 at 11:02 AM Jason Wang wrote: On 2020/11/3 上午2:51, Andrew Melnychenko wrote: Basic idea is to use eBPF to calculate and steer packets in TAP. RSS(Receive

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Jason Wang
On 2020/11/3 下午6:32, Yuri Benditovich wrote: On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > wrote: On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > Basic idea is to use eBPF to calculate and steer packets in TAP. > RSS(Receive Side Scaling) is used to

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Daniel P . Berrangé
On Tue, Nov 03, 2020 at 12:32:43PM +0200, Yuri Benditovich wrote: > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang wrote: > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > Basic idea is to use eBPF to calculate and steer packets in TAP. > > > RSS(Receive Side Scaling) is used to

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Yuri Benditovich
On Tue, Nov 3, 2020 at 11:02 AM Jason Wang wrote: > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > Basic idea is to use eBPF to calculate and steer packets in TAP. > > RSS(Receive Side Scaling) is used to distribute network packets to guest > virtqueues > > by calculating packet hash. > >

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Jason Wang
On 2020/11/3 上午2:51, Andrew Melnychenko wrote: Basic idea is to use eBPF to calculate and steer packets in TAP. RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash. eBPF RSS allows us to use RSS with vhost TAP. This set of patches

[RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-02 Thread Andrew Melnychenko
Basic idea is to use eBPF to calculate and steer packets in TAP. RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash. eBPF RSS allows us to use RSS with vhost TAP. This set of patches introduces the usage of eBPF for packet steering and