Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Wed, Jul 17, 2024 at 9:32 AM Thomas Huth wrote: > > There is the pycotap dependency to produce TAP from pytest, but that's > > probably something small enough to be vendored. > > The next version is only depending on pycotap now. I'm installing it in the > venv there that we also install when r

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On 16/07/2024 20.03, Paolo Bonzini wrote: Il mar 16 lug 2024, 18:45 John Snow > ha scritto: My only ask is that we keep the tests running in the custom venv environment we set up at build time Yes, they do, however pytest should also be added to pythondeps.t

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On 16/07/2024 18.45, John Snow wrote: On Thu, Jul 11, 2024, 7:55 AM Thomas Huth > wrote: ... - I haven't looked into logging yet ... this still needs some work   so that you could e.g. inspect the console output of the guests   somewhere FWIW: This is now

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Tue, Jul 16, 2024 at 09:34:41PM +0200, Paolo Bonzini wrote: > Il mar 16 lug 2024, 20:10 Daniel P. Berrangé ha > scritto: > > > On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote: > > > Il mar 16 lug 2024, 18:45 John Snow ha scritto: > > > > > > > My only ask is that we keep the tes

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

Il mar 16 lug 2024, 20:10 Daniel P. Berrangé ha scritto: > On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote: > > Il mar 16 lug 2024, 18:45 John Snow ha scritto: > > > > > My only ask is that we keep the tests running in the custom venv > > > environment we set up at build time > > >

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote: > Il mar 16 lug 2024, 18:45 John Snow ha scritto: > > > My only ask is that we keep the tests running in the custom venv > > environment we set up at build time > > > > Yes, they do, however pytest should also be added to pythondeps.

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

Il mar 16 lug 2024, 18:45 John Snow ha scritto: > My only ask is that we keep the tests running in the custom venv > environment we set up at build time > Yes, they do, however pytest should also be added to pythondeps.toml if we go this way. If we move to pytest, it's possible we can eliminate

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Thu, Jul 11, 2024, 7:55 AM Thomas Huth wrote: > The Avocado v88 that we use in QEMU is already on a life support > system: It is not supported by upstream anymore, and with the latest > versions of Python, it won't work anymore since it depends on the > "imp" module that has been removed in Py

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Fri, Jul 12, 2024 at 03:25:23PM +0100, Alex Bennée wrote: > Daniel P. Berrangé writes: > > > On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote: > >> On 11/07/2024 16.39, Fabiano Rosas wrote: > >> > Thomas Huth writes: > >> ... > >> > > Things that need further attention though: > >>

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

Daniel P. Berrangé writes: > On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote: >> On 11/07/2024 16.39, Fabiano Rosas wrote: >> > Thomas Huth writes: >> ... >> > > Things that need further attention though: >> > > >> > > - All tests that use the LinuxTest / LinuxDistro classes (e.g. b

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote: > On 11/07/2024 16.39, Fabiano Rosas wrote: > > Thomas Huth writes: > ... > > > Things that need further attention though: > > > > > > - All tests that use the LinuxTest / LinuxDistro classes (e.g. based > > >on cloud-init images) r

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On 11/07/2024 16.39, Fabiano Rosas wrote: Thomas Huth writes: ... Things that need further attention though: - All tests that use the LinuxTest / LinuxDistro classes (e.g. based on cloud-init images) really depend on the Avocado framework, thus we'd need a solution for those if we want

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

Thomas Huth writes: > The Avocado v88 that we use in QEMU is already on a life support > system: It is not supported by upstream anymore, and with the latest > versions of Python, it won't work anymore since it depends on the > "imp" module that has been removed in Python 3.12. > > There have bee

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Thu, Jul 11, 2024 at 01:55:38PM +0200, Thomas Huth wrote: > The Avocado v88 that we use in QEMU is already on a life support > system: It is not supported by upstream anymore, and with the latest > versions of Python, it won't work anymore since it depends on the > "imp" module that has been rem

[RFC PATCH 0/8] Convert avocado tests to normal Python unittests

The Avocado v88 that we use in QEMU is already on a life support system: It is not supported by upstream anymore, and with the latest versions of Python, it won't work anymore since it depends on the "imp" module that has been removed in Python 3.12. There have been several attempts to update the