Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

2021-02-23 Thread Claudio Fontana
On 2/22/21 4:54 PM, Richard Henderson wrote: > On 2/22/21 12:31 AM, Claudio Fontana wrote: >> actually this is a fix for an error I introduced when adding TCGOps: >> >> arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops, >> which is TCG-only. >> Maybe I should extract this a

Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

2021-02-22 Thread Richard Henderson
On 2/22/21 12:31 AM, Claudio Fontana wrote: > actually this is a fix for an error I introduced when adding TCGOps: > > arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops, > which is TCG-only. > Maybe I should extract this and make it a standalone fix. > > Currently, there

Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

2021-02-22 Thread Claudio Fontana
On 2/22/21 7:21 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> +#ifdef CONFIG_TCG >> bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request) >> { >> CPUClass *cc = CPU_GET_CLASS(cs); >> @@ -607,6 +608,7 @@ bool arm_cpu_exec_interrupt(CPUState *cs, int

Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

2021-02-21 Thread Richard Henderson
On 2/21/21 1:24 AM, Claudio Fontana wrote: > +#ifdef CONFIG_TCG > bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request) > { > CPUClass *cc = CPU_GET_CLASS(cs); > @@ -607,6 +608,7 @@ bool arm_cpu_exec_interrupt(CPUState *cs, int > interrupt_request) > cc->tcg_ops->do_interrup