Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-08 Thread Philippe Mathieu-Daudé
On 8/2/23 23:40, Titus Rwantare wrote: On Mon, 6 Feb 2023 at 13:38, Philippe Mathieu-Daudé wrote: Hi Titus, On 6/2/23 20:49, Titus Rwantare wrote: This is a simple i2c device that allows i2c capable devices to have GPIOs. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kco

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-08 Thread Titus Rwantare
On Mon, 6 Feb 2023 at 14:27, Corey Minyard wrote: > > On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote: > > This is a simple i2c device that allows i2c capable devices to have > > GPIOs. > > > > Reviewed-by: Hao Wu > > Signed-off-by: Titus Rwantare > > --- > > hw/arm/Kconfig

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-08 Thread Titus Rwantare
On Mon, 6 Feb 2023 at 13:38, Philippe Mathieu-Daudé wrote: > > Hi Titus, > > On 6/2/23 20:49, Titus Rwantare wrote: > > This is a simple i2c device that allows i2c capable devices to have > > GPIOs. > > > > Reviewed-by: Hao Wu > > Signed-off-by: Titus Rwantare > > --- > > hw/arm/Kconfig

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-08 Thread Titus Rwantare
On Mon, 6 Feb 2023 at 17:29, Dong, Eddie wrote: > > -Original Message- > > From: qemu-devel-bounces+eddie.dong=intel@nongnu.org > devel-bounces+eddie.dong=intel@nongnu.org> On Behalf Of Titus > > Rwantare > > Sent: Monday, February 6, 2023 11:50 AM > > To: peter.mayd...@linaro.org

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-08 Thread Titus Rwantare
On Mon, 6 Feb 2023 at 19:43, Joel Stanley wrote: > > On Mon, 6 Feb 2023 at 19:51, Titus Rwantare wrote: > > > > This is a simple i2c device that allows i2c capable devices to have > > GPIOs. > > Nice. > > In Linux this is supported by a driver called pca953x. Would it make > sense to name your m

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-06 Thread Joel Stanley
On Mon, 6 Feb 2023 at 19:51, Titus Rwantare wrote: > > This is a simple i2c device that allows i2c capable devices to have > GPIOs. Nice. In Linux this is supported by a driver called pca953x. Would it make sense to name your model similarly (both the file and the prefixes you use)? If we do t

RE: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-06 Thread Dong, Eddie
> -Original Message- > From: qemu-devel-bounces+eddie.dong=intel@nongnu.org devel-bounces+eddie.dong=intel@nongnu.org> On Behalf Of Titus > Rwantare > Sent: Monday, February 6, 2023 11:50 AM > To: peter.mayd...@linaro.org > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Titus Rw

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-06 Thread Corey Minyard
On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote: > This is a simple i2c device that allows i2c capable devices to have > GPIOs. > > Reviewed-by: Hao Wu > Signed-off-by: Titus Rwantare > --- > hw/arm/Kconfig | 1 + > hw/gpio/meson.build | 1 + > hw

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

2023-02-06 Thread Philippe Mathieu-Daudé
Hi Titus, On 6/2/23 20:49, Titus Rwantare wrote: This is a simple i2c device that allows i2c capable devices to have GPIOs. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig | 1 + hw/gpio/meson.build | 1 + hw/gpio/pca_i2c_gpio.c