Re: [Qemu-devel] [PATCH] SVM IOIO intercept does not check all bits

2007-12-08 Thread Bernhard Kauer
On Fri, Dec 07, 2007 at 04:16:00PM +0100, Alexander Graf wrote: For IN/OUT instructions that access more than a single byte, the permission bits for all bytes are checked; if any bit is set to 1, the I/O operation is intercepted. > > That was the one. Thank you. Unfortunately

Re: [Qemu-devel] [PATCH] SVM IOIO intercept does not check all bits

2007-12-07 Thread Alexander Graf
On Dec 7, 2007, at 3:20 PM, Bernhard Kauer wrote: On Fri, Dec 07, 2007 at 02:10:35PM +0100, Alexander Graf wrote: Could you please make this more readable? Not easy by a one liner. I splitted the mask calculation in a separate line. Is it better now? Much better, yes. Apart from tha

Re: [Qemu-devel] [PATCH] SVM IOIO intercept does not check all bits

2007-12-07 Thread Bernhard Kauer
On Fri, Dec 07, 2007 at 02:10:35PM +0100, Alexander Graf wrote: > Could you please make this more readable? Not easy by a one liner. I splitted the mask calculation in a separate line. Is it better now? > Apart from that the patch is fine if the highest bit in the IOIO vector is > to be set. I co

Re: [Qemu-devel] [PATCH] SVM IOIO intercept does not check all bits

2007-12-07 Thread Alexander Graf
Hi, On Dec 6, 2007, at 8:31 PM, Bernhard Kauer wrote: The SVM IOIO intercept does not check all bits in the IO permission map for in/outs with word or long operand size. The attached patch fix this. Bernhard Kauer Could you please make this more readable? Apart from that the pat