Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 15:31, Philippe Mathieu-Daudé wrote: > I disagree on this, since userland binaries are compiled for a specific > arch/ABI/FPU. > Even without worrying about the FPU, it is unlikely the "any" cpu can > run indifferently ARMv6 and ARMv7 binaries. In practice this works fine. G

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Philippe Mathieu-Daudé
(CC'ing linux-user maintainers) Hi Peter, Igor, On 01/18/2018 10:10 AM, Peter Maydell wrote: > On 18 January 2018 at 13:06, Igor Mammedov wrote: >> I've looked and such case is rather an exception, >> I can fix it up in 2 ways: >> 1st: >> target/arm/cpu.h >> +#if !defined(CONFIG_USER_ONLY) >

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Thu, 18 Jan 2018 13:49:25 + Peter Maydell wrote: > On 18 January 2018 at 13:45, Igor Mammedov wrote: > > On Thu, 18 Jan 2018 13:36:40 + > > Peter Maydell wrote: > > > >> On 18 January 2018 at 13:34, Igor Mammedov wrote: > >> > and renaming > >> > > >> > TARGET_DEFAULT_CPU_TYPE t

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 13:45, Igor Mammedov wrote: > On Thu, 18 Jan 2018 13:36:40 + > Peter Maydell wrote: > >> On 18 January 2018 at 13:34, Igor Mammedov wrote: >> > and renaming >> > >> > TARGET_DEFAULT_CPU_TYPE to USERONLY_DEFAULT_CPU_TYPE >> > >> > but I'd still keep it within $ARCH/cpu.h

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Thu, 18 Jan 2018 13:36:40 + Peter Maydell wrote: > On 18 January 2018 at 13:34, Igor Mammedov wrote: > > and renaming > > > > TARGET_DEFAULT_CPU_TYPE to USERONLY_DEFAULT_CPU_TYPE > > > > but I'd still keep it within $ARCH/cpu.h so we won't > > have to create a bunch of new linux-user/$ARC

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 13:34, Igor Mammedov wrote: > and renaming > > TARGET_DEFAULT_CPU_TYPE to USERONLY_DEFAULT_CPU_TYPE > > but I'd still keep it within $ARCH/cpu.h so we won't > have to create a bunch of new linux-user/$ARCH/target_elf.h > files just for that and duplicate it to bsd-user/$ARCH/

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Thu, 18 Jan 2018 13:10:13 + Peter Maydell wrote: > On 18 January 2018 at 13:06, Igor Mammedov wrote: > > I've looked and such case is rather an exception, > > I can fix it up in 2 ways: > > 1st: > > target/arm/cpu.h > > +#if !defined(CONFIG_USER_ONLY) > > +#define TARGET_DEFAULT_CPU

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 13:06, Igor Mammedov wrote: > I've looked and such case is rather an exception, > I can fix it up in 2 ways: > 1st: > target/arm/cpu.h > +#if !defined(CONFIG_USER_ONLY) > +#define TARGET_DEFAULT_CPU_TYPE TYPE_ARM_CPU > +else > +#define TARGET_DEFAULT_CPU_TYPE ARM_CP

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Thu, 18 Jan 2018 10:50:19 + Peter Maydell wrote: > On 18 January 2018 at 10:43, Igor Mammedov wrote: > > Peter Maydell wrote: > >> That usage must want a different name, though, surely? > >> For Arm the default CPU for linux-user is 'any' but that > >> is usermode only and won't work f

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 10:43, Igor Mammedov wrote: > Peter Maydell wrote: >> That usage must want a different name, though, surely? >> For Arm the default CPU for linux-user is 'any' but that >> is usermode only and won't work for system emulation so >> null-machine.c will need to pick something e

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Wed, 17 Jan 2018 20:30:14 + Peter Maydell wrote: > On 17 January 2018 at 19:15, Igor Mammedov wrote: > > On Wed, 17 Jan 2018 16:12:09 + > > Peter Maydell wrote: > >> I like moving this from being an ifdef ladder into per-cpu > >> code, but I don't think the definition belongs in ta

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Peter Maydell
On 17 January 2018 at 19:15, Igor Mammedov wrote: > On Wed, 17 Jan 2018 16:12:09 + > Peter Maydell wrote: >> I like moving this from being an ifdef ladder into per-cpu >> code, but I don't think the definition belongs in target/$ARCH. >> It's part of the choice usermode makes about how to han

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Igor Mammedov
On Wed, 17 Jan 2018 16:12:09 + Peter Maydell wrote: > On 17 January 2018 at 15:43, Igor Mammedov wrote: > > Series is finishing work on generalizing cpu_model parsing > > and limiting parts that deal with inconsistent cpu_model > > naming to "-cpu" CLI option processing in vl.c/*-user.main.c

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Peter Maydell
On 17 January 2018 at 15:43, Igor Mammedov wrote: > Series is finishing work on generalizing cpu_model parsing > and limiting parts that deal with inconsistent cpu_model > naming to "-cpu" CLI option processing in vl.c/*-user.main.c > and FOO_cpu_class_by_name() callbacks. > > It introduces TARGET