Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: What is this used for? On x86 the kernel uses bios output for early prints. We don't have bios and do therefore need to bring up a console device as early as possible so that we can see kernel panics during I/O subsystem detection/startup. All s390 console devices do

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: Oh, that's bad :-) That should really be it's own character device. We don't really have a way to connect two character devices like that. Maybe muxing? It will be a character device, once the device tree is initialized. Better ideas are welcome, just keep in mind

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Arnd Bergmann
On Wednesday 25 November 2009, Carsten Otte wrote: Anthony Liguori wrote: Oh, that's bad :-) That should really be it's own character device. We don't really have a way to connect two character devices like that. Maybe muxing? It will be a character device, once the device tree is

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Arnd Bergmann wrote: Can't you just leave it out for this release? Early printk is great for debugging, but not essential if you just want to run a guest as long as you get it past the virtio init phase. The upstream kernel assumes to have this hypercall available when running on kvm. You won't

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Anthony Liguori
Alexander Graf wrote: On our S390x Virtio machine we don't have anywhere to display early printks on, because we don't know about VGA or serial ports. So instead we just forward everything to the virtio console that we created anyways. What is this used for? Signed-off-by: Alexander Graf

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Alexander Graf
On 24.11.2009, at 19:55, Anthony Liguori wrote: Alexander Graf wrote: On our S390x Virtio machine we don't have anywhere to display early printks on, because we don't know about VGA or serial ports. So instead we just forward everything to the virtio console that we created anyways.

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Anthony Liguori
Alexander Graf wrote: On 24.11.2009, at 19:55, Anthony Liguori wrote: Alexander Graf wrote: On our S390x Virtio machine we don't have anywhere to display early printks on, because we don't know about VGA or serial ports. So instead we just forward everything to the virtio console

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Alexander Graf
On 24.11.2009, at 20:25, Anthony Liguori wrote: Alexander Graf wrote: On 24.11.2009, at 19:55, Anthony Liguori wrote: Alexander Graf wrote: On our S390x Virtio machine we don't have anywhere to display early printks on, because we don't know about VGA or serial ports. So

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Anthony Liguori
Alexander Graf wrote: On 24.11.2009, at 20:25, Anthony Liguori wrote: Alexander Graf wrote: On 24.11.2009, at 19:55, Anthony Liguori wrote: Alexander Graf wrote: On our S390x Virtio machine we don't have anywhere to display early printks on, because we don't

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Alexander Graf
On 24.11.2009, at 20:30, Anthony Liguori wrote: Alexander Graf wrote: On 24.11.2009, at 20:25, Anthony Liguori wrote: Alexander Graf wrote: On 24.11.2009, at 19:55, Anthony Liguori wrote: Alexander Graf wrote: On our S390x Virtio machine we don't have

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Anthony Liguori
Alexander Graf wrote: Oh, that's bad :-) That should really be it's own character device. We don't really have a way to connect two character devices like that. Maybe muxing? So you want me to implement char muxing and a bootloader within a week? :) Char muxing is already there.

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-24 Thread Alexander Graf
On 24.11.2009, at 20:48, Anthony Liguori wrote: Alexander Graf wrote: Oh, that's bad :-) That should really be it's own character device. We don't really have a way to connect two character devices like that. Maybe muxing? So you want me to implement char muxing and a bootloader