Re: Suspicious QOM types without instance/class size

2020-08-24 Thread Eduardo Habkost
On Mon, Aug 24, 2020 at 08:06:42PM +0300, Roman Bolshakov wrote: > On Mon, Aug 24, 2020 at 12:45:52PM -0400, Eduardo Habkost wrote: > > On Mon, Aug 24, 2020 at 07:41:34PM +0300, Roman Bolshakov wrote: > > > On Fri, Aug 21, 2020 at 01:48:02PM -0400, Eduardo Habkost wrote: > > > > Signed-off-by:

Re: Suspicious QOM types without instance/class size

2020-08-24 Thread Roman Bolshakov
On Mon, Aug 24, 2020 at 12:45:52PM -0400, Eduardo Habkost wrote: > On Mon, Aug 24, 2020 at 07:41:34PM +0300, Roman Bolshakov wrote: > > On Fri, Aug 21, 2020 at 01:48:02PM -0400, Eduardo Habkost wrote: > > > Signed-off-by: Eduardo Habkost > > > --- > > > diff --git a/target/i386/hvf/hvf.c

Re: Suspicious QOM types without instance/class size

2020-08-24 Thread Eduardo Habkost
On Mon, Aug 24, 2020 at 07:41:34PM +0300, Roman Bolshakov wrote: > On Fri, Aug 21, 2020 at 01:48:02PM -0400, Eduardo Habkost wrote: > > On Fri, Aug 21, 2020 at 01:29:38PM -0400, Eduardo Habkost wrote: > > > On Fri, Aug 21, 2020 at 01:53:52PM +0300, Roman Bolshakov wrote: > > > > On Thu, Aug 20,

Re: Suspicious QOM types without instance/class size

2020-08-24 Thread Roman Bolshakov
On Fri, Aug 21, 2020 at 01:48:02PM -0400, Eduardo Habkost wrote: > On Fri, Aug 21, 2020 at 01:29:38PM -0400, Eduardo Habkost wrote: > > On Fri, Aug 21, 2020 at 01:53:52PM +0300, Roman Bolshakov wrote: > > > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > > > > While trying to

Re: Suspicious QOM types without instance/class size

2020-08-24 Thread Cornelia Huck
On Fri, 21 Aug 2020 17:01:49 -0400 Eduardo Habkost wrote: > On Fri, Aug 21, 2020 at 11:43:35AM +0200, Cornelia Huck wrote: > > On Thu, 20 Aug 2020 17:55:29 -0400 > > Eduardo Habkost wrote: > > > > > While trying to convert TypeInfo declarations to the new > > > OBJECT_DECLARE* macros, I've

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 11:43:35AM +0200, Cornelia Huck wrote: > On Thu, 20 Aug 2020 17:55:29 -0400 > Eduardo Habkost wrote: > > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 11:40:12AM +0200, David Hildenbrand wrote: > On 20.08.20 23:55, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is not set, despite

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 11:47:32AM +1000, David Gibson wrote: > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 01:29:38PM -0400, Eduardo Habkost wrote: > On Fri, Aug 21, 2020 at 01:53:52PM +0300, Roman Bolshakov wrote: > > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > > > While trying to convert TypeInfo declarations to the new > > > OBJECT_DECLARE* macros, I've

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 01:53:52PM +0300, Roman Bolshakov wrote: > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 09:06:51AM -0700, Alistair Francis wrote: > On Thu, Aug 20, 2020 at 2:56 PM Eduardo Habkost wrote: > > > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Alistair Francis
On Thu, Aug 20, 2020 at 2:56 PM Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > >

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Roman Bolshakov
On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Cornelia Huck
On Thu, 20 Aug 2020 17:55:29 -0400 Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. >

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread David Hildenbrand
On 20.08.20 23:55, Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > > The ones with

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Peter Maydell
On Thu, 20 Aug 2020 at 22:55, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > >

Re: Suspicious QOM types without instance/class size

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific

Suspicious QOM types without instance/class size

2020-08-20 Thread Eduardo Habkost
While trying to convert TypeInfo declarations to the new OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases where instance_size or class_size is not set, despite having type checker macros that use a specific type. The ones with "WARNING" are abstract types (maybe not serious if