Re: css_clear_io_interrupt() error handling

2023-05-14 Thread Markus Armbruster
Halil Pasic writes: > On Thu, 11 May 2023 14:20:51 +0200 > Markus Armbruster wrote: > [..] >> > >> > In my opinion the best way to deal with such situations would be to >> > abort() in test/development and log a warning in production. Of course >> >> Understand, but... >> >> > assert() would

Re: css_clear_io_interrupt() error handling

2023-05-11 Thread Halil Pasic
On Thu, 11 May 2023 14:20:51 +0200 Markus Armbruster wrote: [..] > > > > In my opinion the best way to deal with such situations would be to > > abort() in test/development and log a warning in production. Of course > > Understand, but... > > > assert() wouldn't give me that, and it wouldn't b

Re: css_clear_io_interrupt() error handling

2023-05-11 Thread Markus Armbruster
Halil Pasic writes: > On Wed, 10 May 2023 08:32:12 +0200 > Markus Armbruster wrote: > >> Halil Pasic writes: >> >> > On Mon, 08 May 2023 11:01:55 +0200 >> > Cornelia Huck wrote: >> > >> >> On Mon, May 08 2023, Markus Armbruster wrote: > [..] >> > and we do check for availability and cover

Re: css_clear_io_interrupt() error handling

2023-05-10 Thread Halil Pasic
On Wed, 10 May 2023 08:32:12 +0200 Markus Armbruster wrote: > Halil Pasic writes: > > > On Mon, 08 May 2023 11:01:55 +0200 > > Cornelia Huck wrote: > > > >> On Mon, May 08 2023, Markus Armbruster wrote: [..] > > and we do check for availability and cover that via -ENOSYS. > > Yes, kvm_s3

Re: css_clear_io_interrupt() error handling

2023-05-09 Thread Markus Armbruster
Halil Pasic writes: > On Mon, 08 May 2023 11:01:55 +0200 > Cornelia Huck wrote: > >> On Mon, May 08 2023, Markus Armbruster wrote: >> >> > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I >> > wonder whether that's appropriate. Let's have a closer look: > > Just for my unde

Re: css_clear_io_interrupt() error handling

2023-05-09 Thread Halil Pasic
On Mon, 08 May 2023 11:01:55 +0200 Cornelia Huck wrote: > On Mon, May 08 2023, Markus Armbruster wrote: > > > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I > > wonder whether that's appropriate. Let's have a closer look: Just for my understanding, was there a field probl

Re: css_clear_io_interrupt() error handling

2023-05-08 Thread Cornelia Huck
On Mon, May 08 2023, Markus Armbruster wrote: > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I > wonder whether that's appropriate. Let's have a closer look: > > static void css_clear_io_interrupt(uint16_t subchannel_id, >uint16_t

css_clear_io_interrupt() error handling

2023-05-07 Thread Markus Armbruster
css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I wonder whether that's appropriate. Let's have a closer look: static void css_clear_io_interrupt(uint16_t subchannel_id, uint16_t subchannel_nr) { Error *err = NULL; s