[PULL 43/43] hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-31 Thread Peter Maydell
From: David Hubbard This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc in https://bugs.launchpad.net/qemu/+bug/1907042 and migrated to bug #303 does the following to feed it a SETUP pid (valid) at an EndPt of 1 (invalid - all SETUP pids must be a

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-30 Thread Cord Amfmgm
On Thu, May 30, 2024 at 2:12 PM Alex Bennée wrote: > Cord Amfmgm writes: > > > On Thu, May 30, 2024 at 3:33 AM Alex Bennée > wrote: > > > > Cord Amfmgm writes: > > > > > On Tue, May 28, 2024 at 11:32 AM Peter Maydell < > peter.mayd...@linaro.org> wrote: > > > > > > On Tue, 28 May 2024 at

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-30 Thread Alex Bennée
Cord Amfmgm writes: > On Thu, May 30, 2024 at 3:33 AM Alex Bennée wrote: > > Cord Amfmgm writes: > > > On Tue, May 28, 2024 at 11:32 AM Peter Maydell > wrote: > > > > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell > wrote

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-30 Thread Cord Amfmgm
On Thu, May 30, 2024 at 3:33 AM Alex Bennée wrote: > Cord Amfmgm writes: > > > On Tue, May 28, 2024 at 11:32 AM Peter Maydell > wrote: > > > > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell < > peter.mayd...@linaro.org> wrote: > >

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-30 Thread Alex Bennée
Cord Amfmgm writes: > On Tue, May 28, 2024 at 11:32 AM Peter Maydell > wrote: > > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell > wrote: > >> > >> On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: > >> > On Mon, May 20, 2024 at 1

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-29 Thread Cord Amfmgm
On Tue, May 28, 2024 at 11:32 AM Peter Maydell wrote: > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell > wrote: > >> > >> On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: > >> > On Mon, May 20, 2024 at 12:05 PM Peter Maydell < > p

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-28 Thread Peter Maydell
On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell > wrote: >> >> On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: >> > On Mon, May 20, 2024 at 12:05 PM Peter Maydell >> > wrote: >> >> For the "zero length buffer" case, do you have a more de

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-28 Thread Cord Amfmgm
On Tue, May 28, 2024 at 9:03 AM Peter Maydell wrote: > On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: > > On Mon, May 20, 2024 at 12:05 PM Peter Maydell > wrote: > >> For the "zero length buffer" case, do you have a more detailed > >> pointer to the bit of the spec that says that "cbp = be +

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-28 Thread Peter Maydell
On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: > On Mon, May 20, 2024 at 12:05 PM Peter Maydell > wrote: >> For the "zero length buffer" case, do you have a more detailed >> pointer to the bit of the spec that says that "cbp = be + 1" is a >> valid way to specify a zero length buffer? Table 4-

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-20 Thread Cord Amfmgm
On Mon, May 20, 2024 at 12:05 PM Peter Maydell wrote: > On Tue, 6 Feb 2024 at 13:25, Cord Amfmgm wrote: > > > > This changes the ohci validation to not assert if invalid > > data is fed to the ohci controller. The poc suggested in > > https://bugs.launchpad.net/qemu/+bug/1907042 > > and then mig

Re: [PATCH 1/2] hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-20 Thread Cord Amfmgm
On Mon, May 20, 2024 at 11:55 AM Peter Maydell wrote: > On Thu, 9 May 2024 at 01:30, David Hubbard wrote: > > > > From: Cord Amfmgm > > > > This changes the ohci validation to not assert if invalid data is fed to > the > > ohci controller. The poc in https://bugs.launchpad.net/qemu/+bug/1907042

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-20 Thread Peter Maydell
On Tue, 6 Feb 2024 at 13:25, Cord Amfmgm wrote: > > This changes the ohci validation to not assert if invalid > data is fed to the ohci controller. The poc suggested in > https://bugs.launchpad.net/qemu/+bug/1907042 > and then migrated to bug #303 does the following to > feed it a SETUP pid and En

Re: [PATCH 1/2] hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-20 Thread Peter Maydell
On Thu, 9 May 2024 at 01:30, David Hubbard wrote: > > From: Cord Amfmgm > > This changes the ohci validation to not assert if invalid data is fed to the > ohci controller. The poc in https://bugs.launchpad.net/qemu/+bug/1907042 and > migrated to bug #303 does the following to feed it a SETUP pid

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-12 Thread Cord Amfmgm
On Sat, May 11, 2024 at 5:25 AM Peter Maydell wrote: > On Thu, 9 May 2024 at 19:17, Cord Amfmgm wrote: > > > > > > > > On Thu, May 9, 2024 at 12:48 PM Peter Maydell > wrote: > >> > >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > >> > On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: > >>

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-11 Thread Peter Maydell
On Thu, 9 May 2024 at 19:17, Cord Amfmgm wrote: > > > > On Thu, May 9, 2024 at 12:48 PM Peter Maydell > wrote: >> >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: >> > On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: >> >> >> >> Your Signed-off-by line does not match the From: line ... coul

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-10 Thread Cord Amfmgm
On Thu, May 9, 2024 at 3:37 PM BALATON Zoltan wrote: > On Thu, 9 May 2024, Cord Amfmgm wrote: > > On Thu, May 9, 2024 at 12:48 PM Peter Maydell > > wrote: > > > >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > >>> On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: > > Your Signed-

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-09 Thread BALATON Zoltan
On Thu, 9 May 2024, Cord Amfmgm wrote: On Thu, May 9, 2024 at 12:48 PM Peter Maydell wrote: On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: Your Signed-off-by line does not match the From: line ... could you please fix this? (see https

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-09 Thread Cord Amfmgm
On Thu, May 9, 2024 at 12:48 PM Peter Maydell wrote: > On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > > On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: > >> > >> Your Signed-off-by line does not match the From: line ... could you > please > >> fix this? (see > >> > https://www.qemu.org/doc

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-09 Thread Peter Maydell
On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: >> >> Your Signed-off-by line does not match the From: line ... could you please >> fix this? (see >> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-sign

[PATCH 1/2] hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-08 Thread David Hubbard
From: Cord Amfmgm This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc in https://bugs.launchpad.net/qemu/+bug/1907042 and migrated to bug #303 does the following to feed it a SETUP pid (valid) at an EndPt of 1 (invalid - all SETUP pids must be add

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-08 Thread Cord Amfmgm
On Wed, May 8, 2024 at 4:53 AM Philippe Mathieu-Daudé wrote: > On 7/5/24 22:20, Cord Amfmgm wrote: > > > > > > On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm > > wrote: > > > > On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev > > wrote: >

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-08 Thread Philippe Mathieu-Daudé
On 7/5/24 22:20, Cord Amfmgm wrote: On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm > wrote: On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev mailto:m...@tls.msk.ru>> wrote: 06.02.2024 10:13, Cord Amfmgm wrote: > This changes the ohci validation to

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-08 Thread Thomas Huth
On 07/05/2024 22.20, Cord Amfmgm wrote: On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm > wrote: On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev mailto:m...@tls.msk.ru>> wrote: 06.02.2024 10:13, Cord Amfmgm wrote: > This changes the ohci validatio

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-07 Thread Cord Amfmgm
On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm wrote: > On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > >> 06.02.2024 10:13, Cord Amfmgm wrote: >> > This changes the ohci validation to not assert if invalid >> > data is fed to the ohci controller. The poc suggested in >> > https://bugs.la

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-04-24 Thread Cord Amfmgm
On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > 06.02.2024 10:13, Cord Amfmgm wrote: > > This changes the ohci validation to not assert if invalid > > data is fed to the ohci controller. The poc suggested in > > https://bugs.launchpad.net/qemu/+bug/1907042 > > and then migrated to bug #

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-04-19 Thread Cord Amfmgm
Hi Michael, This just got lost somehow. It is still an issue (see https://gitlab.com/qemu-project/qemu/-/issues/1510 ). I believe this change fixes the issue. On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > 06.02.2024 10:13, Cord Amfmgm wrote: > > This changes the ohci validation to n

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-04-18 Thread Michael Tokarev
06.02.2024 10:13, Cord Amfmgm wrote: This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 and then migrated to bug #303 does the following to feed it a SETUP pid and EndPt of 1: ui

[PATCH] hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread David Hubbard
This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 and then migrated to bug #303 does the following to feed it a SETUP pid and EndPt of 1: uint32_t MaxPacket = 64; uint32_t

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread Cord Amfmgm
Attempting to resend with both files in the patch this time: This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 migrated to #303 does the following to feed it a SETUP pid and EndPt of 1:

hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread Cord Amfmgm
This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 and then migrated to bug #303 does the following to feed it a SETUP pid and EndPt of 1: uint32_t MaxPacket = 64; uint32_t

hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread Cord Amfmgm
This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 migrated to #303 does the following to feed it a SETUP pid and EndPt of 1: uint32_t MaxPacket = 64; uint32_t TDFormat = 0;