Re: [Qemu-devel] [PATCH v3 1/4] block: Pass bdrv_* methods to bs->file by default

2017-07-04 Thread Kevin Wolf
Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben: > The following functions fail if bs->drv does not implement them: > > bdrv_probe_blocksizes > bdrv_probe_geometry > bdrv_truncate > bdrv_has_zero_init > bdrv_get_info > bdrv_media_changed > bdrv_eject > bdrv_lock_medium > bdrv_co_ioctl >

Re: [Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets

2017-07-04 Thread Paolo Bonzini
On 04/07/2017 10:28, Daniel P. Berrange wrote: >> +supported_kvm_target() { >> +test "$kvm" = "yes" || return 1 >> +glob "$1" "*-softmmu" || return 1 >> +case "${1%-softmmu}:$cpu" in >> +arm:arm | aarch64:aarch64 | \ >> +i386:i386 | i386:x86_64 | i386:x32 | \ >> +

Re: [Qemu-devel] [PATCH v3 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-04 Thread QingFeng Hao
在 2017/7/4 17:34, Cornelia Huck 写道: On Tue, 4 Jul 2017 10:32:31 +0200 QingFeng Hao wrote: This patch is based on a similar patch from Stefan Hajnoczi - commit c324fd0a39c (" virtio-pci: use ioeventfd even when KVM is disabled) Do not check kvm_eventfds_enabled() when KVM is disabled since

Re: [Qemu-devel] [PATCH v2 14/15] block: Align block status requests

2017-07-04 Thread Fam Zheng
On Mon, 07/03 17:14, Eric Blake wrote: > Any device that has request_alignment greater than 512 should be > unable to report status at a finer granularity; it may also be > simpler for such devices to be guaranteed that the block layer > has rounded things out to the granularity boundary (the way t

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Christian Borntraeger
On 07/04/2017 11:35 AM, David Hildenbrand wrote: >> + >> static void create_cpu_model_list(ObjectClass *klass, void *opaque) >> { >> -CpuDefinitionInfoList **cpu_list = opaque; >> +struct CpuDefinitionInfoListData *cpu_list_data = opaque; >> +CpuDefinitionInfoList **cpu_list = &cpu_li

Re: [Qemu-devel] [PATCH v2 15/15] qemu-io: Relax 'alloc' now that block-status doesn't assert

2017-07-04 Thread Fam Zheng
On Mon, 07/03 17:14, Eric Blake wrote: > Previously, the alloc command required that input parameters be > sector-aligned and clamped to 32 bits, because the underlying > bdrv_is_allocated used a 32-bit parameter and asserted aligned > inputs. But now that we have fixed block status to report a >

Re: [Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 11:44:41AM +0200, Paolo Bonzini wrote: > > > On 04/07/2017 10:28, Daniel P. Berrange wrote: > >> +supported_kvm_target() { > >> +test "$kvm" = "yes" || return 1 > >> +glob "$1" "*-softmmu" || return 1 > >> +case "${1%-softmmu}:$cpu" in > >> +arm:arm | a

Re: [Qemu-devel] [PATCH v3 2/4] block: Use defaults of bdrv_* callbacks in raw

2017-07-04 Thread Kevin Wolf
Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben: > Now that passing the call to bs->file is the default for some bdrv_* > callbacks, remove the duplicate implementations in block/raw-format.c > > Reviewed-by: Eric Blake > Signed-off-by: Manos Pitsidianakis If you change patch 1 as su

[Qemu-devel] [PULL v1 04/17] target-microblaze: Add CPU versions 9.4, 9.5 and 9.6

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add CPU versions 9.4, 9.5 and 9.6. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 4bc77df..982cb61 100644 --- a/

[Qemu-devel] [PULL v1 16/17] target-microblaze: Add CPU version 10.0

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add CPU version 10.0. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 6e27c3c..f85ff01 100644 --- a/target/microbla

[Qemu-devel] [PULL v1 02/17] target-microblaze: Correct bit shift for the PVR0 version field

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Correct bit shift for the PVR0 version field. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 2 +- target/microblaze/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/microblaze/cpu.c b/ta

[Qemu-devel] [PULL v1 00/17] Xilinx queue

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit fd479c60f5766f7fb247ad146b9e3c33d03d2055: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170603' into staging (2017-07-03 09:54:32 +0100) are available in the git repository at: g...@github.com:edgarigl/qemu.git tags/

[Qemu-devel] [PULL v1 06/17] target-microblaze: Introduce a use-div property

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Introduce a use-div property making division instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 9 + target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files chan

[Qemu-devel] [PULL v1 03/17] target-microblaze: Don't hard code 0xb as initial MB version

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Don't hard code 0xb as initial MB version. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index af70faa

[Qemu-devel] [PULL v1 05/17] target-microblaze: Introduce a use-barrel property

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Introduce a use-barrel property making barrel shifter instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 9 + target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 f

[Qemu-devel] [PULL v1 01/17] disas/microblaze: Add missing 'const' attributes

2017-07-04 Thread Edgar E. Iglesias
From: Stefan Weil Making the opcode list 'const' saves memory. Some function arguments and local variables needed 'const', too. Add also 'static' to two local functions. Reviewed-by: Edgar E. Iglesias Signed-off-by: Stefan Weil [EI: Removed old prototypes to fix the build] Signed-off-by: Edga

[Qemu-devel] [PULL v1 07/17] target-microblaze: Introduce a use-hw-mul property

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Introduce a use-div property making multiplication instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 12 target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 5 ++--

[Qemu-devel] [PULL v1 10/17] target-microblaze: dec_barrel: Use bool instead of unsigned int

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translat

[Qemu-devel] [PULL v1 14/17] target-microblaze: dec_barrel: Add BSEFI

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for BSEFI. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 42 ++ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c ind

[Qemu-devel] [PULL v1 09/17] target-microblaze: Introduce a use-pcmp-instr property

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Introduce a use-pcmp-instr property making pcmp instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 +++-- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 6 +++--- 3 files c

Re: [Qemu-devel] [PATCH v3 4/4] block: Add default implementations for bdrv_co_get_block_status()

2017-07-04 Thread Kevin Wolf
Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben: > bdrv_co_get_block_status_from_file() and > bdrv_co_get_block_status_from_backing() set *file to bs->file and > bs->backing respectively, so that bdrv_co_get_block_status() can recurse > to them. Future block drivers won't have to duplica

[Qemu-devel] [PULL v1 12/17] target-microblaze: dec_barrel: Add braces around if-statements

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add braces around if-statements. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/microblaze/translate.c b/targe

[Qemu-devel] [PULL v1 08/17] target-microblaze: Introduce a use-msr-instr property

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Introduce a use-msr-instr property making msr instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 +++-- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed

[Qemu-devel] [PULL v1 15/17] target-microblaze: dec_barrel: Add BSIFI

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for BSIFI. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c i

[Qemu-devel] [PULL v1 13/17] target-microblaze: dec_barrel: Plug TCG temp leak

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Plug TCG temp leak. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 504ed88..6ee4885 100644 --- a

[Qemu-devel] [PULL v1 17/17] xilinx-dp: Add support for the yuy2 video format

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for the yuy2 video format. Reviewed-by: KONRAD Frederic Acked-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/display/xlnx_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index f7b7b80..

[Qemu-devel] [PULL v1 11/17] target-microblaze: dec_barrel: Use extract32

2017-07-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use extract32 instead of opencoding the shifting and masking. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microb

Re: [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/

2017-07-04 Thread Paolo Bonzini
On 03/07/2017 22:19, Richard Henderson wrote: > On 07/03/2017 09:34 AM, Paolo Bonzini wrote: >> @@ -215,10 +215,12 @@ void breakpoint_handler(CPUState *cs) >> if (cs->watchpoint_hit) { >> if (cs->watchpoint_hit->flags & BP_CPU) { >> cs->watchpoint_hit = NULL; >> -

Re: [Qemu-devel] [PATCH v3 3/4] block: Remove bdrv_truncate callback in blkdebug

2017-07-04 Thread Kevin Wolf
Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben: > Now that bdrv_truncate is passed to bs->file by default, remove the > callback from block/blkdebug.c > > Signed-off-by: Manos Pitsidianakis We'll need to set .is_filter = true for blkdebug now. I haven't yet looked into the existing i

Re: [Qemu-devel] [Qemu-block] [PATCH v4 1/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-07-04 Thread Kashyap Chamarthy
On Thu, Jun 29, 2017 at 02:28:55PM +0200, Alberto Garcia wrote: > On Wed 28 Jun 2017 04:58:00 PM CEST, Kashyap Chamarthy wrote: > > +Once a 'mirror' job has started, there are two possible actions when a > > +``drive-mirror`` job is active: > > + > > +1. Issuing the command ``block-job-cancel``: wi

Re: [Qemu-devel] [PATCH 1/1] Update my email address

2017-07-04 Thread Christian Borntraeger
On 07/04/2017 11:22 AM, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck Thanks applied to my s390-next tree. > --- > MAINTAINERS | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7df088259b..afc2b8b328 100644 > --- a/MAINTAI

[Qemu-devel] [PATCH] qemu-img: delete the -e and -6 options from the 'create' command

2017-07-04 Thread Daniel P. Berrange
The '-e' and '-6' options to the 'create' command were "deprecated" in favour of the more generic '-o' option many years ago: commit eec77d9e712bd4157a4e1c0b5a9249d168add738 Author: Jes Sorensen Date: Tue Dec 7 17:44:34 2010 +0100 qemu-img: Deprecate obsolete -6 and -e options Excep

Re: [Qemu-devel] [PATCH 3/4] doc: add item for "-M enforce-config-section"

2017-07-04 Thread Peter Xu
On Tue, Jul 04, 2017 at 10:06:54AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > It's never documented, and now we have one more parameter for it (which > > means this one can be obsolete in the future). Document it properly. > > > > Although now when enforce-config-section is set, it'

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-07-04 Thread Liu, Yi L
Hi Jean, On Mon, Jul 03, 2017 at 12:52:52PM +0100, Jean-Philippe Brucker wrote: > Hi Yi, > > On 02/07/17 11:06, Liu, Yi L wrote: > > On Fri, May 12, 2017 at 01:11:02PM +0100, Jean-Philippe Brucker wrote: > > > > Hi Jean, > > > > As we've got a few discussions on it. I'd like to have a conclusio

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: fix memory hotplug error path

2017-07-04 Thread Daniel Henrique Barboza
On 07/04/2017 04:42 AM, Greg Kurz wrote: On Mon, 3 Jul 2017 14:03:07 -0300 Daniel Henrique Barboza wrote: On 07/03/2017 11:54 AM, Greg Kurz wrote: QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. Let's propagate the error instead, like it is done everywhere else where spa

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: fix memory hotplug error path

2017-07-04 Thread David Gibson
On Tue, Jul 04, 2017 at 09:42:52AM +0200, Greg Kurz wrote: > On Mon, 3 Jul 2017 14:03:07 -0300 > Daniel Henrique Barboza wrote: > > > On 07/03/2017 11:54 AM, Greg Kurz wrote: > > > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > > > Let's propagate the error instead, like it

[Qemu-devel] [PATCH v4 1/2] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-07-04 Thread Laurent Vivier
CPU_POWERPC_POWER9_DD1 is 0x004E0100, so this is the POWER9 v1.0. When we run qemu on a POWER9 DD1 host, we must use either "-cpu host" or "-cpu POWER9", but in the latter case it fails with Unable to find sPAPR CPU Core definition because POWER9 DD1 doesn't appear in the list of known CPUs.

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4] virtio-net: enable configurable tx queue size

2017-07-04 Thread Wei Wang
On 07/04/2017 03:18 AM, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:37:59AM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size) and 1024 by the user when the vhost-user backend is used. Currently, the maximum tx

[Qemu-devel] [PATCH v4 0/2] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-07-04 Thread Laurent Vivier
This patch series allows to use "-cpu POWER9" with a POWER9 DD1 host and KVM HV. With TCG, "-cpu POWER9" selects POWER9_v2.0 (POWER9 DD2). David, I send this series based on master, if you need a version based on your ppc-for-2.10 branch let me know. v4: update POWER9 comments move workaround

[Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Laurent Vivier
Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") disables compatibility mode for POWER9 DD1 to allow to boot on POWER9 DD1 host with KVM. As the workaround has been added in kvmppc_host_cpu_class_init(), it applies only on CPU created with "-cpu host". As we want to be able to use a

Re: [Qemu-devel] [PATCH 02/22] configure: early test for supported targets

2017-07-04 Thread Paolo Bonzini
On 04/07/2017 10:32, Daniel P. Berrange wrote: >> if test -z "${target_list+xxx}" ; then >> -target_list="$default_target_list" >> +for target in $default_target_list; do >> +supported_target $target 2>/dev/null && \ >> +target_list="$target_list $target" >> +done

[Qemu-devel] [PATCH v4 00/22] add disable-tcg option for x86 build

2017-07-04 Thread Paolo Bonzini
changes from v3: - patch 2: place ;; on a separate line [Daniel] - patch 14: do not touch include/exec/helper-proto.h [Richard] - patch 16: moved cpu_report_tpr_access hunk later [Richard] - patch 18: renamed tcg_update_mxcsr [Richard], added missing call to cpu_post_load - patch 20: do not

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Thomas Huth
On 04.07.2017 13:01, Laurent Vivier wrote: > Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") > disables compatibility mode for POWER9 DD1 to allow to > boot on POWER9 DD1 host with KVM. > > As the workaround has been added in kvmppc_host_cpu_class_init(), > it applies only on CPU c

[Qemu-devel] [PATCH 07/22] tcg: tcg_handle_interrupt() function

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Move tcg_handle_interrupt() from translate-common.c to accel/tcg/tcg-all.c. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/tcg/Makefile.objs | 2 +- accel/tcg/tcg-all.c | 32 + accel/tcg/

[Qemu-devel] [PATCH 05/22] vl: add tcg_enabled() for tcg related code

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Need to disable the tcg related code in the vl.c if the disable-tcg option is added into ./configure command. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- vl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --g

[Qemu-devel] [PATCH 02/22] configure: early test for supported targets

2017-07-04 Thread Paolo Bonzini
Check for unsupported targets in target_list, and print an error early in the configuration process. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- v2: place ;; on a separate line [Daniel] configure | 70 +++

[Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Add the CONFIG_TCG for exec-all.h. Since function tlb_set_page_with_attrs() is defined in ./accel/tcg/cputlb.c, which will be disabled if tcg is disabled. This function need be implemented in accel/stubs/tcg-stub.c for disable-tcg. Signed-off-by: Yang Zhong Signed-off-by: Paolo

[Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG

2017-07-04 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/tcg/translate-all.c | 5 + hmp-commands-info.hx | 4 monitor.c | 2 ++ 3 files changed, 11 insertions(+) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 4c1d8c9..093207a

[Qemu-devel] [PATCH 06/22] tcg: move page_size_init() function

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong translate-all.c will be disabled if tcg is disabled in the build, so page_size_init() function and related variables will be moved to exec.c file. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/tcg/translate-all.c | 18 ---

[Qemu-devel] [PATCH 10/22] vapic: use tcg_enabled

2017-07-04 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- hw/i386/kvmvapic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 82a4955..0d9ef77 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -410,7 +410,8 @@

[Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets

2017-07-04 Thread Paolo Bonzini
This will be useful when the functions are called, early in the configure process, to filter out targets that do not support hardware acceleration. Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- configure | 90 +++

[Qemu-devel] [PATCH 15/22] tcg: add the CONFIG_TCG into Makefiles

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Add the CONFIG_TCG for frontend and backend's files in the related Makefiles. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- Makefile.target | 4 ++-- accel/Makefile.objs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock

2017-07-04 Thread Paolo Bonzini
Adding assertions fixes link errors. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- exec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/exec.c b/exec.c index ee61915..a083ff8 100644 --- a/exec.c +++ b/exec.c @@ -2317,6 +2317,7 @@ static void notdirty_mem_write(void *o

[Qemu-devel] [PATCH 03/22] configure: add --disable-tcg configure option

2017-07-04 Thread Paolo Bonzini
From: Anthony Liguori This lets you build without TCG (hardware accelerationor qtest only). When this flag is passed to configure, it will automatically filter out the target list to only those that support KVM or Xen or HAX. Signed-off-by: Anthony Liguori Reviewed-by: Richard Henderson Revie

[Qemu-devel] [PATCH 11/22] tcg: add the tcg-stub.c file into accel/stubs/

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong If tcg is disabled, the functions in tcg-stub.c file will be called. This file is target-independent file, do not include any platform related stub functions into this file. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/stubs

[Qemu-devel] [PATCH 22/22] configure: warn on untested --disable-tcg

2017-07-04 Thread Paolo Bonzini
--disable-tcg will almost certainly fail to compile on non-x86 platforms, so issue a warning. Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index 806658c

[Qemu-devel] [PATCH 16/22] target/i386: move cpu_sync_bndcs_hflags() function

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Move cpu_sync_bndcs_hflags() function from mpx_helper.c to helper.c because mpx_helper.c need be disabled when tcg is disabled. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- v2: moved cpu_report_tpr_access hunk later [Richard] target/i386/helper.c |

[Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

2017-07-04 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/tcg/tcg-all.c| 2 +- include/sysemu/accel.h | 2 +- vl.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index dba9931..e327d90 100644

[Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Add the tcg_enabled() where the x86 target needs to disable TCG-specific code. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- v2: do not touch bpt_helper.c, adjust caller in machine.c [Richard] target/i386/cpu.c | 4 +++- target/i386/cpu.h | 8 +

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Viktor Mihajlovski
On 04.07.2017 11:35, David Hildenbrand wrote: >> + >> static void create_cpu_model_list(ObjectClass *klass, void *opaque) >> { >> -CpuDefinitionInfoList **cpu_list = opaque; >> +struct CpuDefinitionInfoListData *cpu_list_data = opaque; >> +CpuDefinitionInfoList **cpu_list = &cpu_list_

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Greg Kurz
On Tue, 4 Jul 2017 13:01:26 +0200 Laurent Vivier wrote: > Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") > disables compatibility mode for POWER9 DD1 to allow to > boot on POWER9 DD1 host with KVM. > > As the workaround has been added in kvmppc_host_cpu_class_init(), > it appli

[Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Split the cpu_set_mxcsr() and make cpu_set_fpuc() inline with specific tcg code. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- v2: renamed tcg_update_mxcsr [Richard], added missing call to cpu_post_load target/i386/cpu.h| 21 +

[Qemu-devel] [PATCH 08/22] tcg: make tcg_allowed global

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Change the tcg_enabled() and make sure user build still enable tcg even x86 softmmu disable tcg. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/tcg/cpu-exec-common.c | 2 ++ accel/tcg/tcg-all.c | 1 - accel/tcg/transla

[Qemu-devel] [PATCH 19/22] target/i386: move TLB refill function out of helper.c

2017-07-04 Thread Paolo Bonzini
This function calls tlb_set_page_with_attrs, which is not available when TCG is disabled. Move it to excp_helper.c. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/excp_helper.c | 343 + target/i386/helper.c | 344 +--

[Qemu-devel] [PATCH 12/22] tcg: move tb_lock out of translate-all.h

2017-07-04 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 1 - include/exec/exec-all.h | 4 tcg/tcg.h | 4 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 04f95dd..fa9c012 100644 --- a/

[Qemu-devel] [PATCH 17/22] target/i386: make cpu_get_fp80()/cpu_set_fp80() static

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Move cpu_get_fp80()/cpu_set_fp80() from fpu_helper.c to machine.c because fpu_helper.c will be disabled if tcg is disabled in the build. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/cpu.h| 2 -- target/i386/fp

Re: [Qemu-devel] [Qemu-ppc] [RFC v3 2/2] target/ppc: move POWER9 DD1 workaround to ppc_cpu_initfn

2017-07-04 Thread Thomas Huth
On 04.07.2017 11:27, David Gibson wrote: > On Tue, Jul 04, 2017 at 10:17:18AM +0200, Thomas Huth wrote: >> On 03.07.2017 15:14, Laurent Vivier wrote: >>> Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") >>> disables compatibility mode for POWER9 DD1 to allow to >>> boot on POWER9 DD1

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-07-04 Thread Halil Pasic
On 07/04/2017 08:42 AM, Markus Armbruster wrote: > Halil Pasic writes: > >> On 07/03/2017 03:52 PM, Markus Armbruster wrote: >>> Halil Pasic writes: >>> On 06/30/2017 04:54 PM, Eric Blake wrote: > On 06/30/2017 09:41 AM, Halil Pasic wrote: [..] >>> If we have errors that can't be adeq

[Qemu-devel] [PATCH 21/22] target/i386: add the CONFIG_TCG into Makefiles

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Add the CONFIG_TCG for frontend and backend's files in the related Makefiles. Signed-off-by: Yang Zhong Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- v2: compile out bpt_helper.c [Richard] target/i386/Makefile.objs | 8 +--- 1 file changed, 5 i

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Laurent Vivier
On 04/07/2017 13:21, Laurent Vivier wrote: > On 04/07/2017 13:15, Greg Kurz wrote: >> On Tue, 4 Jul 2017 13:01:26 +0200 >> Laurent Vivier wrote: >> >>> Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") >>> disables compatibility mode for POWER9 DD1 to allow to >>> boot on POWER9 DD1

Re: [Qemu-devel] [RFC PATCH v2 16/15] block: Add .bdrv_co_block_status() callback

2017-07-04 Thread Fam Zheng
On Mon, 07/03 17:20, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Now that the block layer exposes byte-based allocation, > it's time to tackle the drivers. Add a new callback that operates > on as small as byte boundaries. Subsequent patches

[Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Daniel P. Berrange
This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.html The goal is to clarify to users & app developers what they can expect from QEMU in terms of feature lifecycle & any deprecation

Re: [Qemu-devel] [PATCH qemu v8 2/2] memory/iommu: introduce IOMMUMemoryRegionClass

2017-07-04 Thread David Gibson
On Wed, Jun 28, 2017 at 02:19:57PM +1000, Alexey Kardashevskiy wrote: > On 21/06/17 17:26, David Gibson wrote: > > On Wed, Jun 21, 2017 at 12:05:08PM +1000, Alexey Kardashevskiy wrote: > >> On 14/06/17 16:36, Alexey Kardashevskiy wrote: > >>> This finishes QOM'fication of IOMMUMemoryRegion by intro

[Qemu-devel] [PATCH v3 1/2] docs: document support lifetime for features

2017-07-04 Thread Daniel P. Berrange
There is currently no explicit guidance on the duration of support for features such as versioned machine types, which have a finite useful lifespan. Thus apps / users cannot predict how much time they might be able to use a feature for, before it is removed (if ever). This adds a new appendix tha

[Qemu-devel] [PATCH v3 2/2] docs: document deprecated features in appendix

2017-07-04 Thread Daniel P. Berrange
The deprecation of features in QEMU is totally adhoc currently, with no way for the user to get a list of what is deprecated in each release. This adds an appendix to the doc that records when each deprecation was made and provides text explaining what to use instead, if anything. Since there has

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Laurent Vivier
On 04/07/2017 13:15, Greg Kurz wrote: > On Tue, 4 Jul 2017 13:01:26 +0200 > Laurent Vivier wrote: > >> Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") >> disables compatibility mode for POWER9 DD1 to allow to >> boot on POWER9 DD1 host with KVM. >> >> As the workaround has been a

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread David Gibson
On Tue, Jul 04, 2017 at 01:15:00PM +0200, Greg Kurz wrote: > On Tue, 4 Jul 2017 13:01:26 +0200 > Laurent Vivier wrote: > > > Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") > > disables compatibility mode for POWER9 DD1 to allow to > > boot on POWER9 DD1 host with KVM. > > > > A

Re: [Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Peter Maydell
On 4 July 2017 at 12:14, Daniel P. Berrange wrote: > This is a followup to > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.html > > The goal is to clarify to users & app developers what they can ex

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Viktor Mihajlovski
On 04.07.2017 13:22, Viktor Mihajlovski wrote: > On 04.07.2017 11:35, David Hildenbrand wrote: >>> + >>> static void create_cpu_model_list(ObjectClass *klass, void *opaque) >>> { >>> -CpuDefinitionInfoList **cpu_list = opaque; >>> +struct CpuDefinitionInfoListData *cpu_list_data = opaque;

Re: [Qemu-devel] [PULL 00/21] pc, acpi, pci, virtio: fixes, cleanups, features, tests

2017-07-04 Thread Peter Maydell
On 3 July 2017 at 20:44, Michael S. Tsirkin wrote: > The following changes since commit fd479c60f5766f7fb247ad146b9e3c33d03d2055: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170603' into > staging (2017-07-03 09:54:32 +0100) > > are available in the git repository at: > > gi

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Christian Borntraeger
On 07/03/2017 01:48 PM, Viktor Mihajlovski wrote: > The response for query-cpu-definitions didn't include the > unavailable-features field, which is used by libvirt to figure > out whether a certain cpu model is usable on the host. > > The unavailable features are now computed by obtaining the hos

Re: [Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 01:00:54PM +0100, Peter Maydell wrote: > On 4 July 2017 at 12:14, Daniel P. Berrange wrote: > > This is a followup to > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.h

Re: [Qemu-devel] [PATCH] qemu-img: delete the -e and -6 options from the 'create' command

2017-07-04 Thread Kevin Wolf
Am 04.07.2017 um 12:34 hat Daniel P. Berrange geschrieben: > The '-e' and '-6' options to the 'create' command were "deprecated" > in favour of the more generic '-o' option many years ago: > > commit eec77d9e712bd4157a4e1c0b5a9249d168add738 > Author: Jes Sorensen > Date: Tue Dec 7 17:44:3

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

2017-07-04 Thread Marcel Apfelbaum
On 04/07/2017 4:00, Alexander Bezzubikov wrote: That is why I think we can consider a possibility of forgetting about ACPI hot plug in pcie-pci bridge and use only SHPC (with some correcting work). Especially since q35 is used only for 'modern' Windows guests and there're no big problems with S

Re: [Qemu-devel] [PATCH] qemu-img: delete the -e and -6 options from the 'create' command

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 02:16:06PM +0200, Kevin Wolf wrote: > Am 04.07.2017 um 12:34 hat Daniel P. Berrange geschrieben: > > The '-e' and '-6' options to the 'create' command were "deprecated" > > in favour of the more generic '-o' option many years ago: > > > > commit eec77d9e712bd4157a4e1c0b5a

[Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

2017-07-04 Thread Jason Wang
After converting to use DMA api for virtio devices, we should use dma_as instead of address_space_memory. Otherwise it won't work if IOMMU is enabled. Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api") Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang --- hw/scsi/virtio-scsi.c | 3

Re: [Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Thomas Huth
On 04.07.2017 13:14, Daniel P. Berrange wrote: [...] > - Not listing the '-6' and '-e' args to qemu-img create. Those >were never deprecations, because the functionality was >immediately turned into a fatal error. How did you come to that conclusion? As far as I can see, the -6 option has

[Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-04 Thread Fam Zheng
Not all platforms check whether a lock is initialized before used. In particular Linux seems to be more permissive than OSX. Check initialization state explicitly in our code to catch such bugs earlier. Signed-off-by: Fam Zheng --- include/qemu/thread-posix.h | 4 include/qemu/thread-win

Re: [Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 02:21:28PM +0200, Thomas Huth wrote: > On 04.07.2017 13:14, Daniel P. Berrange wrote: > [...] > > - Not listing the '-6' and '-e' args to qemu-img create. Those > >were never deprecations, because the functionality was > >immediately turned into a fatal error. > How

[Qemu-devel] [PATCH v2] qemu-img: drop -e and -6 options from the 'create' & 'convert' commands

2017-07-04 Thread Daniel P. Berrange
The '-e' and '-6' options to the 'create' & 'convert' commands were "deprecated" in favour of the more generic '-o' option many years ago: commit eec77d9e712bd4157a4e1c0b5a9249d168add738 Author: Jes Sorensen Date: Tue Dec 7 17:44:34 2010 +0100 qemu-img: Deprecate obsolete -6 and -e o

Re: [Qemu-devel] [PATCH v2] qemu-img: drop -e and -6 options from the 'create' & 'convert' commands

2017-07-04 Thread Kevin Wolf
Am 04.07.2017 um 14:30 hat Daniel P. Berrange geschrieben: > The '-e' and '-6' options to the 'create' & 'convert' commands were > "deprecated" in favour of the more generic '-o' option many years ago: > > commit eec77d9e712bd4157a4e1c0b5a9249d168add738 > Author: Jes Sorensen > Date: Tue

Re: [Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Thomas Huth
On 04.07.2017 14:27, Daniel P. Berrange wrote: > On Tue, Jul 04, 2017 at 02:21:28PM +0200, Thomas Huth wrote: >> On 04.07.2017 13:14, Daniel P. Berrange wrote: >> [...] >>> - Not listing the '-6' and '-e' args to qemu-img create. Those >>>were never deprecations, because the functionality was

Re: [Qemu-devel] [PATCH 02/22] configure: early test for supported targets

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 01:11:55PM +0200, Paolo Bonzini wrote: > Check for unsupported targets in target_list, and print an > error early in the configuration process. > > Reviewed-by: Richard Henderson > Signed-off-by: Paolo Bonzini > --- > v2: place ;; on a separate line [Daniel] > > c

Re: [Qemu-devel] [PATCH v3 1/2] docs: document support lifetime for features

2017-07-04 Thread Thomas Huth
On 04.07.2017 13:14, Daniel P. Berrange wrote: > There is currently no explicit guidance on the duration of support > for features such as versioned machine types, which have a finite > useful lifespan. Thus apps / users cannot predict how much time > they might be able to use a feature for, before

Re: [Qemu-devel] [PULL v1 00/17] Xilinx queue

2017-07-04 Thread Peter Maydell
On 4 July 2017 at 10:54, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The following changes since commit fd479c60f5766f7fb247ad146b9e3c33d03d2055: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170603' into > staging (2017-07-03 09:54:32 +0100) > > are available in t

Re: [Qemu-devel] [PATCH v3 2/2] docs: document deprecated features in appendix

2017-07-04 Thread Thomas Huth
On 04.07.2017 13:14, Daniel P. Berrange wrote: > The deprecation of features in QEMU is totally adhoc currently, > with no way for the user to get a list of what is deprecated > in each release. This adds an appendix to the doc that records > when each deprecation was made and provides text explain

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Greg Kurz
On Tue, 4 Jul 2017 21:41:51 +1000 David Gibson wrote: > On Tue, Jul 04, 2017 at 01:15:00PM +0200, Greg Kurz wrote: > > On Tue, 4 Jul 2017 13:01:26 +0200 > > Laurent Vivier wrote: > > > > > Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 DD1") > > > disables compatibility mode for P

Re: [Qemu-devel] [PATCH v3 0/2] Document deprecated features & support lifecycle

2017-07-04 Thread Thomas Huth
On 04.07.2017 14:16, Daniel P. Berrange wrote: > On Tue, Jul 04, 2017 at 01:00:54PM +0100, Peter Maydell wrote: >> On 4 July 2017 at 12:14, Daniel P. Berrange wrote: >>> This is a followup to >>> >>> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html >>> v2: https://lists.

Re: [Qemu-devel] [PATCH v4 2/2] target/ppc: move POWER9 DD1 workaround to init_proc_POWER9()

2017-07-04 Thread Thomas Huth
On 04.07.2017 15:02, Greg Kurz wrote: > On Tue, 4 Jul 2017 21:41:51 +1000 > David Gibson wrote: > >> On Tue, Jul 04, 2017 at 01:15:00PM +0200, Greg Kurz wrote: >>> On Tue, 4 Jul 2017 13:01:26 +0200 >>> Laurent Vivier wrote: >>> Commit 5f3066d ("target/ppc: Allow workarounds for POWER9 D

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

2017-07-04 Thread Igor Mammedov
On Mon, 3 Jul 2017 19:34:07 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote: > > On Fri, 30 Jun 2017 10:25:05 +0300 > > Marcel Apfelbaum wrote: > > > > [...] > > > > > > So for the modern systems not supporting PCI ACPI hotplug > > > we don't

<    1   2   3   4   >