Re: [Qemu-devel] patchew header docs [was: Re: [PATCH 0/6] hyperv: refactor HvSintRoute management]

2018-07-03 Thread Eric Blake
On 07/03/2018 03:00 AM, Fam Zheng wrote: On Tue, 07/03 10:47, Roman Kagan wrote: On Mon, Jul 02, 2018 at 03:55:33PM -0500, Eric Blake wrote: On 07/02/2018 11:58 AM, Roman Kagan wrote: This series modifies the management of HvSintRoute, which is an important building block in Hyper-V emulation

Re: [Qemu-devel] [PULL 0/3] Block patches

2018-07-03 Thread Peter Maydell
On 3 July 2018 at 04:46, Jeff Cody wrote: > The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into > staging (2018-07-02 17:57:46 +0100) > > are available in the Git repository at: > > git://githu

[Qemu-devel] [PATCH V2] qemu-img: align result of is_allocated_sectors

2018-07-03 Thread Peter Lieven
We currently don't enforce that the sparse segments we detect during convert are aligned. This leads to unnecessary and costly read-modify-write cycles either internally in Qemu or in the background on the storage device as nearly all modern filesystems or hardware have a 4k alignment internally.

Re: [Qemu-devel] [PATCH v6 2/2] block: Add blklogwrites

2018-07-03 Thread Kevin Wolf
Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben: > From: Aapo Vienamo > > Implements a block device write logging system, similar to Linux kernel > device mapper dm-log-writes. The write operations that are performed > on a block device are logged to a file or another block device. The > writ

[Qemu-devel] [Bug 1776478] Re: Getting qemu: uncaught target signal 6 when running lv2 plugin cross-compilation

2018-07-03 Thread Peter Maydell
You want to attach with an Arm-aware gdb to the QEMU debug stub, not connect an x86 gdb to the x86 QEMU process. On Debian/Ubuntu the gdb in the 'gdb-multiarch' package will do. Also, I gave you a wrong command line by mistake: you need "-g 1234", not "-g -" (-g wants the TCP port as an option).

Re: [Qemu-devel] [PATCH v6 09/15] qapi-introspect: add preprocessor conditions to generated QLit

2018-07-03 Thread Marc-André Lureau
Hi On Tue, Jul 3, 2018 at 2:09 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> The generator will take (obj, condition) tuples to wrap generated QLit >> objects for 'obj' with #if/#endif conditions. >> >> This commit adds 'ifcond' condition to top-level QLit objects. >> >> See gene

Re: [Qemu-devel] [RFC 5/6] hw/arm/virt: support kvm_type property

2018-07-03 Thread Suzuki K Poulose
On 03/07/18 13:47, Andrew Jones wrote: This infrastructure already is used in hw/ppc/spapr.c Whould it be better if we would pass something like kvm-type=48bGPA? Otherwise I can decode another virt machine option (min_vm_phys_shift) in kvm_type callback. Yes, this is what I'm thinking. I don't

Re: [Qemu-devel] question: disk missing in the guest contingently when hotplug several virtio scsi disks consecutively.

2018-07-03 Thread l00284672
I got a solution, the patch is below: diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 608fb18..4cdc2bb 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2184,7 +2184,9 @@ static void scsi_disk_reset(DeviceState *dev) SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev.

Re: [Qemu-devel] patchew header docs [was: Re: [PATCH 0/6] hyperv: refactor HvSintRoute management]

2018-07-03 Thread Fam Zheng
On Tue, 07/03 07:48, Eric Blake wrote: > On 07/03/2018 03:00 AM, Fam Zheng wrote: > > On Tue, 07/03 10:47, Roman Kagan wrote: > > > On Mon, Jul 02, 2018 at 03:55:33PM -0500, Eric Blake wrote: > > > > On 07/02/2018 11:58 AM, Roman Kagan wrote: > > > > > This series modifies the management of HvSintR

Re: [Qemu-devel] [PATCH 1/2] hw/net: Add support for Intel pch_gbe ethernet

2018-07-03 Thread Aleksandar Markovic
On 03.07.2018. 01:37, Philippe Mathieu-Daudé wrote: > Cc'ing Jason, the "Network devices" maintainer. > > On 02/17/2018 04:22 PM, Paul Burton wrote: >> This patch introduces support for emulating the ethernet controller >> found in the Intel EG20T Platform Controller Hub, referred to as pch_gbe >>

Re: [Qemu-devel] [PATCH 2/2] hw/mips/boston: Enable pch_gbe ethernet controller

2018-07-03 Thread Aleksandar Markovic
> Enable CONFIG_PCH_GBE_PCI in mips64el-softmmu.mak (currently the only > default config to enable Boston board support) and create the pch_gbe > device when using the Boston board. > > This provides the board with an ethernet controller matching that found > on real Boston boards as part of the In

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Add helpers to wrap generated code with #if/#endif lines. >>> >>> Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC >>> inherit from it, for full C file

Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-07-03 Thread Paolo Bonzini
On 03/07/2018 13:07, Robert Hoo wrote: >> FEAT_XSAVE_COMP_LO, /* CPUID[EAX=0xd,ECX=0].EAX */ >> FEAT_XSAVE_COMP_HI, /* CPUID[EAX=0xd,ECX=0].EDX */ >> +FEATURE_WORDS_NUM_CPUID, >> +FEATURE_WORDS_FIRST_MSR = FEATURE_WORDS_NUM_CPUID, >> +FEAT_MSR_ARCH_CAPABILITIES = FEATURE_WORDS

[Qemu-devel] [PATCH v2] module: Use QEMU_MODULE_PATH as a search path

2018-07-03 Thread ryang
The current paths for modules are CONFIG_QEMU_MODDIR and paths relative to the executable. Qemu and its modules can be installed and executed in paths that are different from these search paths. This change allows a search path to be specified by environment variable. An example usage for this is

Re: [Qemu-devel] [PULL 11/20] docker: filter out linux-user builds for mingw

2018-07-03 Thread Paolo Bonzini
On 03/07/2018 12:14, Alex Bennée wrote: > The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the > effect of defaulting all docker builds to the current configured set > of targets. This is actually reasonable behaviour but does run into > problems if you have linux-user builds confi

Re: [Qemu-devel] [PULL 00/20] Travis, Code Coverage and Cross Build updates

2018-07-03 Thread Paolo Bonzini
On 03/07/2018 12:14, Alex Bennée wrote: > The following changes since commit 46d0885adff9b99622d72f23a8b04c298a8bf91d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2018-07-03 09:49:20 +0100) > > are available in the Git repository at: > > https://github.c

Re: [Qemu-devel] [PATCH v3 00/11] NBD reconnect

2018-07-03 Thread Vladimir Sementsov-Ogievskiy
Hi all. before v4 realization, I'd like to discuss some questions. Our proposal for v4 is the following: 1. don't reconnect on nbd_open. So, on open we do only one connect attempt, and if it fails, open fails. 2. don't configure timeout between attempts. instead do the following:     1s timeo

Re: [Qemu-devel] [PATCH v6 09/15] qapi-introspect: add preprocessor conditions to generated QLit

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 3, 2018 at 2:09 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> The generator will take (obj, condition) tuples to wrap generated QLit >>> objects for 'obj' with #if/#endif conditions. >>> >>> This commit adds 'ifcond' condition to

[Qemu-devel] [PULL v3 00/25] OpenRISC updates for 3.0

2018-07-03 Thread Stafford Horne
646f34fa5482e495483de230b4cf0f2ae4fd2781: tcg: Fix --disable-tcg build breakage (2018-07-02 13:42:05 +0100) are available in the Git repository at: g...@github.com:stffrdhrn/qemu.git tags/pull-or-20180703 for you to fetch changes up to dfc84745bbaa0fea2abc8575dd349f6e4bb7edc7: target/openrisc: Fix writes to interrupt mask

Re: [Qemu-devel] [PATCH v2] module: Use QEMU_MODULE_PATH as a search path

2018-07-03 Thread Fam Zheng
On Tue, 07/03 09:38, ryang wrote: > The current paths for modules are CONFIG_QEMU_MODDIR and paths relative > to the executable. Qemu and its modules can be installed and executed in > paths that are different from these search paths. This change allows > a search path to be specified by environmen

[Qemu-devel] [PULL v3 20/25] target/openrisc: Reorg tlb lookup

2018-07-03 Thread Stafford Horne
From: Richard Henderson While openrisc has a split i/d tlb, qemu does not. Perform a lookup on both i & d tlbs in parallel and put the composite rights into qemu's tlb. This avoids ping-ponging the qemu tlb between EXEC and READ. Signed-off-by: Richard Henderson Signed-off-by: Stafford Horne

Re: [Qemu-devel] [PULL v2 00/25] OpenRISC updates for 3.0

2018-07-03 Thread Stafford Horne
On Mon, Jul 02, 2018 at 04:36:10PM +0100, Peter Maydell wrote: > On 2 July 2018 at 16:09, Stafford Horne wrote: > > Hi Peter, > > > > Changes since v1: > > - Un"fixed" an incorrect checkpatch warning pointed out by Richard. > > > > Please consider for pull. > > > > The following changes since com

Re: [Qemu-devel] [PATCH] pulseaudio: process audio data in smaller chunks

2018-07-03 Thread Philippe Mathieu-Daudé
On 07/03/2018 09:19 AM, Gerd Hoffmann wrote: > The rate of pulseaudio absorbing the audio stream is used to control the > the rate of the guests audio stream. When the emulated hardware uses > small chunks (like intel-hda does) we need small chunks on the audio > backend side too, otherwise that f

Re: [Qemu-devel] [PATCH v2 2/2] warn about two vga cards

2018-07-03 Thread Philippe Mathieu-Daudé
On 07/03/2018 03:25 AM, Gerd Hoffmann wrote: > On Mon, Jul 02, 2018 at 02:03:58PM -0300, Philippe Mathieu-Daudé wrote: >> On 07/02/2018 01:43 PM, Gerd Hoffmann wrote: >>> On Mon, Jul 02, 2018 at 06:33:45PM +0200, Gerd Hoffmann wrote: Two vga cards will try to register for the same legacy (isa)

Re: [Qemu-devel] [PATCH v6 2/2] block: Add blklogwrites

2018-07-03 Thread Ari Sundholm
On 07/03/2018 04:06 PM, Kevin Wolf wrote: Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben: From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file

Re: [Qemu-devel] [PATCH 1/2] hw/net: Add support for Intel pch_gbe ethernet

2018-07-03 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 07/03/2018 06:46 AM, Aleksandar Markovic wrote: > On 03.07.2018. 01:37, Philippe Mathieu-Daudé wrote: >> Cc'ing Jason, the "Network devices" maintainer. >> >> On 02/17/2018 04:22 PM, Paul Burton wrote: >>> This patch introduces support for emulating the ethernet controller >>> fo

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Venu Busireddy
On 2018-07-03 12:58:25 +0300, Roman Kagan wrote: > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: > > On 7/2/2018 9:14 AM, Roman Kagan wrote: > > > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > > > > The patch set "Enable virtio_net to act as a standby for a passthr

Re: [Qemu-devel] [PATCH sgabios] Makefile: Add HOSTCC

2018-07-03 Thread Cole Robinson
I probably should have added more context here... We carry this patch to sgabios in Fedora to enable cross compilation. It would be nice to get it into the qemu sgabios git repo so we don't have to track it downstream anymore Thanks, Cole On 03/25/2018 03:03 PM, Cole Robinson wrote: > From: Paol

Re: [Qemu-devel] [PATCH v6 10/15] qapi/commands: add #if conditions to commands

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Wrap generated code with #if/#endif using an 'ifcontext' on > QAPIGenCSnippet objects. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/commands.py | 21 - > tests/test-qmp-cmds.c| 5 +++-- > 2 files changed, 15 insertions(+), 11 del

Re: [Qemu-devel] [PATCH v6 11/15] qapi/events: add #if conditions to events

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Wrap generated code with #if/#endif using an 'ifcontext' on > QAPIGenCSnippet objects. > > This makes a conditional event's qapi_event_send_FOO() compile-time > conditional, but its enum QAPIEvent member remains unconditional for > now. A follow up patch "qapi-event: a

[Qemu-devel] [PATCH v7 1/2] block: Move two block permission constants to the relevant enum

2018-07-03 Thread Ari Sundholm
This allows using the two constants outside of block.c, which will happen in a subsequent patch. Signed-off-by: Ari Sundholm --- block.c | 6 -- include/block/block.h | 7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 70a46fd..96

[Qemu-devel] [PATCH v7 0/2] New block driver: blklogwrites

2018-07-03 Thread Ari Sundholm
This patch series adds a new block driver, blklogwrites, to QEMU. The driver is given two block devices: a raw device backed by an image or a host block device, and a log device, typically backed by a file, on which writes to the raw device are logged. The logging format used is the same as in the

Re: [Qemu-devel] [PATCH v6 12/15] qapi-types: add #if conditions to types & visitors

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > From: Markus Armbruster > > Types & visitors are coupled and must be handled together to avoid > temporary build regression. > > Wrap generated types/visitor code with #if/#endif using the context > helpers. I'll insert here: Derived from a patch by Marc-André. >

[Qemu-devel] [PATCH v7 2/2] block: Add blklogwrites

2018-07-03 Thread Ari Sundholm
From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file or another block device. The write log format is identical to the dm-log-writes format. Currently,

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Cornelia Huck
On Tue, 3 Jul 2018 09:28:17 -0500 Venu Busireddy wrote: > On 2018-07-03 12:58:25 +0300, Roman Kagan wrote: > > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: > > > On 7/2/2018 9:14 AM, Roman Kagan wrote: > > > > Is the scheme going to be applied/extended to other transports (vmbu

Re: [Qemu-devel] [Qemu-block] [PATCH v6 2/2] block: Add blklogwrites

2018-07-03 Thread Ari Sundholm
On 07/03/2018 05:20 PM, Ari Sundholm wrote: On 07/03/2018 04:06 PM, Kevin Wolf wrote: Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben: From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are perf

Re: [Qemu-devel] [PATCH v3 01/13] linux-user/syscall: Verify recvfrom(addr) is user-writable

2018-07-03 Thread Laurent Vivier
Le 02/07/2018 à 19:50, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Tested-By: Guido Günther > Reviewed-by: Laurent Vivier > --- > linux-user/syscall.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > inde

[Qemu-devel] [PULL 4/5] block: Move two block permission constants to the relevant enum

2018-07-03 Thread Kevin Wolf
From: Ari Sundholm This allows using the two constants outside of block.c, which will happen in a subsequent patch. Signed-off-by: Ari Sundholm Signed-off-by: Kevin Wolf --- include/block/block.h | 7 +++ block.c | 6 -- 2 files changed, 7 insertions(+), 6 deletions(-)

[Qemu-devel] [PULL 1/5] qemu-img: allow compressed not-in-order writes

2018-07-03 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy No reason to forbid them, and they are needed to improve performance with compress-threads in further patches. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- qemu-img.c | 5 - 1 file changed, 5 deletions(-) diff --git a/qemu-i

[Qemu-devel] [PULL 0/5] Block layer patches

2018-07-03 Thread Kevin Wolf
The following changes since commit a395717cbd26e7593d3c3fe81faca121ec6d13e8: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-07-03 11:49:51 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fet

Re: [Qemu-devel] [PATCH v6 13/15] qapi: add 'If:' section to generated documentation

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > The documentation is generated only once, and doesn't know C > pre-conditions. Add 'If:' sections for top-level entities. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/doc.py | 22 -- > tests/qapi-schema/doc-good.json | 2

[Qemu-devel] [PULL 3/5] qcow2: add compress threads

2018-07-03 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Do data compression in separate threads. This significantly improve performance for qemu-img convert with -W (allow async writes) and -c (compressed) options. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- block/qcow2.h | 3 +++ b

[Qemu-devel] [PULL 5/5] block: Add blklogwrites

2018-07-03 Thread Kevin Wolf
From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file or another block device. The write log format is identical to the dm-log-writes format. Currently,

Re: [Qemu-devel] [PULL 00/35] ppc-for-3.0 queue 20180703

2018-07-03 Thread Peter Maydell
Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-3.0-20180703 > > for you to fetch changes up to 29f9cef39eb1ae55e82c6763eb22d7a1bdff7276: > > ppc: Include vga cirrus card into the compiling process (2018-07-03 > 11:23:09 +1000) > > ---

Re: [Qemu-devel] [PATCH v6 15/15] qapi: add conditions to SPICE type/commands/events on the schema

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Add #if defined(CONFIG_SPICE) in generated code, and adjust the > qmp/hmp code accordingly. > > query-qmp-schema no longer reports the command/events etc as > available when disabled at compile time. > > Commands made conditional: > > * query-spice > > Before the pat

Re: [Qemu-devel] [PATCH v6 14/15] qapi: add conditions to VNC type/commands/events on the schema

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Add #if defined(CONFIG_VNC) in generated code, and adjust the > qmp/hmp code accordingly. > > query-qmp-schema no longer reports the command/events etc as > available when disabled at compile. > > Commands made conditional: > > * query-vnc, query-vnc-servers, change-vn

[Qemu-devel] [PULL 2/5] qcow2: refactor data compression

2018-07-03 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Make a separate function for compression to be parallelized later. - use .avail_out field instead of .next_out to calculate size of compressed data. It looks more natural and it allows to keep dest to be void pointer - set avail_out to be at least one by

Re: [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12

2018-07-03 Thread Igor Mammedov
On Mon, 2 Jul 2018 22:10:26 -0300 Eduardo Habkost wrote: > I forgot a hyphen when amending the compat code on commit > e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU"). > > Fixes: e00516475c270dcb6705753da96063f95699abf2 > Signed-off-by: Eduardo Habkost > --- > Bug detected by compat_

Re: [Qemu-devel] [PATCH v6 09/15] qapi-introspect: add preprocessor conditions to generated QLit

2018-07-03 Thread Markus Armbruster
Markus Armbruster writes: [...] > Let's add a hint to the commit message. Pergaps: > > qapi-introspect: add preprocessor conditions to generated QLit > > This commit adds 'ifcond' conditions to top-level QLit objects. > Future work will add them to object and enum type members, i.e.

Re: [Qemu-devel] [PATCH v7 0/2] New block driver: blklogwrites

2018-07-03 Thread Kevin Wolf
Am 03.07.2018 um 16:48 hat Ari Sundholm geschrieben: > This patch series adds a new block driver, blklogwrites, to QEMU. The > driver is given two block devices: a raw device backed by an image or a > host block device, and a log device, typically backed by a file, on > which writes to the raw devi

Re: [Qemu-devel] [PATCH v6 10/15] qapi/commands: add #if conditions to commands

2018-07-03 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Wrap generated code with #if/#endif using an 'ifcontext' on >> QAPIGenCSnippet objects. >> >> Signed-off-by: Marc-André Lureau >> --- >> scripts/qapi/commands.py | 21 - >> tests/test-qmp-cmds.c| 5 +++-- >> 2

Re: [Qemu-devel] [PULL 5/5] block: Add blklogwrites

2018-07-03 Thread Kevin Wolf
Am 03.07.2018 um 16:59 hat Kevin Wolf geschrieben: > From: Aapo Vienamo > > Implements a block device write logging system, similar to Linux kernel > device mapper dm-log-writes. The write operations that are performed > on a block device are logged to a file or another block device. The > write

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-03 Thread Peng Tao
On Tue, Jul 3, 2018 at 6:05 PM, Stefan Hajnoczi wrote: > On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: >> On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote: >> > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangshan wrote: >> > Risks: >> > 1. If one cloned VM is exploited then a

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Marc-André Lureau
Hi On Tue, Jul 3, 2018 at 3:37 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: >>> Marc-André Lureau writes: >>> Add helpers to wrap generated code with #if/#endif lines. Add QAPIGenCSnippet class to

[Qemu-devel] [PATCH 1/7] target/ppc: Enable fp exceptions for user-only

2018-07-03 Thread Richard Henderson
While just setting the MSR bits is sufficient, we can tidy the helper code by extracting the MSR test to a helper and then forcing it true for user-only. Signed-off-by: Richard Henderson --- target/ppc/fpu_helper.c | 15 --- target/ppc/translate_init.inc.c | 2 ++ 2 files ch

[Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-03 Thread Richard Henderson
Beginning with John Arbuckle's fdiv test case, clean up some of the fp helpers. As with fdiv, fre and fresqrt are missing divide-by-zero exceptions. I've also noticed that load/store were using arithmetic conversions to/from float32. These should be using the non-arithmetic algorithms listed in

[Qemu-devel] [PATCH 7/7] target/ppc: Use non-arithmetic conversions for fp load/store

2018-07-03 Thread Richard Henderson
Memory operations have no side effects on fp state. The use of a "real" conversions between float64 and float32 would raise exceptions for SNaN and out-of-range inputs. Signed-off-by: Richard Henderson --- target/ppc/helper.h| 4 +- target/ppc/fpu_helper.c| 63 ++

[Qemu-devel] [PATCH 3/7] target/ppc: Tidy helper_fmul

2018-07-03 Thread Richard Henderson
Tidy the invalid exception checking so that we rely on softfloat for initial argument validation, and select the kind of invalid operand exception only when we know we must. Pass and return float64 values directly rather than bounce through the CPU_DoubleU union. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 2/7] target/ppc: Honor fpscr_ze semantics and tidy fdiv

2018-07-03 Thread Richard Henderson
Divide by zero, exception taken, leaves the destination register unmodified. Therefore we must raise the exception before returning from helper_fdiv. Move the check from do_float_check_status into helper_fdiv. At the same time, tidy the invalid exception checking so that we rely on softfloat for

Re: [Qemu-devel] [PATCH v3 1/3] spapr: introduce a fixed IRQ number space

2018-07-03 Thread Cédric Le Goater
On 07/02/2018 01:11 PM, Cédric Le Goater wrote: > On 07/02/2018 12:03 PM, Cédric Le Goater wrote: >>> --- a/hw/ppc/spapr_vio.c >>> +++ b/hw/ppc/spapr_vio.c >>> @@ -436,6 +436,9 @@ static void spapr_vio_busdev_reset(DeviceState *qdev) >>> } >>> } >>> >>> +/* TODO : poor VIO device indexing .

[Qemu-devel] [PATCH 5/7] target/ppc: Tidy helper_fsqrt

2018-07-03 Thread Richard Henderson
Tidy the invalid exception checking so that we rely on softfloat for initial argument validation, and select the kind of invalid operand exception only when we know we must. Pass and return float64 values directly rather than bounce through the CPU_DoubleU union. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 6/7] target/ppc: Honor fpscr_ze semantics and tidy fre, fresqrt

2018-07-03 Thread Richard Henderson
Divide by zero, exception taken, leaves the destination register unmodified. Therefore we must raise the exception before returning from the respective helpers. >From helper_fre, divide by zero exception not taken, return the documented +/- 0.5. At the same time, tidy the invalid exception check

[Qemu-devel] [PATCH for-3.0] spapr/vio: quiet down the "irq" property accessors

2018-07-03 Thread Cédric Le Goater
commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property") introduced get/set accessors for the "irq" property to warn of its usage, but the warning in the get pollutes the monitor 'info qtree'. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_vio.c | 15 --- 1 file changed, 12

[Qemu-devel] [PATCH 4/7] target/ppc: Tidy helper_fadd, helper_fsub

2018-07-03 Thread Richard Henderson
Tidy the invalid exception checking so that we rely on softfloat for initial argument validation, and select the kind of invalid operand exception only when we know we must. Pass and return float64 values directly rather than bounce through the CPU_DoubleU union. Note that because we know float_f

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-07-03 Thread Eric Blake
On 07/02/2018 11:41 PM, David Gibson wrote: That's a good point. At the moment there's really nothing there about testing your patch before submission, which is a bit of an ommission. [1] covers a bunch of ways that qemu can be tested, but doesn't give much idea about priority. +eblake, you s

Re: [Qemu-devel] [PATCH v4 2/2] iotests: add 222 to test basic fleecing

2018-07-03 Thread John Snow
On 07/03/2018 05:15 AM, Vladimir Sementsov-Ogievskiy wrote: > 02.07.2018 22:46, John Snow wrote: >> Signed-off-by: John Snow > > > Reviewed-by: Vladimir Sementsov-Ogievskiy > Thanks, and sorry for the 3.0 freeze rush.

Re: [Qemu-devel] [PATCH v2 03/32] docs/interop/qmp: Improve OOB documentation

2018-07-03 Thread Eric Blake
On 07/03/2018 03:53 AM, Markus Armbruster wrote: OOB documentation is spread over qmp-spec.txt sections 2.2.1 Capabilities and 2.3 Issuing Commands. The amount of detail is a bit distracting there. Move the meat of the matter to new section 2.3.1 Out of band execution. Throw in a few other imp

[Qemu-devel] [PATCH v4 01/12] linux-user/syscall: Verify recvfrom(addr) is user-writable

2018-07-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2117fb13b4..ad40682cee 100644 --- a/linux-user/syscall.c +++ b/linux-use

[Qemu-devel] [PATCH v4 00/12] linux-user: strace improvements

2018-07-03 Thread Philippe Mathieu-Daudé
Hi Laurent, Few patches I'v been writting while trying to figure out this issue: http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html As usual with linux-user files, this series will trigger some checkpatch benign warnings. Regards, Phil. Since v3: - addressed Laurent comments -

[Qemu-devel] [PATCH v4 05/12] linux-user/strace: Improve settimeofday()

2018-07-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier --- linux-user/strace.c| 13 + linux-user/strace.list | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index d51e4b6c00..d1

[Qemu-devel] [PATCH v4 02/12] linux-user/strace: Improve capget()/capset() output

2018-07-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier --- linux-user/strace.list | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.list b/linux-user/strace.list index 2bc5ba04d4..afe4db07f3 100644 --- a/linux-user/stra

[Qemu-devel] [PATCH v4 09/12] linux-user/strace: Add print_sockfd()

2018-07-03 Thread Philippe Mathieu-Daudé
Extract common print_sockfd() from various socket related syscalls. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 48ba715557..54060eed93 100644

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 3, 2018 at 3:37 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi >>> >>> On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: Marc-André Lureau writes: > Add helpers to wrap generated code with #if/#endif line

[Qemu-devel] [PULL 06/32] tests/qmp-test: Test in-band command doesn't overtake

2018-07-03 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20180703085358.13941-7-arm...@redhat.com> --- tests/qmp-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qmp-test.c b/tests/qmp-test.c index 6dd331fcdd..d73730945a 100644 --- a/tests/qmp-test.c +++ b/tests/qm

[Qemu-devel] [PATCH v4 06/12] linux-user/syscall: Introduce target_sockaddr_nl

2018-07-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther --- linux-user/syscall_defs.h | 7 +++ linux-user/syscall.c | 6 -- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 40bb60ef4c..5a0b76721f 10064

[Qemu-devel] [PATCH v4 08/12] linux-user/strace: Improve recvmsg() output

2018-07-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier --- linux-user/strace.list | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.list b/linux-user/strace.list index 90cf7e338a..31093c3371 100644 --- a/linux-user/strace.l

[Qemu-devel] [PATCH] docker: Update debootstrap script after Debian migration from Alioth to Salsa

2018-07-03 Thread Philippe Mathieu-Daudé
This silents the following warning: Cloning into './debootstrap.git'... warning: redirecting to https://salsa.debian.org/installer-team/debootstrap.git/ See https://lists.debian.org/debian-devel-announce/2018/01/msg4.html Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfi

<    1   2   3   4   5