[Qemu-devel] [PATCH v4 2/4] linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI

2019-03-29 Thread Richard Henderson
There is agreement that there will be a mmap/mprotect bit, although no word yet on the value or the name. Invent a name to make forward progress. The PAGE_TARGET_1 bit, is qemu internal, and allows the target something to query from the guest page tables. Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH for 4.1 v2 0/6] RISC-V: Allow specifying CPU ISA via command line

2019-03-29 Thread Alistair Francis
This patch series adds a generic RISC-V CPU that can be generated at run time based on the ISA string specified to QEMU via the -cpu argument. This is supported on the virt and spike boards allowing users to specify the RISC-V extensions as well as the ISA version. As part of the conversion we

[Qemu-devel] [PATCH v4 4/4] tests/tcg/aarch64: Add bti smoke test

2019-03-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/aarch64/bti-1.c | 62 +++ tests/tcg/aarch64/bti-crt.inc.c | 69 +++ tests/tcg/aarch64/Makefile.target | 3 ++ 3 files changed, 134 insertions(+) create mode 100644

Re: [Qemu-devel] [PATCH for-4.1 v2 21/36] target/riscv: Use env_cpu, env_archcpu

2019-03-29 Thread Alistair Francis
On Thu, Mar 28, 2019 at 4:30 PM Richard Henderson wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 5 - > linux-user/riscv/cpu_loop.c | 2 +- > target/riscv/cpu_helper.c | 4 ++-- > target/riscv/csr.c

[Qemu-devel] [PATCH 3/5] tests/vm: Detect the image changed on server

2019-03-29 Thread Wainer dos Santos Moschetta
The current implementation of basevm does not check if the image file to be downloaded has changed on server side before honouring the cache. So any change on server-side file can go unnoticed, keeping the cached image. This change implements a simple mechanism to detect the image file changed by

[Qemu-devel] [PATCH 2/5] tests/vm: Port basevm to Python 3

2019-03-29 Thread Wainer dos Santos Moschetta
Fixed tests/vm/basevm.py to run with Python 3: - hashlib.sha1() requires an binary encoded object. - uses floor division ("//") (PEP 238). - decode bytes to unicode when needed. Signed-off-by: Wainer dos Santos Moschetta --- tests/vm/basevm.py | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PATCH for 4.1 v2 5/6] target/riscv: Remove the generic no MMU CPUs

2019-03-29 Thread Alistair Francis
These can now be specified via the command line so we no longer need these. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 2 -- target/riscv/cpu.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index b6408e0a83..758201331c 100644 ---

[Qemu-devel] [PATCH 0/5] tests/vm: Python 3, improve image caching, and misc

2019-03-29 Thread Wainer dos Santos Moschetta
Hi all! This series bundles the support to Python3, improvement to image caching, and miscellaneous changes for the vm-test (`make vm-build-*`). Git tree: http://github.com/wainersm/qemu Branch: vm_test_python3_and_misc Travis: https://travis-ci.org/wainersm/qemu/builds/513220300 Below you can

Re: [Qemu-devel] [PATCH v4 0/4] target/arm: Implement ARMv8.5-BTI for linux-user

2019-03-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190330005900.17282-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190330005900.17282-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v4 0/4]

Re: [Qemu-devel] [PATCH 1/2] vl: Fix to create accel compat props before migration object again

2019-03-29 Thread Igor Mammedov
On Wed, 27 Mar 2019 16:03:46 +0100 Markus Armbruster wrote: > Recent commit cda4aa9a5a0 moved block backend creation before machine > property evaluation. This broke block backends registering migration > blockers. Commit e60483f2f84 fixed it by moving migration object > creation before block

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Peter Krempa
On Fri, Mar 29, 2019 at 14:05:46 +0100, Markus Armbruster wrote: > Peter Krempa writes: > > [...] > > Whether there is a static entry in the QMP schema (which feels wrong > > btw as it does not actually expose something which is regarding the > > interaction with QMP) or something like this, we

[Qemu-devel] [PATCH 0/3] block/stream: get rid of the base

2019-03-29 Thread Andrey Shinkevich
This series introduces a bottom intermediate node that eliminates the dependency on the base that may change while stream job is running. It happens when stream/commit parallel jobs are running on the same backing chain. The base node of the stream job may be a top node of the parallel commit job

[Qemu-devel] [PATCH 2/3] block/stream: refactor stream_run: drop goto

2019-03-29 Thread Andrey Shinkevich
Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/stream.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/block/stream.c b/block/stream.c index 6253c86..c065e99 100644 --- a/block/stream.c +++ b/block/stream.c @@ -122,13

[Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-03-29 Thread Andrey Shinkevich
The bottom node is the intermediate block device that has the base as its backing image. It is used instead of the base node while a block stream job is running to avoid dependency on the base that may change due to the parallel jobs. The change may take place due to a filter node as well that is

[Qemu-devel] [PATCH 1/3] block: include base when checking image chain for block allocation

2019-03-29 Thread Andrey Shinkevich
A caller of the function bdrv_is_allocated_above() may want to include the base node in the search. It is useful when we have parallel commit/stream jobs on the same backing image chain. The base node may be a top one of a parallel job at the same time and go away before the first job completed.

Re: [Qemu-devel] [PATCH for-4.0] spapr: Simplify handling of host-serial and host-model values

2019-03-29 Thread Greg Kurz
On Fri, 29 Mar 2019 10:28:46 +1100 David Gibson wrote: > On Thu, Mar 28, 2019 at 01:56:48PM +0100, Greg Kurz wrote: > > On Thu, 28 Mar 2019 15:40:25 +1100 > > David Gibson wrote: > > > > > 27461d69a0f "ppc: add host-serial and host-model machine attributes > > > (CVE-2019-8934)" introduced

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Auger Eric
Hi Shameer, On 3/29/19 10:41 AM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 29 March 2019 09:32 >> To: Shameerali Kolothum Thodi ; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; >>

Re: [Qemu-devel] [PATCH v3 6/6] nbd/server: Advertise actual minimum block size

2019-03-29 Thread Eric Blake
On 3/28/19 11:27 PM, Eric Blake wrote: > Both NBD_CMD_BLOCK_STATUS and structured NBD_CMD_READ will split their > reply according to bdrv_block_status() boundaries. If the block device > has a request_alignment smaller than 512, but we advertise a block > alignment of 512 to the client, then this

Re: [Qemu-devel] [PATCH v3 09/10] hw/acpi: Add ACPI Generic Event Device Support

2019-03-29 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 29 March 2019 13:09 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com;

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-29 Thread Peter Maydell
On Fri, 29 Mar 2019 at 13:13, Stefano Garzarella wrote: > > On Thu, Mar 28, 2019 at 03:26:35PM +, Peter Maydell wrote: > > In the stripe8() function we use a variable length array; however > > we know that the maximum length required is MAX_NUM_BUSSES. Use > > a fixed-length array and an

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-29 Thread Markus Armbruster
Eric Blake writes: > On 3/28/19 1:28 PM, Kevin Wolf wrote: >> From: Stefan Hajnoczi >> >> QMP clients can usually detect the presence of features via schema >> introspection. There are rare features that do not involve schema >> changes and are therefore impossible to detect with schema >>

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-03-29 Thread Thomas Huth
On 29/03/2019 12.11, Daniel P. Berrangé wrote: > The GCC 9 compiler complains about many places in s390 code > that take the address of members of the 'struct SCHIB' which > is marked packed: > > hw/vfio/ccw.c: In function ‘vfio_ccw_io_notifier_handler’: > hw/vfio/ccw.c:133:15: warning: taking

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Auger Eric
Hi Ard, On 3/29/19 2:14 PM, Ard Biesheuvel wrote: > On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote: >> >> Hi Shameer, >> >> On 3/29/19 10:59 AM, Shameerali Kolothum Thodi wrote: >>> >>> -Original Message- From: Auger Eric [mailto:eric.au...@redhat.com] Sent: 29 March 2019

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Markus Armbruster
Pavel Hrdina writes: > On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote: >> Pavel Hrdina writes: >> >> > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >> > On 3/28/19 3:06 PM, Eric Blake wrote: >> >> >> On 3/28/19 2:32

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-29 Thread Greg Kurz
On Thu, 28 Mar 2019 15:39:45 -0300 "Maxiwell S. Garcia" wrote: > Hi, > > On Thu, Mar 28, 2019 at 02:21:51PM +0100, Greg Kurz wrote: > > On Wed, 27 Mar 2019 17:41:00 -0300 > > "Maxiwell S. Garcia" wrote: > > > > > Here are two patches to add a handler for ibm,get-vpd RTAS calls. > > > This

Re: [Qemu-devel] [Qemu-ppc] [PULL 4/8] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

2019-03-29 Thread Greg Kurz
On Fri, 29 Mar 2019 21:01:04 +1100 David Gibson wrote: > On Fri, Mar 29, 2019 at 10:37:08AM +0100, BALATON Zoltan wrote: > > On Fri, 29 Mar 2019, David Gibson wrote: > > > From: Greg Kurz > > > > > > Signed-off-by: Greg Kurz > > > Message-Id:

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 12:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's avoid such

Re: [Qemu-devel] [PATCH] Fix 32-bit compilation with gcc 5.5

2019-03-29 Thread Andrew Randrianasulu
В сообщении от Friday 29 March 2019 11:40:42 Alex Bennée написал(а): > > Andrew Randrianasulu writes: > > > --- > > ui/curses.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ui/curses.c b/ui/curses.c > > index cc6d6da684..b25814f3fb 100644 > > --- a/ui/curses.c

Re: [Qemu-devel] [PATCH v2 for-4.1] hw/arm/raspi: Diagnose requests for too much RAM

2019-03-29 Thread Wainer dos Santos Moschetta
On 03/29/2019 06:20 AM, Peter Maydell wrote: On Thu, 28 Mar 2019 at 21:29, Wainer dos Santos Moschetta wrote: On 03/28/2019 12:29 PM, Peter Maydell wrote: The Raspberry Pi boards have a physical memory map which does not allow for more than 1GB of RAM. Currently if the user tries to ask

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Peter Krempa writes: [...] > Whether there is a static entry in the QMP schema (which feels wrong > btw as it does not actually expose something which is regarding the > interaction with QMP) or something like this, we need it yesterday. I > don't want to add version checks any more. I do

Re: [Qemu-devel] [PATCH v3 09/10] hw/acpi: Add ACPI Generic Event Device Support

2019-03-29 Thread Auger Eric
Hi Shameer, On 3/21/19 11:47 AM, Shameer Kolothum wrote: > From: Samuel Ortiz > > The ACPI Generic Event Device (GED) is a hardware-reduced specific > device that handles all platform events, including the hotplug ones. > This patch generates the AML code that defines GEDs. > > Platforms need

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Auger Eric
Hi Shameer, On 3/29/19 10:59 AM, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 29 March 2019 09:32 >> To: Shameerali Kolothum Thodi ; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; >>

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-29 Thread Stefano Garzarella
On Thu, Mar 28, 2019 at 03:26:35PM +, Peter Maydell wrote: > In the stripe8() function we use a variable length array; however > we know that the maximum length required is MAX_NUM_BUSSES. Use > a fixed-length array and an assert instead. > > Signed-off-by: Peter Maydell > --- >

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Ard Biesheuvel
On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote: > > Hi Shameer, > > On 3/29/19 10:59 AM, Shameerali Kolothum Thodi wrote: > > > > > >> -Original Message- > >> From: Auger Eric [mailto:eric.au...@redhat.com] > >> Sent: 29 March 2019 09:32 > >> To: Shameerali Kolothum Thodi ; > >>

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> auto-read-only=on changed its behaviour in file-posix for the 4.0 >> release. > > Commit hash, please. I guess it's commit 23dece19da4 "file-posix: Make auto-read-only dynamic". >> This change cannot be detected through the usual

Re: [Qemu-devel] [PATCH for-4.0 v2 0/3] freeze the backing chain earlier in stream_start()

2019-03-29 Thread Kevin Wolf
Am 28.03.2019 um 17:25 hat Alberto Garcia geschrieben: > Hi, > > this series fixes the bug that I found the other day and described here: > >https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00764.html >https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00791.html > > Patch

[Qemu-devel] [PATCH v2 1/2] intel_iommu: Fix root_scalable migration breakage

2019-03-29 Thread Peter Xu
When introducing the initial support for scalable mode we added a new field into vmstate however we blindly migrate that field without notice. That'll break migration no matter forward or backward. The normal way should be that we use something like VMSTATE_UINT32_TEST() or subsections for the

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Drop extended root field

2019-03-29 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, March 29, 2019 2:14 PM > To: qemu-devel@nongnu.org > Subject: [PATCH v2 2/2] intel_iommu: Drop extended root field > > VTD_RTADDR_RTT is dropped even by the VT-d spec, so QEMU should May be helpful to mention it is VT-d 3.0 which

[Qemu-devel] [PATCH] Fix 32-bit compilation with gcc 5.5

2019-03-29 Thread Andrew Randrianasulu
--- ui/curses.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/curses.c b/ui/curses.c index cc6d6da684..b25814f3fb 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -453,7 +453,7 @@ static uint16_t get_ucs(wchar_t wch, iconv_t conv) swch = sizeof(wch); if

[Qemu-devel] [PULL 2/4] e1000: Delay flush queue when receive RCTL

2019-03-29 Thread Jason Wang
From: yuchenlin Due to too early RCT0 interrput, win10x32 may hang on booting. This problem can be reproduced by doing power cycle on win10x32 guest. In our environment, we have 10 win10x32 and stress power cycle. The problem will happen about 20 rounds. Below shows some log with comment: The

[Qemu-devel] [PULL 0/4] Net patches

2019-03-29 Thread Jason Wang
The following changes since commit a04d91c701251a9b32b7364ddb48029ba024cb75: Merge remote-tracking branch 'remotes/alistair/tags/pull-device-tree-20190327' into staging (2019-03-28 12:39:43 +) are available in the git repository at: https://github.com/jasowang/qemu.git

[Qemu-devel] [PATCH v3 0/5] Add support for MSA instructions on a big endian host

2019-03-29 Thread Mateja Marjanovic
From: Mateja Marjanovic Add support for MSA instructions while executing QEMU on a machine that uses big endian MIPS CPU. Also change the implementation of helpers for MSA instructions ST., LD., INSERT. (and D on MIPS64), COPY_S. (and D on MIPS64) and COPY_U. (and W on MIPS64). Instead of using

[Qemu-devel] [PULL 1/4] net/socket: learn to talk with a unix dgram socket

2019-03-29 Thread Jason Wang
From: Marc-André Lureau -net socket has a fd argument, and may be passed pre-opened sockets. TCP sockets use framing. UDP sockets have datagram boundaries. When given a unix dgram socket, it will be able to read from it, but will attempt to send on the dgram_dst, which is unset. The other end

[Qemu-devel] [PULL 3/4] MAINTAINERS: Update the latest email address

2019-03-29 Thread Jason Wang
From: Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c2ad506..56139ac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2179,7 +2179,7 @@ F:

[Qemu-devel] [PULL 4/4] net: tap: use qemu_set_nonblock

2019-03-29 Thread Jason Wang
From: Li Qiang The fcntl will change the flags directly, use qemu_set_nonblock() instead. Reviewed-by: Daniel P. Berrangé Acked-by: Michael S. Tsirkin Signed-off-by: Li Qiang Signed-off-by: Jason Wang --- net/tap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-29 Thread David Hildenbrand
>> Problem David tries to solve is that > > Uh, which David? I assume he was referring to you :) > >> 1: user hotplugged backend with wrong page size >> 2: hotplug of associated device 'pc-dimm' cleanly fails with error >> 3: guest does reboot and QEMU crashes with fatal error >> >> Issue

Re: [Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-29 Thread Kevin Wolf
Am 28.03.2019 um 19:27 hat Eric Blake geschrieben: > On 3/28/19 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: > > 28.03.2019 1:39, Eric Blake wrote: > >> Add a test for the NBD client workaround in the previous patch. It's > >> not really feasible for an iotest to assume a specific tracing engine,

Re: [Qemu-devel] [PATCH v2 2/2] exec: Introduce qemu_getmaxrampagesize() and rename qemu_getrampagesize()

2019-03-29 Thread David Hildenbrand
>> --- >> exec.c | 39 ++ >> hw/ppc/spapr_caps.c| 4 ++-- >> hw/s390x/s390-virtio-ccw.c | 2 +- >> hw/vfio/spapr.c| 2 +- >> target/ppc/kvm.c | 2 +- >> 5 files changed, 40 insertions(+), 9 deletions(-) >>

Re: [Qemu-devel] [PATCH] Fix 32-bit compilation with gcc 5.5

2019-03-29 Thread Alex Bennée
Andrew Randrianasulu writes: > --- > ui/curses.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/curses.c b/ui/curses.c > index cc6d6da684..b25814f3fb 100644 > --- a/ui/curses.c > +++ b/ui/curses.c > @@ -453,7 +453,7 @@ static uint16_t get_ucs(wchar_t wch, iconv_t

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update the latest email address

2019-03-29 Thread Zhang, Chen
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Friday, March 29, 2019 3:02 PM > To: Zhang, Chen ; Li Zhijian ; > Zhang Chen ; Dr. David Alan Gilbert > ; Juan Quintela ; zhanghailiang > ; Peter Maydell > ; qemu-dev > Subject: Re: [PATCH] MAINTAINERS: Update

[Qemu-devel] [PATCH v3 4/5] target/mips: Different approach toward COPY_U MSA instr. and big endian fix

2019-03-29 Thread Mateja Marjanovic
From: Mateja Marjanovic The old version of the helper for the COPY_U. MSA instructions has been replaced with a four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic --- target/mips/helper.h |

[Qemu-devel] [PATCH v3 3/5] target/mips: Different approach toward COPY_S MSA instr. and big endian fix

2019-03-29 Thread Mateja Marjanovic
From: Mateja Marjanovic The old version of the helper for the COPY_S. MSA instructions has been replaced with a four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic --- target/mips/helper.h |

[Qemu-devel] [PATCH v3 2/5] target/mips: MSA instructions st, big endian host fix

2019-03-29 Thread Mateja Marjanovic
From: Mateja Marjanovic Fix the case when the host is running on a big endian machine, and change the approach toward st instruction helpers. Signed-off-by: Mateja Marjanovic --- target/mips/op_helper.c | 188 ++-- 1 file changed, 168 insertions(+),

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Peter Krempa
On Fri, Mar 29, 2019 at 08:52:13 +0100, Kevin Wolf wrote: > Am 28.03.2019 um 19:45 hat Eric Blake geschrieben: > > On 3/28/19 1:28 PM, Kevin Wolf wrote: > > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > > release. This change cannot be detected through the usual

[Qemu-devel] [PATCH v2 2/2] intel_iommu: Drop extended root field

2019-03-29 Thread Peter Xu
VTD_RTADDR_RTT is dropped even by the VT-d spec, so QEMU should probably do the same thing (after all we never really implemented it). Since we've had a field for that in the migration stream, to keep compatibility we need to fill the hole up. Please refer to VT-d spec 10.4.6. Signed-off-by:

Re: [Qemu-devel] [PATCH] Fix 32-bit compilation with gcc 5.5

2019-03-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190329064853.22886-1-randrianas...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190329064853.22886-1-randrianas...@gmail.com Subject: [Qemu-devel] [PATCH] Fix 32-bit

Re: [Qemu-devel] [PATCH] Fix 32-bit compilation with gcc 5.5

2019-03-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190329064853.22886-1-randrianas...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-29 Thread David Hildenbrand
>> Once we support 2GB pages, we'll might have think about what you >> describe here, depending on what the KVM interface promises us. If the >> interfaces promises "If 2GB are enabled, 1MB are enabled implicitly", we >> are fine, otherwise we would have to check per mapped backend. > > I guess.

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Kevin Wolf
Am 28.03.2019 um 19:45 hat Eric Blake geschrieben: > On 3/28/19 1:28 PM, Kevin Wolf wrote: > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > release. This change cannot be detected through the usual mechanisms > > like schema introspection. Add a new feature to

[Qemu-devel] [Bug 1569053] Re: Qemu crashes when I start a second VM from command line

2019-03-29 Thread Thomas Huth
Can you still reproduce the problem with the latest upstream version of QEMU and the latest version of the upstream Linux kernel? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 15/15] s390-bios: Support booting from real dasd device

2019-03-29 Thread Thomas Huth
On 13/03/2019 17.31, Jason J. Herne wrote: > Allows guest to boot from a vfio configured real dasd device. > > Signed-off-by: Jason J. Herne > Reviewed-by: Cornelia Huck > --- [...] > diff --git a/docs/devel/s390-dasd-ipl.txt b/docs/devel/s390-dasd-ipl.txt > new file mode 100644 > index

Re: [Qemu-devel] [PATCH] hw/i2c/smbus_ich9: Fix the confusing contributions-after-2012 statement

2019-03-29 Thread Thomas Huth
On 06/02/2019 17.43, Thomas Huth wrote: > The license information in this file is rather confusing. The text > declares LGPL first, but then says that contributions after Jan 2012 > are licensed under the GPL instead. How should the average user who > just downloaded the release tarball know which

[Qemu-devel] [PATCH v2 0/2] intel_iommu: misc scalable mode fixes for 4.0

2019-03-29 Thread Peter Xu
v2: - patch 2: use "1" instead of "sizeof(bool)" for VMSTATE_UNUSED because sizeof(bool) can be >1 depends on definition [Dave] The first patch is the important one. It should fix up a migration issue that Dave reported between 3.1<->4.0. The second patch is born only because I noticed it

[Qemu-devel] [Bug 1542965] Re: Failed to set NBD socket ubuntu 15.10 & nbd client 3.10

2019-03-29 Thread Thomas Huth
Can you still reproduce this with the latest version of upstream QEMU? Please also provide the exact steps (e.g. command line options) that you were using here. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update the latest email address

2019-03-29 Thread Jason Wang
On 2019/3/29 上午11:03, Zhang, Chen wrote: Ping... May need to wait until the 4.1 version? Thanks Zhang Chen No need, I will queue this patch. Thanks -Original Message- From: Zhang, Chen Sent: Friday, March 15, 2019 2:13 PM To: Li Zhijian ; Zhang Chen ; Dr. David Alan Gilbert ;

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Markus Armbruster
Eric Blake writes: > On 3/28/19 3:06 PM, Eric Blake wrote: >> On 3/28/19 2:32 PM, Markus Armbruster wrote: >>> Markus Armbruster writes: Pavel Hrdina writes: >> > I'm glad that this is merged now and I wanted to start working on > libvirt patches, but there is one big issue with

[Qemu-devel] [PATCH v3 5/5] target/mips: Different approach toward INSERT MSA instr. and big endian fix

2019-03-29 Thread Mateja Marjanovic
From: Mateja Marjanovic The old version of the helper for the INSERT. MSA instructions has been replaced with a four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic --- target/mips/helper.h |

[Qemu-devel] [PATCH v3 1/5] target/mips: MSA instructions ld, big endian host fix

2019-03-29 Thread Mateja Marjanovic
From: Mateja Marjanovic Fix the case when the host is running on a big endian machine, and change the approach toward ld instruction helpers. Signed-off-by: Mateja Marjanovic --- target/mips/op_helper.c | 188 ++-- 1 file changed, 168 insertions(+),

Re: [Qemu-devel] [PATCH] tests/qemu-iotests: Remove redundant COPYING file

2019-03-29 Thread Thomas Huth
On 27/02/2019 14.42, Max Reitz wrote: > On 05.02.19 15:49, Thomas Huth wrote: >> The file tests/qemu-iotests/COPYING is the same text as in the >> COPYING file in the main directory. So as far as I can see, we don't >> need the duplicate here. >> >> Signed-off-by: Thomas Huth >> --- >>

[Qemu-devel] [PATCH 4/9] cpu/topology: add ARM support for smp machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- hw/arm/fsl-imx6.c | 5 + hw/arm/fsl-imx6ul.c| 5 + hw/arm/fsl-imx7.c | 5 + hw/arm/highbank.c | 1 + hw/arm/mcimx6ul-evk.c | 1 + hw/arm/mcimx7d-sabre.c | 3 +++ hw/arm/raspi.c | 2 ++ hw/arm/realview.c | 1 +

[Qemu-devel] [PATCH 1/9] cpu/topology: add struct CpuTopology to MachineState

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- include/hw/arm/virt.h | 2 +- include/hw/boards.h | 8 include/sysemu/sysemu.h | 2 +- vl.c| 7 ++- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index

[Qemu-devel] [PATCH 8/9] cpu/topology: add s390x support for smp machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- hw/s390x/s390-virtio-ccw.c | 2 ++ hw/s390x/sclp.c | 1 + target/openrisc/sys_helper.c | 5 + target/s390x/cpu.c | 3 +++ target/s390x/excp_helper.c | 6 ++ 5 files changed, 17 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c

[Qemu-devel] [PATCH 5/9] cpu/topology: add i386 support for smp machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- hw/i386/acpi-build.c | 3 +++ hw/i386/kvmvapic.c | 5 + hw/i386/pc.c | 12 target/i386/cpu.c| 4 4 files changed, 24 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 416da31..3813c28 100644 ---

Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties

2019-03-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1553849325-44201-1-git-send-email-like...@linux.intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH 1/9] cpu/topology: add struct CpuTopology to MachineState

2019-03-29 Thread Alex Bennée
Like Xu writes: > Signed-off-by: Like Xu > --- > include/hw/arm/virt.h | 2 +- > include/hw/boards.h | 8 > include/sysemu/sysemu.h | 2 +- > vl.c| 7 ++- > 4 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/include/hw/arm/virt.h

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Drop extended root field

2019-03-29 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > VTD_RTADDR_RTT is dropped even by the VT-d spec, so QEMU should > probably do the same thing (after all we never really implemented it). > Since we've had a field for that in the migration stream, to keep > compatibility we need to fill the hole up. > >

Re: [Qemu-devel] [PATCH 4/9] cpu/topology: add ARM support for smp machine properties

2019-03-29 Thread Alex Bennée
Like Xu writes: > Signed-off-by: Like Xu > --- > hw/arm/fsl-imx6.c | 5 + > hw/arm/fsl-imx6ul.c| 5 + > hw/arm/fsl-imx7.c | 5 + > hw/arm/highbank.c | 1 + > hw/arm/mcimx6ul-evk.c | 1 + > hw/arm/mcimx7d-sabre.c | 3 +++ > hw/arm/raspi.c | 2 ++ >

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 29 March 2019 09:32 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com;

[Qemu-devel] [PATCH 2/9] cpu/topology: add general support for machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- accel/kvm/kvm-all.c | 3 +++ backends/hostmem.c | 4 cpus.c | 4 exec.c | 2 ++ gdbstub.c| 7 ++- hw/cpu/core.c| 3 +++ hw/smbios/smbios.c | 11 +++

[Qemu-devel] [PATCH 6/9] cpu/topology: add PPC support for smp machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- hw/ppc/e500.c | 3 +++ hw/ppc/mac_newworld.c | 2 ++ hw/ppc/mac_oldworld.c | 2 ++ hw/ppc/pnv.c | 3 +++ hw/ppc/prep.c | 2 ++ hw/ppc/spapr.c| 29 + hw/ppc/spapr_rtas.c | 3 +++ 7 files changed, 44

Re: [Qemu-devel] [PATCH v2 for-4.1] hw/arm/raspi: Diagnose requests for too much RAM

2019-03-29 Thread Peter Maydell
On Thu, 28 Mar 2019 at 21:29, Wainer dos Santos Moschetta wrote: > > > On 03/28/2019 12:29 PM, Peter Maydell wrote: > > The Raspberry Pi boards have a physical memory map which does > > not allow for more than 1GB of RAM. Currently if the user tries > > to ask for more then we fail in a confusing

Re: [Qemu-devel] [PATCH for-4.1] target/arm: Stop using variable length array in dc_zva

2019-03-29 Thread Peter Maydell
On Thu, 28 Mar 2019 at 19:14, Richard Henderson wrote: > > On 3/28/19 7:30 AM, Peter Maydell wrote: > > -void *hostaddr[maxidx]; > > +void *hostaddr[DIV_ROUND_UP(2 * KiB, 1 << TARGET_PAGE_BITS_MIN)]; > > A very fancy way of writing "2". Yes, but I thought this made the

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Drop extended root field

2019-03-29 Thread Peter Xu
On Fri, Mar 29, 2019 at 09:12:06AM +, Dr. David Alan Gilbert wrote: > The change was: > -VMSTATE_UINTTL_EQUAL(env.spr[SPR_PVR], PowerPCCPU), > +VMSTATE_UNUSED(sizeof(target_ulong)), /* was > _EQUAL(env.spr[SPR_PVR]) */ > > so it was always a target-long rather than a portable

Re: [Qemu-devel] [PATCH for-4.0 v2 3/3] block: test block-stream with a base node that is used by block-commit

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
28.03.2019 19:25, Alberto Garcia wrote: > The base node of a block-stream operation indicates the first image > from the backing chain starting from which no data is copied to the > top node. > > The block-stream job allows others to use that base image, so a second > block-stream job could be

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
28.03.2019 21:40, Kevin Wolf wrote: > Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >> bdrv_replace_child() calls bdrv_check_perm() with error_abort on >> loosening permissions. However file-locking operations may fail even >> in this case, for example on NFS. And this leads

[Qemu-devel] [PATCH] migration: comment VMSTATE_UNUSED*() properly

2019-03-29 Thread Peter Xu
It is error prone to use VMSTATE_UNUSED*() sometimes especially when the size of the migration stream of the field is not the same as the size of the structure (boolean is one example). Comment it well so people will be aware of this when people want to use it. Signed-off-by: Peter Xu ---

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Kevin Wolf writes: > auto-read-only=on changed its behaviour in file-posix for the 4.0 > release. Commit hash, please. > This change cannot be detected through the usual mechanisms > like schema introspection. Add a new feature to query-qemu-features to > allow libvirt to detect the

Re: [Qemu-devel] [Qemu-ppc] [PULL 4/8] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

2019-03-29 Thread David Gibson
On Fri, Mar 29, 2019 at 10:37:08AM +0100, BALATON Zoltan wrote: > On Fri, 29 Mar 2019, David Gibson wrote: > > From: Greg Kurz > > > > Signed-off-by: Greg Kurz > > Message-Id: <155359567174.1794128.3183997593369465355.st...@bahia.lan> > > Signed-off-by: David Gibson > > --- > >

Re: [Qemu-devel] [PATCH v3 2/6] nbd/client: Lower min_block for block-status, unaligned size

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 7:27, Eric Blake wrote: > We have a latent bug in our NBD client code, tickled by the brand new > nbdkit 1.11.10 block status support: > > $ nbdkit --filter=log --filter=truncate -U - \ > data data="1" size=511 truncate=64K logfile=/dev/stdout \ > --run

Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties

2019-03-29 Thread Igor Mammedov
On Fri, 29 Mar 2019 16:48:36 +0800 Like Xu wrote: > This patch series make existing cores/threads/sockets into machine > properties and get rid of global variables they use currently. Thanks for looking into it! Its long overdue and rather desired conversion (albeit naive one, but this series is

Re: [Qemu-devel] [Qemu-block] [PATCH] thread-pool: Use an EventNotifier to coordinate with AioContext

2019-03-29 Thread Stefan Hajnoczi
On Tue, Mar 26, 2019 at 12:44:11PM +0100, Sergio Lopez wrote: > > Stefan Hajnoczi writes: > > > On Mon, Mar 25, 2019 at 02:34:36PM +0100, Sergio Lopez wrote: > >> Our current ThreadPool implementation lacks support for AioContext's > >> event notifications. This not only means that it can't take

Re: [Qemu-devel] [PATCH] Replace calls to object_child_foreach() with object_child_foreach_recursive()

2019-03-29 Thread Stefan Hajnoczi
On Tue, Mar 26, 2019 at 10:12:56AM +0100, Paolo Bonzini wrote: > On 26/03/19 08:43, Stefan Hajnoczi wrote: > > On Sun, Mar 10, 2019 at 02:39:13AM +0100, Ernest Esene wrote: > >> Replace calls to object_child_foreach() with > >> object_child_foreach_recursive() > >> when applicable:

[Qemu-devel] [PATCH 3/9] cpu/topology: add uncommon arch support for smp machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- hw/alpha/dp264.c | 1 + hw/hppa/machine.c| 4 hw/mips/boston.c | 1 + hw/mips/mips_malta.c | 9 + hw/sparc/sun4m.c | 2 ++ hw/sparc64/sun4u.c | 2 ++ hw/xtensa/sim.c | 1 + hw/xtensa/xtfpga.c | 1 + 8 files changed, 21

[Qemu-devel] [PATCH 9/9] cpu/topology: replace smp global variables with machine propertie

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- vl.c | 53 ++--- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/vl.c b/vl.c index 9089253..0c5a384 100644 --- a/vl.c +++ b/vl.c @@ -162,10 +162,6 @@ static Chardev **serial_hds; Chardev

[Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties

2019-03-29 Thread Like Xu
This patch series make existing cores/threads/sockets into machine properties and get rid of global variables they use currently. Like Xu (9): cpu/topology: add struct CpuTopology to MachineState cpu/topology: add general support for machine properties cpu/topology: add uncommon arch

[Qemu-devel] [PATCH 7/9] cpu/topology: add riscv support for smp machine properties

2019-03-29 Thread Like Xu
Signed-off-by: Like Xu --- hw/openrisc/openrisc_sim.c | 1 + hw/riscv/sifive_e.c| 4 hw/riscv/sifive_plic.c | 3 +++ hw/riscv/sifive_u.c| 4 hw/riscv/spike.c | 2 ++ hw/riscv/virt.c| 1 + 6 files changed, 15 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] tests/qemu-iotests: Remove redundant COPYING file

2019-03-29 Thread Kevin Wolf
Am 05.02.2019 um 15:49 hat Thomas Huth geschrieben: > The file tests/qemu-iotests/COPYING is the same text as in the > COPYING file in the main directory. So as far as I can see, we don't > need the duplicate here. > > Signed-off-by: Thomas Huth Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Pavel Hrdina
On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > On 3/28/19 3:06 PM, Eric Blake wrote: > >> On 3/28/19 2:32 PM, Markus Armbruster wrote: > >>> Markus Armbruster writes: > Pavel Hrdina writes: > >> > > I'm glad that this is merged now and I

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Drop extended root field

2019-03-29 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Mar 28, 2019 at 11:56:40AM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > VTD_RTADDR_RTT is dropped even by the VT-d spec, so QEMU should > > > probably do the same thing (after all we never really implemented

Re: [Qemu-devel] [PATCH v3 05/10] hw/arm/virt: Add ACPI support for device memory cold-plug

2019-03-29 Thread Auger Eric
Hi Shameer, On 3/21/19 11:47 AM, Shameer Kolothum wrote: > This adds support to build the aml code so that Guest(ACPI boot) > can see the cold-plugged device memory. Memory cold plug support > with DT boot is not yet enabled. > > Signed-off-by: Shameer Kolothum > --- >

<    1   2   3   >